From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: akpm@linux-foundation.org, linux-mmc@vger.kernel.org,
ian@mnementh.co.uk, lethal@linux-sh.org,
Magnus Damm <magnus.damm@gmail.com>,
g.liakhovetski@gmx.de
Subject: [PATCH 03/07] mmc: Remove const from tmio-mmc platform data
Date: Fri, 02 Oct 2009 11:22:32 +0900 [thread overview]
Message-ID: <20091002022232.8215.10549.sendpatchset@rxone.opensource.se> (raw)
In-Reply-To: <20091002022158.8215.58317.sendpatchset@rxone.opensource.se>
From: Magnus Damm <damm@opensource.se>
Remove const from the hclk member of the tmio-mmc platform
data. This to allow assigning a value dynamically to the
platform data in the SuperH Mobile SDHI driver.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Depends on the SuperH Mobile SDHI driver.
drivers/mfd/sh_mobile_sdhi.c | 4 +---
include/linux/mfd/tmio.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
--- 0008/drivers/mfd/sh_mobile_sdhi.c
+++ work/drivers/mfd/sh_mobile_sdhi.c 2009-10-02 09:58:40.000000000 +0900
@@ -84,9 +84,7 @@ static int __init sh_mobile_sdhi_probe(s
}
clk_enable(priv->clk);
-
- /* FIXME: silly const unsigned int hclk */
- *(unsigned int *)&priv->mmc_data.hclk = clk_get_rate(priv->clk);
+ priv->mmc_data.hclk = clk_get_rate(priv->clk);
memcpy(&priv->cell_mmc, &sh_mobile_sdhi_cell, sizeof(priv->cell_mmc));
priv->cell_mmc.driver_data = &priv->mmc_data;
--- 0002/include/linux/mfd/tmio.h
+++ work/include/linux/mfd/tmio.h 2009-10-02 09:55:50.000000000 +0900
@@ -53,7 +53,7 @@ void tmio_core_mmc_clk_div(void __iomem
* data for the MMC controller
*/
struct tmio_mmc_data {
- const unsigned int hclk;
+ unsigned int hclk;
void (*set_pwr)(struct platform_device *host, int state);
void (*set_no_clk_div)(struct platform_device *host, int state);
};
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: akpm@linux-foundation.org, linux-mmc@vger.kernel.org,
ian@mnementh.co.uk, lethal@linux-sh.org,
Magnus Damm <magnus.damm@gmail.com>,
g.liakhovetski@gmx.de
Subject: [PATCH 03/07] mmc: Remove const from tmio-mmc platform data
Date: Fri, 02 Oct 2009 02:22:32 +0000 [thread overview]
Message-ID: <20091002022232.8215.10549.sendpatchset@rxone.opensource.se> (raw)
In-Reply-To: <20091002022158.8215.58317.sendpatchset@rxone.opensource.se>
From: Magnus Damm <damm@opensource.se>
Remove const from the hclk member of the tmio-mmc platform
data. This to allow assigning a value dynamically to the
platform data in the SuperH Mobile SDHI driver.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Depends on the SuperH Mobile SDHI driver.
drivers/mfd/sh_mobile_sdhi.c | 4 +---
include/linux/mfd/tmio.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
--- 0008/drivers/mfd/sh_mobile_sdhi.c
+++ work/drivers/mfd/sh_mobile_sdhi.c 2009-10-02 09:58:40.000000000 +0900
@@ -84,9 +84,7 @@ static int __init sh_mobile_sdhi_probe(s
}
clk_enable(priv->clk);
-
- /* FIXME: silly const unsigned int hclk */
- *(unsigned int *)&priv->mmc_data.hclk = clk_get_rate(priv->clk);
+ priv->mmc_data.hclk = clk_get_rate(priv->clk);
memcpy(&priv->cell_mmc, &sh_mobile_sdhi_cell, sizeof(priv->cell_mmc));
priv->cell_mmc.driver_data = &priv->mmc_data;
--- 0002/include/linux/mfd/tmio.h
+++ work/include/linux/mfd/tmio.h 2009-10-02 09:55:50.000000000 +0900
@@ -53,7 +53,7 @@ void tmio_core_mmc_clk_div(void __iomem
* data for the MMC controller
*/
struct tmio_mmc_data {
- const unsigned int hclk;
+ unsigned int hclk;
void (*set_pwr)(struct platform_device *host, int state);
void (*set_no_clk_div)(struct platform_device *host, int state);
};
next prev parent reply other threads:[~2009-10-02 2:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 2:21 [PATCH 00/07] sh: SuperH Mobile SDHI changes Magnus Damm
2009-10-02 2:21 ` Magnus Damm
2009-10-02 2:22 ` [PATCH 01/07] mfd: Add SuperH Mobile SDHI platform driver Magnus Damm
2009-10-02 2:22 ` Magnus Damm
2009-10-02 2:22 ` [PATCH 02/07] mmc: Add SuperH to the tmio-mmc Kconfig Magnus Damm
2009-10-02 2:22 ` Magnus Damm
2009-10-02 2:22 ` Magnus Damm [this message]
2009-10-02 2:22 ` [PATCH 03/07] mmc: Remove const from tmio-mmc platform data Magnus Damm
2009-10-02 2:22 ` [PATCH 04/07] sh: SDHI platform data to the Migo-R board Magnus Damm
2009-10-02 2:22 ` Magnus Damm
2009-10-02 2:22 ` [PATCH 05/07] sh: SDHI platform data to the AP325RXA board Magnus Damm
2009-10-02 2:22 ` Magnus Damm
2009-10-02 2:23 ` [PATCH 06/07] sh: SDHI platform data to the SE7724 board Magnus Damm
2009-10-02 2:23 ` Magnus Damm
2009-10-02 2:23 ` [PATCH 07/07] sh: SDHI platform data to the kfr2r09 board Magnus Damm
2009-10-02 2:23 ` Magnus Damm
2009-10-02 18:23 ` [PATCH 00/07] sh: SuperH Mobile SDHI changes Ian Molton
2009-10-02 18:23 ` Ian Molton
2009-10-08 21:53 ` Andrew Morton
2009-10-08 21:53 ` Andrew Morton
2009-10-05 2:23 ` Paul Mundt
2009-10-05 2:23 ` Paul Mundt
2009-10-05 20:02 ` Ian Molton
2009-10-05 20:02 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002022232.8215.10549.sendpatchset@rxone.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=lethal@linux-sh.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.