From: Theodore Tso <tytso@mit.edu>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] blkid/Makefile.in: ignore rmdir non-empty dir error
Date: Sat, 3 Oct 2009 22:29:52 -0400 [thread overview]
Message-ID: <20091004022952.GE15688@mit.edu> (raw)
In-Reply-To: <1254135442-28755-1-git-send-email-bergwolf@gmail.com>
On Mon, Sep 28, 2009 at 06:57:22PM +0800, Peng Tao wrote:
> checker/* blkid_types.h ../libblkid.a ../libblkid_p.a \
> $(SMANPAGES) blkid
> - -rmdir tests
> + -rmdir --ignore-fail-on-non-empty tests
>
Sorry, NACK. This will blow up on systems that aren't using the GNU
shellutils. The error is ignored, which is good enough. We can do
something like this instead:
@echo rmdir tests/tmp tests
-@rmdir tests/tmp tests >& /dev/null
If we really care, I suppose.
- Ted
next prev parent reply other threads:[~2009-10-04 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 10:57 [PATCH] blkid/Makefile.in: ignore rmdir non-empty dir error Peng Tao
2009-10-04 2:29 ` Theodore Tso [this message]
2009-10-04 2:47 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091004022952.GE15688@mit.edu \
--to=tytso@mit.edu \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.