From: Theodore Tso <tytso@mit.edu>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] blkid/Makefile.in: ignore rmdir non-empty dir error
Date: Sat, 3 Oct 2009 22:47:25 -0400 [thread overview]
Message-ID: <20091004024725.GG15688@mit.edu> (raw)
In-Reply-To: <1254135442-28755-1-git-send-email-bergwolf@gmail.com>
On Mon, Sep 28, 2009 at 06:57:22PM +0800, Peng Tao wrote:
> Otherwise, make clean returns the following error, which is missleading.
> rmdir tests
> rmdir: failed to remove `tests': Directory not empty
> make: [clean] Error 1 (ignored)
>
> Signed-off-by: Peng Tao <bergwolf@gmail.com>
This is what I checked in instead.
- Ted
commit 7822f784f1edf767cc74044e02702a6d44cee267
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sat Oct 3 22:33:47 2009 -0400
blkid: Avoid a potentially error message when running "make clean"
This error isn't terribly important, but apparently it causes some
users/developers distress.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
diff --git a/lib/blkid/Makefile.in b/lib/blkid/Makefile.in
index 9169226..9339718 100644
--- a/lib/blkid/Makefile.in
+++ b/lib/blkid/Makefile.in
@@ -181,7 +181,8 @@ clean::
tests/*.img results test_probe core profiled/* \
checker/* blkid_types.h ../libblkid.a ../libblkid_p.a \
$(SMANPAGES) blkid
- -rmdir tests
+ @echo rmdir tests/tmp tests
+ @(rmdir tests/tmp tests 2> /dev/null ; exit 0)
mostlyclean:: clean
distclean:: clean
prev parent reply other threads:[~2009-10-04 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 10:57 [PATCH] blkid/Makefile.in: ignore rmdir non-empty dir error Peng Tao
2009-10-04 2:29 ` Theodore Tso
2009-10-04 2:47 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091004024725.GG15688@mit.edu \
--to=tytso@mit.edu \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.