All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastian Blank <bastian@waldi.eu.org>
To: Ingo Molnar <mingo@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Stable Kernel <stable@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] xen: Disable stack protector for irq helper
Date: Sun, 4 Oct 2009 20:30:13 +0200	[thread overview]
Message-ID: <20091004183013.GA26101@wavehammer.waldi.eu.org> (raw)

The stack protector needs additional registers on x86_32, which are not
saved in calls to the small paravirt interrupt handlers. This leads to
early crashes as registers are overwritten and not saved by the caller
as instructed.

Signed-off-by: Bastian Blank <waldi@debian.org>

diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 3bb4fc2..ac19398 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -5,9 +5,9 @@
 CFLAGS_REMOVE_irq.o = -pg
 endif
 
-# Make sure early boot has no stackprotector
 nostackp := $(call cc-option, -fno-stack-protector)
 CFLAGS_enlighten.o		:= $(nostackp)
+CFLAGS_irq.o			:= $(nostackp)
 CFLAGS_mmu.o			:= $(nostackp)
 
 obj-y		:= enlighten.o setup.o multicalls.o mmu.o irq.o \
-- 
Mind your own business, Spock.  I'm sick of your halfbreed interference.

WARNING: multiple messages have this Message-ID (diff)
From: Bastian Blank <bastian@waldi.eu.org>
To: Ingo Molnar <mingo@redhat.com>
Cc: Xen-devel <xen-devel@lists.xensource.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Stable Kernel <stable@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] xen: Disable stack protector for irq helper
Date: Sun, 4 Oct 2009 20:30:13 +0200	[thread overview]
Message-ID: <20091004183013.GA26101@wavehammer.waldi.eu.org> (raw)

The stack protector needs additional registers on x86_32, which are not
saved in calls to the small paravirt interrupt handlers. This leads to
early crashes as registers are overwritten and not saved by the caller
as instructed.

Signed-off-by: Bastian Blank <waldi@debian.org>

diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 3bb4fc2..ac19398 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -5,9 +5,9 @@
 CFLAGS_REMOVE_irq.o = -pg
 endif
 
-# Make sure early boot has no stackprotector
 nostackp := $(call cc-option, -fno-stack-protector)
 CFLAGS_enlighten.o		:= $(nostackp)
+CFLAGS_irq.o			:= $(nostackp)
 CFLAGS_mmu.o			:= $(nostackp)
 
 obj-y		:= enlighten.o setup.o multicalls.o mmu.o irq.o \
-- 
Mind your own business, Spock.  I'm sick of your halfbreed interference.

             reply	other threads:[~2009-10-04 18:30 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-04 18:30 Bastian Blank [this message]
2009-10-04 18:30 ` [PATCH] xen: Disable stack protector for irq helper Bastian Blank
2009-10-04 23:06 ` Jeremy Fitzhardinge
2009-10-04 23:06   ` Jeremy Fitzhardinge
2009-10-05  1:35   ` Bastian Blank
2009-10-05  1:35     ` Bastian Blank
2009-10-05 17:21     ` Jeremy Fitzhardinge
2009-10-05 17:21       ` Jeremy Fitzhardinge
2009-10-05 22:43       ` [Xen-devel] " Bastian Blank
2009-10-05 22:43         ` Bastian Blank
2009-10-06  0:36         ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-06  0:36           ` Jeremy Fitzhardinge
2009-10-06  3:30           ` [Xen-devel] " Bastian Blank
2009-10-06  3:30             ` Bastian Blank
2009-10-06 19:01             ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-06 19:01               ` Jeremy Fitzhardinge
2009-10-07 16:35               ` [Xen-devel] " Bastian Blank
2009-10-07 16:35                 ` Bastian Blank
2009-10-08  0:33                 ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-08  0:33                   ` Jeremy Fitzhardinge
2009-10-12 20:52                   ` [Xen-devel] " Ingo Molnar
2009-10-12 20:52                     ` Ingo Molnar
2009-10-12 21:12                     ` [Xen-devel] " Bastian Blank
2009-10-12 21:12                       ` Bastian Blank
2009-10-12 22:20                       ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-12 22:20                         ` Jeremy Fitzhardinge
2009-10-12 23:32                     ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-12 23:32                       ` Jeremy Fitzhardinge
2009-10-13  7:25                       ` [tip:x86/urgent] x86/paravirt: Use normal calling sequences for irq enable/disable tip-bot for Jeremy Fitzhardinge
2009-10-13  7:25                         ` tip-bot for Jeremy Fitzhardinge
2009-10-05  1:52   ` [PATCH] xen: fbdev frontend needs xenbus frontend Bastian Blank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091004183013.GA26101@wavehammer.waldi.eu.org \
    --to=bastian@waldi.eu.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.