From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 0/4][RFC]: coding convention for CCID-struct prefixes
Date: Mon, 05 Oct 2009 12:38:23 +0000 [thread overview]
Message-ID: <20091005123823.GE30535@ghostprotocols.net> (raw)
In-Reply-To: <1254739993-5051-1-git-send-email-gerrit@erg.abdn.ac.uk>
Em Mon, Oct 05, 2009 at 01:23:59PM +0200, Gerrit Renker escreveu:
> | After Arnaldo takes a look, I can add this as-is to net-next-2.6
> This should work, they have been compile/sparse-tested and apply cleanly on net-2.6.
>
> I am waiting for the feedback also in order to rebuild the test tree; and have
> informed CCID-4 developers (CCID-4 subtree) about this.
On a first look I saw one inconsistency, while in ccid3 you do:
- return scaled_div(w_init << 6, hctx->tx_rtt);
+ return scaled_div(w_init << 6, hc->tx_rtt);
in ccid2 you do:
- struct ccid2_seq *seqp = hctx->ccid2hctx_seqh;
+ struct ccid2_seq *seqp = hctx->tx_seqh;
Since this change is about reducing the names by removing redundancy, I
think the ccid3 variant is better, i.e.: hc->tx_foo.
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Gerrit Renker <gerrit@erg.abdn.ac.uk>,
David Miller <davem@davemloft.net>,
dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/4][RFC]: coding convention for CCID-struct prefixes
Date: Mon, 5 Oct 2009 09:38:23 -0300 [thread overview]
Message-ID: <20091005123823.GE30535@ghostprotocols.net> (raw)
In-Reply-To: <20091005112359.GB5156@gerrit.erg.abdn.ac.uk>
Em Mon, Oct 05, 2009 at 01:23:59PM +0200, Gerrit Renker escreveu:
> | After Arnaldo takes a look, I can add this as-is to net-next-2.6
> This should work, they have been compile/sparse-tested and apply cleanly on net-2.6.
>
> I am waiting for the feedback also in order to rebuild the test tree; and have
> informed CCID-4 developers (CCID-4 subtree) about this.
On a first look I saw one inconsistency, while in ccid3 you do:
- return scaled_div(w_init << 6, hctx->tx_rtt);
+ return scaled_div(w_init << 6, hc->tx_rtt);
in ccid2 you do:
- struct ccid2_seq *seqp = hctx->ccid2hctx_seqh;
+ struct ccid2_seq *seqp = hctx->tx_seqh;
Since this change is about reducing the names by removing redundancy, I
think the ccid3 variant is better, i.e.: hc->tx_foo.
- Arnaldo
next prev parent reply other threads:[~2009-10-05 12:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 10:53 [PATCH 0/4][RFC]: coding convention for CCID-struct prefixes Gerrit Renker
2009-10-05 10:53 ` Gerrit Renker
2009-10-05 10:58 ` David Miller
2009-10-05 10:58 ` David Miller
2009-10-05 11:23 ` Gerrit Renker
2009-10-05 11:23 ` Gerrit Renker
2009-10-05 12:38 ` Arnaldo Carvalho de Melo [this message]
2009-10-05 12:38 ` Arnaldo Carvalho de Melo
2009-10-06 5:36 ` Gerrit Renker
2009-10-06 5:36 ` Gerrit Renker
2009-10-07 13:31 ` Arnaldo Carvalho de Melo
2009-10-07 13:31 ` Arnaldo Carvalho de Melo
2009-10-07 20:51 ` David Miller
2009-10-07 20:51 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-10-05 10:53 [PATCH 1/4][RFC] dccp ccid-2: Overhaul CCID naming convention 1/2 Gerrit Renker
2009-10-05 10:53 ` Gerrit Renker
2009-10-05 10:53 [PATCH 2/4][RFC] dccp ccid-3: Overhaul CCID naming convention 2/2 Gerrit Renker
2009-10-05 10:53 ` Gerrit Renker
2009-10-05 10:53 [PATCH 3/4][RFC] dccp ccid-2: Remove CCID naming redundancy 1/2 Gerrit Renker
2009-10-05 10:53 ` Gerrit Renker
2009-10-05 10:53 [PATCH 4/4][RFC] dccp ccid-3: Remove CCID naming redundancy 2/2 Gerrit Renker
2009-10-05 10:53 ` Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005123823.GE30535@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.