From: Ingo Molnar <mingo@elte.hu>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Dirk Hohndel <hohndel@infradead.org>, Len Brown <lenb@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] kbuild: Improve version string logic
Date: Tue, 6 Oct 2009 20:49:11 +0200 [thread overview]
Message-ID: <20091006184911.GA833@elte.hu> (raw)
In-Reply-To: <1254854227.22426.37.camel@johannes.local>
* Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2009-10-06 at 19:35 +0200, Ingo Molnar wrote:
>
> > It changes how CONFIG_LOCALVERSION_AUTO works, in the following trivial
> > way:
> >
> > - if it is set, things work the way they always have, and you get a
> > extended kernel release like:
> >
> > 2.6.32-rc3+00052-g0eca52a-dirty
> >
> > ( with the difference that the extra version string is separated via
> > '+' not via '-'. This improves visibility when we have additional
> > changes over a vanilla tag. )
>
> I really don't see how it improves visibility (unless you're oblivious
> to the difference between long and short strings), but I do know that
> I have a few parsers that this will break.
It improves visibility the same way the + at the end of the short
version improves visibility.
That said, i'm perfectly fine with just having the short version include
the '+' sign (i.e. Linus's original patch), that was my original
suggestion and that is already a big step forward.
Thanks,
Ingo
next prev parent reply other threads:[~2009-10-06 18:50 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 0:44 Linux 2.6.32-rc3 Linus Torvalds
2009-10-05 18:55 ` James Cloos
2009-10-06 1:57 ` Len Brown
2009-10-06 2:51 ` Dirk Hohndel
2009-10-06 14:18 ` Linus Torvalds
2009-10-06 14:38 ` Dirk Hohndel
2009-10-06 15:13 ` Linus Torvalds
2009-10-06 15:34 ` Dirk Hohndel
2009-10-06 15:43 ` Linus Torvalds
[not found] ` <4ACBB7D7.10207@urpla.net>
2009-10-06 22:13 ` Linus Torvalds
2009-10-06 16:36 ` Frans Pop
2009-10-07 1:09 ` Bryan Donlan
2009-10-07 5:56 ` Frans Pop
2009-10-06 14:44 ` Ingo Molnar
2009-10-06 15:24 ` Linus Torvalds
2009-10-06 15:36 ` Ingo Molnar
2009-10-06 15:51 ` Linus Torvalds
2009-10-06 16:29 ` Ingo Molnar
2009-10-06 16:35 ` Ingo Molnar
2009-10-06 16:31 ` Linus Torvalds
2009-10-06 16:40 ` Ingo Molnar
2009-10-06 18:12 ` Theodore Tso
2009-10-06 18:24 ` Ingo Molnar
2009-10-06 21:19 ` Stefan Richter
2009-10-06 17:15 ` Stefan Richter
2009-10-06 18:16 ` Ingo Molnar
2009-10-06 17:22 ` Frans Pop
2009-10-06 17:32 ` Linus Torvalds
2009-10-06 18:29 ` Frans Pop
2009-10-07 0:51 ` Florian Mickler
2009-10-06 17:35 ` [patch] kbuild: Improve version string logic Ingo Molnar
2009-10-06 18:37 ` Johannes Berg
2009-10-06 18:49 ` Ingo Molnar [this message]
2009-10-06 18:55 ` Johannes Berg
2009-10-06 19:03 ` Theodore Tso
2009-10-06 19:45 ` Frans Pop
2009-10-06 19:48 ` Johannes Berg
2009-10-06 20:25 ` Frans Pop
2009-10-07 2:43 ` David Rientjes
2009-10-12 19:57 ` [PATCH, v2] " Ingo Molnar
2009-10-12 22:04 ` Frans Pop
2009-10-13 7:05 ` Ingo Molnar
2009-10-13 17:51 ` Frans Pop
2009-10-13 18:01 ` Linus Torvalds
2009-10-13 23:59 ` David Rientjes
2009-10-14 6:59 ` Ingo Molnar
2009-10-14 7:24 ` David Rientjes
2009-10-14 7:33 ` Ingo Molnar
2009-10-14 7:42 ` David Rientjes
2009-10-14 23:43 ` Frans Pop
2009-10-15 7:37 ` David Rientjes
2009-10-15 14:13 ` Frans Pop
2009-10-15 20:38 ` David Rientjes
2009-10-15 21:01 ` Frans Pop
2009-10-15 9:03 ` Ingo Molnar
2009-10-15 14:42 ` Frans Pop
2009-10-15 20:45 ` David Rientjes
2009-10-15 8:01 ` David Rientjes
2009-10-15 8:59 ` Ingo Molnar
2009-10-14 21:55 ` Frans Pop
2009-10-13 2:00 ` David Rientjes
2009-10-13 7:07 ` Ingo Molnar
2009-10-13 7:59 ` David Rientjes
2010-06-07 17:18 ` [PATCH, v2] kbuild: Improve version string logic - two for the price of one - No thanks Boaz Harrosh
2010-06-07 19:45 ` David Rientjes
2010-06-08 5:52 ` Boaz Harrosh
2010-06-08 6:18 ` David Rientjes
2010-06-08 6:34 ` Paul Mundt
2010-06-08 6:39 ` Boaz Harrosh
2010-06-08 7:16 ` Boaz Harrosh
2010-06-08 7:21 ` Paul Mundt
2010-06-08 7:21 ` Boaz Harrosh
2010-06-08 7:32 ` Paul Mundt
2010-06-08 7:52 ` Boaz Harrosh
2010-06-08 9:17 ` David Rientjes
2010-06-08 6:37 ` Boaz Harrosh
2010-06-08 8:31 ` kbuild: Fix the breakage caused by "improve version string logic" Boaz Harrosh
2010-06-08 9:13 ` David Rientjes
2010-06-08 10:14 ` Boaz Harrosh
2010-06-08 10:19 ` Boaz Harrosh
2010-06-09 6:55 ` David Rientjes
2010-06-09 7:54 ` Boaz Harrosh
2010-06-09 8:18 ` Mike Galbraith
2009-10-06 17:40 ` Linux 2.6.32-rc3 Len Brown
2009-10-06 18:16 ` Linus Torvalds
2009-10-07 22:33 ` Len Brown
2009-10-06 17:45 ` Dirk Hohndel
2009-10-06 19:22 ` Joel Becker
[not found] ` <4ACB77ED.6060104@grm.uci.cu>
2009-10-06 18:00 ` Herlin R. Matos Lastres
2009-10-15 15:51 ` Frans Pop
2009-10-06 15:42 ` Linus Torvalds
2009-10-06 17:09 ` Frans Pop
2009-10-06 17:34 ` Stefan Richter
2009-10-06 17:41 ` Linus Torvalds
2009-10-06 18:56 ` david
2009-10-06 18:23 ` Frans Pop
2009-10-06 19:23 ` Stefan Richter
2009-10-06 17:44 ` Theodore Tso
2009-10-06 18:14 ` Theodore Tso
2009-10-06 18:20 ` Linus Torvalds
2009-10-06 16:40 ` Frans Pop
2009-10-06 18:35 ` Linus Torvalds
2009-10-06 19:37 ` Frans Pop
2009-10-07 21:39 ` Steven Rostedt
2009-10-08 15:20 ` Frans Pop
2009-10-06 15:29 ` Stefan Richter
2009-10-06 17:08 ` Ingo Molnar
2009-10-06 17:20 ` Stefan Richter
2009-10-06 21:33 ` Benjamin Herrenschmidt
2009-10-06 22:19 ` Linus Torvalds
2009-10-07 1:22 ` Dave Airlie
2009-10-07 2:31 ` Theodore Tso
2009-10-07 2:45 ` Benjamin Herrenschmidt
2009-10-10 12:09 ` Pavel Machek
2009-10-10 12:18 ` Felipe Contreras
2009-10-07 3:23 ` Linus Torvalds
2009-10-07 3:31 ` Linus Torvalds
2009-10-07 13:52 ` Theodore Tso
2009-10-07 14:52 ` Mike Galbraith
2009-10-07 17:44 ` david
2009-10-07 18:13 ` Mike Galbraith
2009-10-07 4:02 ` Justin P. Mattock
2009-10-07 10:41 ` 2.6.32-rc3: floating-point build failure (undefined reference to `__udivdi3' in menu governor) Andreas Mohr
2009-10-07 14:23 ` Arjan van de Ven
2009-10-07 17:34 ` Andreas Mohr
2009-10-07 17:45 ` Arjan van de Ven
2009-10-07 17:45 ` Kyle McMartin
2009-10-09 16:01 ` Andreas Mohr
2009-10-09 16:32 ` Arjan van de Ven
2009-10-09 17:08 ` Kyle McMartin
2009-10-09 17:12 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2010-01-04 21:31 [patch] kbuild: improve version string logic David Rientjes
2010-01-05 13:59 ` Michal Marek
2010-01-05 14:11 ` Stephen Rothwell
2010-01-13 21:01 ` David Rientjes
2010-01-16 6:37 ` Ingo Molnar
2010-01-16 7:34 ` Stephen Rothwell
2010-01-16 9:26 ` Ingo Molnar
2010-01-18 9:40 ` Michal Marek
2010-01-18 10:45 ` David Rientjes
2010-01-18 11:15 ` Michal Marek
2010-01-18 15:53 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006184911.GA833@elte.hu \
--to=mingo@elte.hu \
--cc=hohndel@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.