[Qemu-devel] Re: [PATCH 02/15] Introduce QList

[Luiz Capitulino <lcapitulino@redhat.com>]

On Tue, 06 Oct 2009 20:37:43 -0500
Anthony Liguori <aliguori@us.ibm.com> wrote:

> Luiz Capitulino wrote:

[...]

> > +/**
> > + * qlist_destroy_obj(): Free all the memory allocated by a QList
> > + */
> > +static void qlist_destroy_obj(QObject *obj)
> > +{
> > +    QList *qlist;
> > +    QListEntry *entry, *next_entry;
> > +
> > +    assert(obj != NULL);
> >   
> 
> Usually accepting NULL in a free function makes for nicer exit paths in 
> function.

 The destroy_obj() functions are always called by qobject_decref()
and it will never pass a NULL qobject.

 But qobject_decref() accepts NULL.

 I've applied the other changes, some of them also need to be done
in the others data types (will send patches).