[Qemu-devel] Re: [PATCH 04/15] monitor: Add user_print() to mon_cmd_t

[Luiz Capitulino <lcapitulino@redhat.com>]

On Tue, 06 Oct 2009 20:40:31 -0500
Anthony Liguori <aliguori@us.ibm.com> wrote:

> Luiz Capitulino wrote:
> > This new struct member will store a pointer to a function that
> > should be used to output data in the user protocol format.
> >
> > It will also serve as a flag to say if a given handler has already
> > been converted to the new QObject style.
> >
> > Additionally, this commit converts mon_cmd_t static initializations
> > to the C99 way.
> >   
> 
> This should really be two patches.  One that does the mon_cmd_t init 
> conversion and then another that introduces user_print.  This would be 
> easier if...

 Ok, will split.

> <snip>
> > +    {
> > +        .name       = "version",
> > +        .args_type  = "",
> > +        .handler    = do_info_version,
> > +        .user_print = NULL,
> > +        .params     = "",
> > +        .help       = "show the version of QEMU"
> > +    },
> >   
> 
> You didn't explicitly initialize things to NULL and made sure that 
> args_types = "" worked the same as args_type = NULL (and likewise for 
> params.  This would help de-uglify what's happening in this file :-)

 I think this work is part of the patch series which will change
args_type to be an array, as suggested by Markus.

 This is series is just an initial help.