From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: SZEDER G??bor <szeder@ira.uka.de>,
Stephen Boyd <bebarino@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 3/3] completion: add dirstat and friends to diff options
Date: Wed, 7 Oct 2009 21:32:42 -0700 [thread overview]
Message-ID: <20091008043242.GY9261@spearce.org> (raw)
In-Reply-To: <7vmy42pzvc.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> SZEDER G??bor <szeder@ira.uka.de> writes:
>
> > On Wed, Oct 07, 2009 at 01:48:51AM -0700, Stephen Boyd wrote:
> >> + --dirstat --dirstat= --dirstat-by-file
> >> + --dirstat-by-file= --cumulative
> >
> > I'm a bit puzzled by having both --dirstat and --dirstat=, and
> > --dirstat-by-file and --dirstat-by-file=. How do we complete similar
> > long options, where an argument and hence the = char is optional?
>
> A similar example in "git init" completion (--shared vs --shared=) already
> exists, no?
I'm not sure why this is. It may just be historical accident,
completing --shared vs. --shared= is ambiguous so you would need
to type out the = anyway before trying to complete a value.
IIRC --shared= came about after --shared and its possible we just
added the new option and didn't notice the duplicate.
--
Shawn.
next prev parent reply other threads:[~2009-10-08 4:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 8:48 [PATCH 1/3] completion: fix alias listings with newlines Stephen Boyd
2009-10-07 8:48 ` [PATCH 2/3] completion: update am, commit, and log Stephen Boyd
2009-10-07 8:48 ` [PATCH 3/3] completion: add dirstat and friends to diff options Stephen Boyd
2009-10-07 19:45 ` Junio C Hamano
[not found] ` <20091007205059.GA16235@neumann>
2009-10-07 23:07 ` Junio C Hamano
[not found] ` <20091007233442.GJ6055@neumann>
2009-10-08 0:11 ` Stephen Boyd
2009-10-08 4:32 ` Shawn O. Pearce [this message]
2009-10-07 19:45 ` [PATCH 2/3] completion: update am, commit, and log Junio C Hamano
2009-10-07 9:33 ` [PATCH 1/3] completion: fix alias listings with newlines Johannes Sixt
2009-10-07 18:55 ` Stephen Boyd
2009-10-08 4:29 ` Shawn O. Pearce
2009-10-08 7:34 ` Stephen Boyd
2009-10-08 7:54 ` Johannes Sixt
2009-10-08 8:01 ` Stephen Boyd
2009-10-08 8:10 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008043242.GY9261@spearce.org \
--to=spearce@spearce.org \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.