From: Stephen Boyd <bebarino@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] completion: fix alias listings with newlines
Date: Thu, 08 Oct 2009 01:01:42 -0700 [thread overview]
Message-ID: <4ACD9C66.1080308@gmail.com> (raw)
In-Reply-To: <4ACD9ABC.4070809@viscovery.net>
Johannes Sixt wrote:
>
> OTOH, you can simply revert the hunk from 518ef8f (completion: Replace
> config --list with --get-regexp, 2009-09-11) that applies here, or even
> only reinstate the case statement in the loop body without changing
> anything else.
I'm not opposed to the idea, but then it wouldn't work with something like
[alias]
whowhat = "log --format="%an\nalias.broken=foo'"
although that actually happening is probably rare, it can still happen.
next prev parent reply other threads:[~2009-10-08 8:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 8:48 [PATCH 1/3] completion: fix alias listings with newlines Stephen Boyd
2009-10-07 8:48 ` [PATCH 2/3] completion: update am, commit, and log Stephen Boyd
2009-10-07 8:48 ` [PATCH 3/3] completion: add dirstat and friends to diff options Stephen Boyd
2009-10-07 19:45 ` Junio C Hamano
[not found] ` <20091007205059.GA16235@neumann>
2009-10-07 23:07 ` Junio C Hamano
[not found] ` <20091007233442.GJ6055@neumann>
2009-10-08 0:11 ` Stephen Boyd
2009-10-08 4:32 ` Shawn O. Pearce
2009-10-07 19:45 ` [PATCH 2/3] completion: update am, commit, and log Junio C Hamano
2009-10-07 9:33 ` [PATCH 1/3] completion: fix alias listings with newlines Johannes Sixt
2009-10-07 18:55 ` Stephen Boyd
2009-10-08 4:29 ` Shawn O. Pearce
2009-10-08 7:34 ` Stephen Boyd
2009-10-08 7:54 ` Johannes Sixt
2009-10-08 8:01 ` Stephen Boyd [this message]
2009-10-08 8:10 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACD9C66.1080308@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.