From: Gabriel Paubert <paubert@iram.es>
To: "Jérôme Pouiller" <j.pouiller@sysmic.fr>
Cc: netdev <netdev@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org,
Andy Fleming <afleming@freescale.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Nested function in drivers/of/of_mdio.c
Date: Thu, 8 Oct 2009 13:14:27 +0200 [thread overview]
Message-ID: <20091008111427.GA16941@iram.es> (raw)
In-Reply-To: <200910081045.12590.j.pouiller@sysmic.fr>
On Thu, Oct 08, 2009 at 10:45:12AM +0200, Jérôme Pouiller wrote:
> I did some grep on codebase. I have not found any other instances of
> nested functions, but my regexps are not enough to be 100% sure.
>From Documentation/CodingStyle, written by the Head Penguin himself:
"Heretic people all over the world have claimed that this inconsistency
is ... well ... inconsistent, but all right-thinking people know that
(a) K&R are _right_ and (b) K&R are right. Besides, functions are
special anyway (you can't nest them in C)."
^^^^^^^^^^^^^^^^^^^^^^^^
I interpret it as a clear prohibition of using nested functions
in the kernel.
Regards,
Gabriel
next prev parent reply other threads:[~2009-10-08 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 15:15 Nested function in drivers/of/of_mdio.c Jérôme Pouiller
2009-10-07 15:15 ` Jérôme Pouiller
2009-10-07 16:11 ` Grant Likely
2009-10-07 16:11 ` Grant Likely
2009-10-07 16:23 ` vb
2009-10-07 16:23 ` vb
2009-10-08 8:45 ` Jérôme Pouiller
2009-10-08 8:45 ` Jérôme Pouiller
2009-10-08 11:14 ` Gabriel Paubert [this message]
2009-10-08 8:34 ` [PATCH] Remove nested function Jérôme Pouiller
2009-10-08 8:34 ` Jérôme Pouiller
2009-10-08 9:10 ` David Miller
2009-10-08 9:10 ` David Miller
[not found] <200910071629.15804.jezz@sysmic.org>
2009-10-07 14:55 ` Nested function in drivers/of/of_mdio.c Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008111427.GA16941@iram.es \
--to=paubert@iram.es \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=j.pouiller@sysmic.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.