All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] *clean targets
Date: Fri, 9 Oct 2009 10:00:08 +0200	[thread overview]
Message-ID: <20091009100008.7d0f2c65@surf> (raw)
In-Reply-To: <20091009095152.555ceed2@surf>

Hello,

Le Fri, 9 Oct 2009 09:51:52 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :

> Good to get a discussion on clean targets. They are currently a mess.
> Thanks for raising the topic and starting a discussion on this topic.

Ignore some of my comments, I didn't see the attached patch (it seems
it was not inline), making it harder to comment on.

 * On the clean target

   I see that all the stamps are removed. So this will trigger
   basically a reconfigure + rebuild of all packages. Is this what we
   want ?

   Same question as before: is removing the target/ directory without
   removing the staging/ directory really safe ?

   Removing $(IMAGE) will not do anything, since $(IMAGE) is the prefix
   for the filesystem images. I.e, the tar image is $(IMAGE).tar.
   Shouldn't we just remove $(BINARIES_DIR) ?

 * Your description mention realclean, but the patch implements dirclean

 * Detail: in dirclean (realclean ?), shouldn't we erase $(BASE_DIR)
   simply, instead of erasing all individual directories it contains ?

 * On distclean: removing the BUILD_DIR and TOOLCHAIN_DIR is already
   done by dirclean, on which distclean depends. If clean removes
   BINARIES_DIR as suggested above, we can also drop this clean here.

 * Documentation (both 'make help' and the HTML documentation)

Again, thanks a lot for working on this issue.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2009-10-09  8:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 16:24 [Buildroot] [RFC] *clean targets Bernhard Reutner-Fischer
2009-10-07 16:32 ` Sven Neumann
2009-10-07 18:12   ` Peter Korsgaard
2009-10-07 18:25     ` Bernhard Reutner-Fischer
2009-10-07 18:26 ` Peter Korsgaard
2009-10-07 18:31   ` Bernhard Reutner-Fischer
2009-10-07 19:31     ` Peter Korsgaard
2009-10-09  8:01     ` Thomas Petazzoni
2009-10-07 18:27 ` Peter Korsgaard
2009-10-09  7:51 ` Thomas Petazzoni
2009-10-09  8:00   ` Thomas Petazzoni [this message]
2009-10-09  9:48     ` Bernhard Reutner-Fischer
2009-10-09 11:28       ` Peter Korsgaard
2009-11-20 13:04         ` Peter Korsgaard
2009-11-20 15:28           ` Bernhard Reutner-Fischer
2009-11-20 15:55             ` Peter Korsgaard
2009-11-20 16:19             ` Bernhard Reutner-Fischer
2009-11-20 16:20               ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091009100008.7d0f2c65@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.