From: Wolfram Sang <w.sang@pengutronix.de>
To: Nate Case <ncase@xes-inc.com>
Cc: devicetree-discuss@ozlabs.org, linux-embedded@vger.kernel.org,
linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org
Subject: Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver
Date: Fri, 9 Oct 2009 18:20:20 +0200 [thread overview]
Message-ID: <20091009162020.GB588@pengutronix.de> (raw)
In-Reply-To: <1255096871.16018.49.camel@localhost.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 873 bytes --]
> I can submit that soon, but it probably makes sense for Wolfram to
> voice whatever his concerns were about "questionable" properties before
> I document what's there.
Please don't feel offended. The things I noticed are:
a) no documentation
b) 'polarity' is a direct mapping to the register which IMO is a hint to look
closer. I haven't checked in detil, but maybe the active_low-flag could be used
for this?
I mainly got alarmed that properties were mainlined without being reviewed; as
the device-tree is based on convention (which is hard to change afterwards), I
try to make sure this will not so easily happen again (thus the
get_maintainer-patch on lkml).
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang@pengutronix.de>
To: Nate Case <ncase@xes-inc.com>
Cc: devicetree-discuss@ozlabs.org, linux-embedded@vger.kernel.org,
linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org
Subject: Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver
Date: Fri, 9 Oct 2009 18:20:20 +0200 [thread overview]
Message-ID: <20091009162020.GB588@pengutronix.de> (raw)
In-Reply-To: <1255096871.16018.49.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
> I can submit that soon, but it probably makes sense for Wolfram to
> voice whatever his concerns were about "questionable" properties before
> I document what's there.
Please don't feel offended. The things I noticed are:
a) no documentation
b) 'polarity' is a direct mapping to the register which IMO is a hint to look
closer. I haven't checked in detil, but maybe the active_low-flag could be used
for this?
I mainly got alarmed that properties were mainlined without being reviewed; as
the device-tree is based on convention (which is hard to change afterwards), I
try to make sure this will not so easily happen again (thus the
get_maintainer-patch on lkml).
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-10-09 16:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 14:04 [RFC] misc/at24: add experimental OF support for the generic eeprom driver Wolfram Sang
2009-10-08 14:33 ` Anton Vorontsov
[not found] ` <20091008143301.GA6084-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-10-08 14:53 ` Grant Likely
2009-10-08 14:53 ` Grant Likely
2009-10-08 15:10 ` Anton Vorontsov
2009-10-08 15:48 ` Grant Likely
2009-10-08 15:48 ` Grant Likely
2009-10-08 15:48 ` Grant Likely
2009-10-08 20:27 ` Wolfram Sang
2009-10-08 20:27 ` Wolfram Sang
2009-10-09 5:14 ` Wolfram Sang
2009-10-09 5:14 ` Wolfram Sang
[not found] ` <20091009051409.GA2361-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-10-09 5:40 ` Grant Likely
2009-10-09 5:40 ` Grant Likely
2009-10-09 5:40 ` Grant Likely
2009-10-09 14:01 ` Nate Case
2009-10-09 14:01 ` Nate Case
2009-10-09 16:09 ` Grant Likely
2009-10-09 16:09 ` Grant Likely
2009-10-09 16:09 ` Grant Likely
2009-10-09 16:20 ` Wolfram Sang [this message]
2009-10-09 16:20 ` Wolfram Sang
2009-10-09 13:43 ` Nate Case
2009-10-09 16:12 ` Wolfram Sang
2009-10-09 16:12 ` Wolfram Sang
2009-10-09 16:13 ` Grant Likely
2009-10-09 16:13 ` Grant Likely
2009-10-09 16:13 ` Grant Likely
[not found] ` <fa686aa40910080848r459c47baob73fc70a95a08604-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-08 22:20 ` Anton Vorontsov
2009-10-08 22:20 ` Anton Vorontsov
2009-10-09 6:37 ` Grant Likely
2009-10-09 6:37 ` Grant Likely
2009-10-09 6:37 ` Grant Likely
2009-10-08 14:37 ` Grant Likely
[not found] ` <fa686aa40910080737l5b21654cw9c8f7426f9faf7c3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-08 20:48 ` Wolfram Sang
2009-10-08 20:48 ` Wolfram Sang
[not found] ` <20091008204808.GB8116-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-10-08 22:59 ` Grant Likely
2009-10-08 22:59 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009162020.GB588@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=devicetree-discuss@ozlabs.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ncase@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.