[PATCH] tracing - enabling "__cold" functions

[PATCH] tracing - enabling "__cold" functions

[jolsa]

Based on the commit:

a586df06 "x86: Support __attribute__((__cold__)) in gcc 4.3"

some of the functions goes to the ".text.unlikely" section.

Looks like there's not many of them (I found printk, panic,
__ssb_dma_not_implemented, fat_fs_error), but still worth
to include I think.

wbr,
jirka


Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 scripts/recordmcount.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index 090d300..bfb8b2c 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -119,6 +119,7 @@ my %text_sections = (
      ".sched.text" => 1,
      ".spinlock.text" => 1,
      ".irqentry.text" => 1,
+     ".text.unlikely" => 1,
 );
 
 $objdump = "objdump" if ((length $objdump) == 0);

Re: [PATCH] tracing - enabling "__cold" functions

[Jiri Olsa]

any feedback on this one?

thanks,
jirka

On Fri, Oct 09, 2009 at 06:14:59PM +0200, jolsa@redhat.com wrote:
> Based on the commit:
> 
> a586df06 "x86: Support __attribute__((__cold__)) in gcc 4.3"
> 
> some of the functions goes to the ".text.unlikely" section.
> 
> Looks like there's not many of them (I found printk, panic,
> __ssb_dma_not_implemented, fat_fs_error), but still worth
> to include I think.
> 
> wbr,
> jirka
> 
> 
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> ---
>  scripts/recordmcount.pl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index 090d300..bfb8b2c 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -119,6 +119,7 @@ my %text_sections = (
>       ".sched.text" => 1,
>       ".spinlock.text" => 1,
>       ".irqentry.text" => 1,
> +     ".text.unlikely" => 1,
>  );
>  
>  $objdump = "objdump" if ((length $objdump) == 0);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] tracing - enabling "__cold" functions

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> any feedback on this one?

Steve said he's queueing it up. (But 3 days of delay, especially if it's 
over the weekend and if it's not an urgent fix is to be expected so 
please be patient.)

	Ingo

Re: [PATCH] tracing - enabling "__cold" functions

[Jiri Olsa]

On Mon, Oct 12, 2009 at 01:27:45PM +0200, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > any feedback on this one?
> 
> Steve said he's queueing it up. (But 3 days of delay, especially if it's 
> over the weekend and if it's not an urgent fix is to be expected so 
> please be patient.)
> 
> 	Ingo

no rush :) it's just I usually get reply like "looking on this" or smth..
so I thought it might get lost, sry for noise

jirka

Re: [PATCH] tracing - enabling "__cold" functions

[Steven Rostedt]

On Mon, 2009-10-12 at 13:39 +0200, Jiri Olsa wrote:
> On Mon, Oct 12, 2009 at 01:27:45PM +0200, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > > any feedback on this one?
> > 
> > Steve said he's queueing it up. (But 3 days of delay, especially if it's 
> > over the weekend and if it's not an urgent fix is to be expected so 
> > please be patient.)
> > 
> > 	Ingo
> 
> no rush :) it's just I usually get reply like "looking on this" or smth..
> so I thought it might get lost, sry for noise

No prob. Yes I'm looking at this ;-)

-- Steve