All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
	Jamie Lokier <jamie@shareable.org>, Avi Kivity <avi@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant
Date: Mon, 12 Oct 2009 18:57:57 +0200	[thread overview]
Message-ID: <20091012165757.GA19380@redhat.com> (raw)
In-Reply-To: <4AD34EAB.5020501@redhat.com>

On Mon, Oct 12, 2009 at 05:43:39PM +0200, Gerd Hoffmann wrote:
> On 10/12/09 16:52, Gleb Natapov wrote:
>> On Mon, Oct 12, 2009 at 04:50:35PM +0200, Gerd Hoffmann wrote:
>>> pc.c does some magic here to map the complete bios into high memory
>>> and the legacy part at 0xe0000, thats why it is loaded in a
>>> different way. It gets loaded to IO_MEM_ROM memory though, so the
>>> guest should not be able to corrupt it.
>>>
>> But KVM doesn't support it (memory is always writable). And we want to reload
>> BIOS on reboot for migration purposes.
>
> Then it should be switched over to the new rom loader.  Also the logic  
> which does *not* reload stuff which goes to IO_MEM_ROM must be turned  
> off for kvm them.

I think it needs to be turned off anyway.  Since ROM is sent over for
migration, it might get out of sync with file even if it is read-only.

> cheers,
>   Gerd

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Gleb Natapov <gleb@redhat.com>, kvm-devel <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant
Date: Mon, 12 Oct 2009 18:57:57 +0200	[thread overview]
Message-ID: <20091012165757.GA19380@redhat.com> (raw)
In-Reply-To: <4AD34EAB.5020501@redhat.com>

On Mon, Oct 12, 2009 at 05:43:39PM +0200, Gerd Hoffmann wrote:
> On 10/12/09 16:52, Gleb Natapov wrote:
>> On Mon, Oct 12, 2009 at 04:50:35PM +0200, Gerd Hoffmann wrote:
>>> pc.c does some magic here to map the complete bios into high memory
>>> and the legacy part at 0xe0000, thats why it is loaded in a
>>> different way. It gets loaded to IO_MEM_ROM memory though, so the
>>> guest should not be able to corrupt it.
>>>
>> But KVM doesn't support it (memory is always writable). And we want to reload
>> BIOS on reboot for migration purposes.
>
> Then it should be switched over to the new rom loader.  Also the logic  
> which does *not* reload stuff which goes to IO_MEM_ROM must be turned  
> off for kvm them.

I think it needs to be turned off anyway.  Since ROM is sent over for
migration, it might get out of sync with file even if it is read-only.

> cheers,
>   Gerd

  reply	other threads:[~2009-10-12 17:01 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1255013225.git.mst@redhat.com>
2009-10-08 14:52 ` [PATCH 1/3] pc-bios: enable io/memory unconditionally Michael S. Tsirkin
2009-10-08 14:52   ` [Qemu-devel] " Michael S. Tsirkin
2009-10-08 14:52 ` [PATCH 2/3] qemu: make cirrus init value pci spec compliant Michael S. Tsirkin
2009-10-08 14:52   ` [Qemu-devel] " Michael S. Tsirkin
2009-10-08 15:29   ` Avi Kivity
2009-10-08 15:29     ` [Qemu-devel] " Avi Kivity
2009-10-08 16:06     ` Michael S. Tsirkin
2009-10-08 16:06       ` [Qemu-devel] " Michael S. Tsirkin
2009-10-08 16:13       ` Avi Kivity
2009-10-08 16:13         ` [Qemu-devel] " Avi Kivity
2009-10-08 18:40         ` Jamie Lokier
2009-10-08 18:40           ` Jamie Lokier
2009-10-08 19:39           ` Michael S. Tsirkin
2009-10-08 19:39             ` Michael S. Tsirkin
2009-10-09  6:43           ` Michael S. Tsirkin
2009-10-09  6:43             ` Michael S. Tsirkin
2009-10-09  7:00             ` Gleb Natapov
2009-10-09  7:00               ` Gleb Natapov
2009-10-09 10:13               ` Michael S. Tsirkin
2009-10-09 10:13                 ` [Qemu-devel] " Michael S. Tsirkin
2009-10-09 11:49                 ` Gleb Natapov
2009-10-09 11:49                   ` Gleb Natapov
2009-10-09 12:59                   ` Michael S. Tsirkin
2009-10-09 12:59                     ` Michael S. Tsirkin
2009-10-09 15:08                     ` Gleb Natapov
2009-10-09 15:08                       ` Gleb Natapov
2009-10-12 13:45                   ` Gerd Hoffmann
2009-10-12 13:45                     ` Gerd Hoffmann
2009-10-12 13:53                     ` Gleb Natapov
2009-10-12 13:53                       ` Gleb Natapov
2009-10-12 14:50                       ` Gerd Hoffmann
2009-10-12 14:50                         ` Gerd Hoffmann
2009-10-12 14:52                         ` Gleb Natapov
2009-10-12 14:52                           ` Gleb Natapov
2009-10-12 15:21                           ` Jamie Lokier
2009-10-12 15:21                             ` Jamie Lokier
2009-10-12 15:43                           ` Gerd Hoffmann
2009-10-12 15:43                             ` [Qemu-devel] " Gerd Hoffmann
2009-10-12 16:57                             ` Michael S. Tsirkin [this message]
2009-10-12 16:57                               ` Michael S. Tsirkin
2009-10-09 11:37             ` Jamie Lokier
2009-10-09 11:37               ` Jamie Lokier
2009-10-09 11:54               ` Gleb Natapov
2009-10-09 11:54                 ` Gleb Natapov
2009-10-11 13:36           ` Michael S. Tsirkin
2009-10-11 13:36             ` Michael S. Tsirkin
2009-10-11 13:45             ` Gleb Natapov
2009-10-11 13:45               ` Gleb Natapov
2009-10-11 13:52               ` Michael S. Tsirkin
2009-10-11 13:52                 ` [Qemu-devel] " Michael S. Tsirkin
2009-10-11 13:57                 ` Gleb Natapov
2009-10-11 13:57                   ` Gleb Natapov
2009-10-11 14:35                   ` Michael S. Tsirkin
2009-10-11 14:35                     ` Michael S. Tsirkin
2009-10-11 14:39                     ` Gleb Natapov
2009-10-11 14:39                       ` Gleb Natapov
2009-10-11 14:45                       ` Michael S. Tsirkin
2009-10-11 14:45                         ` Michael S. Tsirkin
2009-10-11 15:00                         ` Gleb Natapov
2009-10-11 15:00                           ` [Qemu-devel] " Gleb Natapov
2009-10-12 13:44                       ` Anthony Liguori
2009-10-12 13:44                         ` [Qemu-devel] " Anthony Liguori
2009-10-12 14:21                         ` Gleb Natapov
2009-10-12 14:21                           ` Gleb Natapov
2009-10-12 14:31                           ` Anthony Liguori
2009-10-12 14:31                             ` Anthony Liguori
2009-10-12 15:00                         ` Kevin O'Connor
2009-10-12 15:00                           ` Kevin O'Connor
2009-10-11 14:42                     ` Avi Kivity
2009-10-11 14:42                       ` Avi Kivity
2009-10-11 14:44                       ` Michael S. Tsirkin
2009-10-11 14:44                         ` Michael S. Tsirkin
2009-10-11 14:53                         ` Avi Kivity
2009-10-11 14:53                           ` Avi Kivity
2009-10-11 16:12                           ` Michael S. Tsirkin
2009-10-11 16:12                             ` Michael S. Tsirkin
2009-10-11 16:24                             ` Avi Kivity
2009-10-11 16:24                               ` Avi Kivity
2009-10-11 16:33                               ` Michael S. Tsirkin
2009-10-11 16:33                                 ` Michael S. Tsirkin
2009-10-11 16:37                                 ` Avi Kivity
2009-10-11 16:37                                   ` Avi Kivity
2009-10-11 16:39                                   ` Michael S. Tsirkin
2009-10-11 16:39                                     ` [Qemu-devel] " Michael S. Tsirkin
2009-10-11 16:48                                     ` Avi Kivity
2009-10-11 16:48                                       ` [Qemu-devel] " Avi Kivity
2009-10-11 17:18                                       ` Michael S. Tsirkin
2009-10-11 17:18                                         ` Michael S. Tsirkin
2009-10-11 17:27                                         ` Avi Kivity
2009-10-11 17:27                                           ` Avi Kivity
2009-10-11 17:28                                           ` Avi Kivity
2009-10-11 17:28                                             ` Avi Kivity
2009-10-11 18:10                                             ` Michael S. Tsirkin
2009-10-11 18:10                                               ` Michael S. Tsirkin
2009-10-11 20:41                                               ` Avi Kivity
2009-10-11 20:41                                                 ` Avi Kivity
2009-10-08 14:52 ` [PATCH 3/3] qemu: cleanup unused macros in cirrus Michael S. Tsirkin
2009-10-08 14:52   ` [Qemu-devel] " Michael S. Tsirkin
2009-10-08 15:24   ` Juan Quintela
2009-10-08 16:07     ` Michael S. Tsirkin
2009-10-08 16:07       ` [Qemu-devel] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091012165757.GA19380@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jamie@shareable.org \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.