From: spender@grsecurity.net (Brad Spengler)
To: Matthew Wilcox <matthew@wil.cx>
Cc: Yinghai Lu <yinghai@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ia64: Don't call SAL < 3.2 for extended config space
Date: Tue, 13 Oct 2009 03:33:40 +0000 [thread overview]
Message-ID: <20091013033340.GA8673@grsecurity.net> (raw)
In-Reply-To: <20091012142430.GE7545@parisc-linux.org>
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
> + } else if (sal_revision >= SAL_VERSION_CODE(3,2))
Looks like a missing ending { here ^
> + } else if (sal_revision >= SAL_VERSION_CODE(3,2))
and here ^
I'll test it to confirm it fixes the problem.
-Brad
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: spender@grsecurity.net (Brad Spengler)
To: Matthew Wilcox <matthew@wil.cx>
Cc: Yinghai Lu <yinghai@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ia64: Don't call SAL < 3.2 for extended config space
Date: Mon, 12 Oct 2009 23:33:40 -0400 [thread overview]
Message-ID: <20091013033340.GA8673@grsecurity.net> (raw)
In-Reply-To: <20091012142430.GE7545@parisc-linux.org>
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
> + } else if (sal_revision >= SAL_VERSION_CODE(3,2))
Looks like a missing ending { here ^
> + } else if (sal_revision >= SAL_VERSION_CODE(3,2))
and here ^
I'll test it to confirm it fixes the problem.
-Brad
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2009-10-13 3:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091011074531.GA12357@grsecurity.net>
2009-10-11 10:06 ` Boot-time crash from "PCI/x86: detect host bridge config space size w/o using quirks" Yinghai Lu
2009-10-11 21:00 ` [PATCH] pci: fix crash about old IA64 about pci_cfg_space_size Yinghai Lu
2009-10-11 21:32 ` Brad Spengler
2009-10-11 23:10 ` Matthew Wilcox
2009-10-12 13:56 ` Brad Spengler
2009-10-12 14:24 ` [PATCH] ia64: Don't call SAL < 3.2 for extended config space Matthew Wilcox
2009-10-12 14:24 ` Matthew Wilcox
2009-10-13 3:33 ` Brad Spengler [this message]
2009-10-13 3:33 ` Brad Spengler
2009-10-13 4:58 ` Brad Spengler
2009-10-13 4:58 ` Brad Spengler
2009-11-04 17:16 ` Jesse Barnes
2009-11-04 17:16 ` Jesse Barnes
2009-11-04 17:20 ` Luck, Tony
2009-11-04 17:20 ` Luck, Tony
2009-11-04 17:22 ` Jesse Barnes
2009-11-04 17:22 ` Jesse Barnes
2009-10-11 22:16 ` [RFC PATCH] ia64/pci: add ext pci config detection for SAL 3.2 less Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013033340.GA8673@grsecurity.net \
--to=spender@grsecurity.net \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.