From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Lothar Wassmann <LW@KARO-electronics.de>,
linux-usb@vger.kernel.org, Roland Dreier <rolandd@cisco.com>,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
netdev@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, linux-altix@sgi.com
Subject: Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear,
Date: Tue, 13 Oct 2009 09:10:17 +0000 [thread overview]
Message-ID: <20091013091017.GA18431@localhost.localdomain> (raw)
In-Reply-To: <20091013021818.GA3898@localhost.localdomain>
My user space testing exposed off-by-one error find_next_zero_area
in iommu-helper. Some zero area cannot be found by this bug.
Subject: [PATCH] Fix off-by-one error in find_next_zero_area
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
lib/iommu-helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c
index 75dbda0..afc58bc 100644
--- a/lib/iommu-helper.c
+++ b/lib/iommu-helper.c
@@ -19,7 +19,7 @@ again:
index = (index + align_mask) & ~align_mask;
end = index + nr;
- if (end >= size)
+ if (end > size)
return -1;
for (i = index; i < end; i++) {
if (test_bit(i, map)) {
--
1.5.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
x86@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-altix@sgi.com,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linuxppc-dev@ozlabs.org, Ingo Molnar <mingo@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-usb@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Lothar Wassmann <LW@KARO-electronics.de>
Subject: Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area
Date: Tue, 13 Oct 2009 18:10:17 +0900 [thread overview]
Message-ID: <20091013091017.GA18431@localhost.localdomain> (raw)
In-Reply-To: <20091013021818.GA3898@localhost.localdomain>
My user space testing exposed off-by-one error find_next_zero_area
in iommu-helper. Some zero area cannot be found by this bug.
Subject: [PATCH] Fix off-by-one error in find_next_zero_area
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
lib/iommu-helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c
index 75dbda0..afc58bc 100644
--- a/lib/iommu-helper.c
+++ b/lib/iommu-helper.c
@@ -19,7 +19,7 @@ again:
index = (index + align_mask) & ~align_mask;
end = index + nr;
- if (end >= size)
+ if (end > size)
return -1;
for (i = index; i < end; i++) {
if (test_bit(i, map)) {
--
1.5.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
x86@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-altix@sgi.com,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linuxppc-dev@ozlabs.org, Ingo Molnar <mingo@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-usb@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Lothar Wassmann <LW@KARO-electronics.de>
Subject: Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear,
Date: Tue, 13 Oct 2009 09:10:17 +0000 [thread overview]
Message-ID: <20091013091017.GA18431@localhost.localdomain> (raw)
In-Reply-To: <20091013021818.GA3898@localhost.localdomain>
My user space testing exposed off-by-one error find_next_zero_area
in iommu-helper. Some zero area cannot be found by this bug.
Subject: [PATCH] Fix off-by-one error in find_next_zero_area
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
lib/iommu-helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c
index 75dbda0..afc58bc 100644
--- a/lib/iommu-helper.c
+++ b/lib/iommu-helper.c
@@ -19,7 +19,7 @@ again:
index = (index + align_mask) & ~align_mask;
end = index + nr;
- if (end >= size)
+ if (end > size)
return -1;
for (i = index; i < end; i++) {
if (test_bit(i, map)) {
--
1.5.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Lothar Wassmann <LW@KARO-electronics.de>,
linux-usb@vger.kernel.org, Roland Dreier <rolandd@cisco.com>,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
netdev@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, linux-altix@sgi.com
Subject: Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area
Date: Tue, 13 Oct 2009 18:10:17 +0900 [thread overview]
Message-ID: <20091013091017.GA18431@localhost.localdomain> (raw)
In-Reply-To: <20091013021818.GA3898@localhost.localdomain>
My user space testing exposed off-by-one error find_next_zero_area
in iommu-helper. Some zero area cannot be found by this bug.
Subject: [PATCH] Fix off-by-one error in find_next_zero_area
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
lib/iommu-helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c
index 75dbda0..afc58bc 100644
--- a/lib/iommu-helper.c
+++ b/lib/iommu-helper.c
@@ -19,7 +19,7 @@ again:
index = (index + align_mask) & ~align_mask;
end = index + nr;
- if (end >= size)
+ if (end > size)
return -1;
for (i = index; i < end; i++) {
if (test_bit(i, map)) {
--
1.5.4.3
next prev parent reply other threads:[~2009-10-13 9:10 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 8:29 [PATCH 1/8] iommu-helper: Simplify find_next_zero_area Akinobu Mita
2009-10-09 8:29 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-09 8:29 ` Akinobu Mita
2009-10-09 8:29 ` Akinobu Mita
2009-10-09 8:29 ` Akinobu Mita
2009-10-09 8:29 ` [PATCH 3/8] iommu-helper: Use bitmap library Akinobu Mita
2009-10-09 8:29 ` Akinobu Mita
2009-10-09 8:29 ` Akinobu Mita
2009-10-09 8:29 ` [PATCH 4/8] isp1362-hcd: Use bitmap_find_next_zero_area Akinobu Mita
2009-10-09 8:29 ` [PATCH 5/8] mlx4: " Akinobu Mita
2009-10-09 8:29 ` [PATCH 6/8] sparc: " Akinobu Mita
2009-10-09 8:29 ` Akinobu Mita
2009-10-09 8:29 ` [PATCH 7/8] ia64: " Akinobu Mita
2009-10-09 8:29 ` Akinobu Mita
2009-10-09 8:29 ` [PATCH 8/8] genalloc: " Akinobu Mita
2009-10-09 9:16 ` [PATCH 6/8] sparc: " David Miller
2009-10-09 9:16 ` David Miller
2009-10-09 23:41 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Andrew Morton
2009-10-09 23:41 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Andrew Morton
2009-10-09 23:41 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Andrew Morton
2009-10-09 23:41 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Andrew Morton
2009-10-13 2:18 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-13 2:18 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-13 2:18 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-13 2:18 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-13 9:10 ` Akinobu Mita [this message]
2009-10-13 9:10 ` Akinobu Mita
2009-10-13 9:10 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-13 9:10 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-13 21:54 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Michael Ellerman
2009-10-13 21:54 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Michael Ellerman
2009-10-13 21:54 ` Michael Ellerman
2009-10-13 21:54 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Michael Ellerman
2009-10-13 21:54 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Michael Ellerman
2009-10-14 3:39 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-14 3:39 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-14 3:39 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-14 3:39 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-14 3:22 ` [PATCH -mmotm] Fix Akinobu Mita
2009-10-14 3:22 ` [PATCH -mmotm] Fix bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area. patch Akinobu Mita
2009-10-14 3:22 ` [PATCH -mmotm] Fix Akinobu Mita
2009-10-14 3:22 ` [PATCH -mmotm] Fix bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area. patch Akinobu Mita
2009-10-15 6:07 ` [PATCH -mmotm -v2] Fix Akinobu Mita
2009-10-15 6:07 ` [PATCH -mmotm -v2] Fix bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area. patch Akinobu Mita
2009-10-15 6:07 ` [PATCH -mmotm -v2] Fix Akinobu Mita
2009-10-15 6:07 ` [PATCH -mmotm -v2] Fix bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area. patch Akinobu Mita
2009-10-17 13:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, FUJITA Tomonori
2009-10-17 13:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area FUJITA Tomonori
2009-10-17 13:43 ` FUJITA Tomonori
2009-10-17 13:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, FUJITA Tomonori
2009-10-17 13:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area FUJITA Tomonori
2009-10-17 14:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-17 14:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-17 14:43 ` Akinobu Mita
2009-10-17 14:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-17 14:43 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-17 14:51 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, FUJITA Tomonori
2009-10-17 14:51 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area FUJITA Tomonori
2009-10-17 14:51 ` FUJITA Tomonori
2009-10-17 14:51 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, FUJITA Tomonori
2009-10-17 14:51 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area FUJITA Tomonori
2009-10-17 15:42 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-17 15:42 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
2009-10-17 15:42 ` Akinobu Mita
2009-10-17 15:42 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, Akinobu Mita
2009-10-17 15:42 ` [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013091017.GA18431@localhost.localdomain \
--to=akinobu.mita@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=linux-altix@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rolandd@cisco.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.