[PATCH 0/3 v3] spi: controller driver for Designware SPI core and PCI interface

[PATCH 0/3 v3] spi: controller driver for Designware SPI core and PCI interface

[Feng Tang]

Hi all,

This patch series adds driver for Designware SPI core + PCI interface, and
they are generated against kernel 2.6.32-rc4

0001: driver for the DW SPI core
0002: driver for PCI interface
0003: add DMA support

This driver has been verified on Intel Moorestown platform, with Maxim's
Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works
fine, and these 2 slave devcies can work simultaneously.

0003 is RFC only, as it has dependency over DMA controller driver's acceptance
to mainline.

User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet

please help to review them.

---------------
change history:
	v3
	* address some review comments from Andrew Morton
	
	v2
	* divide the original one driver to "core+interface" framework
	  according to David's comments

	v1
	* initial submission 

Thanks,
Feng

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

Re: [PATCH 0/3 v3] spi: controller driver for Designware SPI core and PCI interface

[Andrew Morton]

On Mon, 12 Oct 2009 14:17:16 +0800
Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

> This patch series adds driver for Designware SPI core + PCI interface, and
> they are generated against kernel 2.6.32-rc4
> 
> 0001: driver for the DW SPI core
> 0002: driver for PCI interface
> 0003: add DMA support
> 
> This driver has been verified on Intel Moorestown platform, with Maxim's
> Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works
> fine, and these 2 slave devcies can work simultaneously.
> 
> 0003 is RFC only, as it has dependency over DMA controller driver's acceptance
> to mainline.

What is "DMA controller driver"?  Some other patch?  What is the status
of that patch and where is it?


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

Re: [PATCH 0/3 v3] spi: controller driver for Designware SPI core and PCI interface

[Feng Tang]

On Tue, 13 Oct 2009 06:25:53 +0800
Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:

> On Mon, 12 Oct 2009 14:17:16 +0800
> Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> 
> > This patch series adds driver for Designware SPI core + PCI
> > interface, and they are generated against kernel 2.6.32-rc4
> > 
> > 0001: driver for the DW SPI core
> > 0002: driver for PCI interface
> > 0003: add DMA support
> > 
> > This driver has been verified on Intel Moorestown platform, with
> > Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO
> > and DMA works fine, and these 2 slave devcies can work
> > simultaneously.
> > 
> > 0003 is RFC only, as it has dependency over DMA controller driver's
> > acceptance to mainline.
> 
> What is "DMA controller driver"?  Some other patch?  What is the
> status of that patch and where is it?
> 
Yes, it's another driver patch for DMA controller of Moorestown, which
is developed by another guy. I don't know if he has submitted the patch
to community (I guess not), though we did test the SPIC+DMAC+3G-Modem.

Thanks,
Feng

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

Re: [PATCH 0/3 v3] spi: controller driver for Designware SPI core and PCI interface

[Andrew Morton]

On Tue, 13 Oct 2009 09:36:49 +0800 Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

> On Tue, 13 Oct 2009 06:25:53 +0800
> Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> 
> > On Mon, 12 Oct 2009 14:17:16 +0800
> > Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > 
> > > This patch series adds driver for Designware SPI core + PCI
> > > interface, and they are generated against kernel 2.6.32-rc4
> > > 
> > > 0001: driver for the DW SPI core
> > > 0002: driver for PCI interface
> > > 0003: add DMA support
> > > 
> > > This driver has been verified on Intel Moorestown platform, with
> > > Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO
> > > and DMA works fine, and these 2 slave devcies can work
> > > simultaneously.
> > > 
> > > 0003 is RFC only, as it has dependency over DMA controller driver's
> > > acceptance to mainline.
> > 
> > What is "DMA controller driver"?  Some other patch?  What is the
> > status of that patch and where is it?
> > 
> Yes, it's another driver patch for DMA controller of Moorestown, which
> is developed by another guy. I don't know if he has submitted the patch
> to community (I guess not), though we did test the SPIC+DMAC+3G-Modem.

So am I correct in believing that your "0003: add DMA support" doesn't
actually work?  That it depends on some other patch which is
unavailable to testers and reviewers and patch integrators?

Strange.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

Re: [PATCH 0/3 v3] spi: controller driver for Designware SPI core and PCI interface

[Feng Tang]

On Tue, 13 Oct 2009 09:53:27 +0800
Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:

> > > > 
> > > > 0003 is RFC only, as it has dependency over DMA controller
> > > > driver's acceptance to mainline.
> > > 
> > > What is "DMA controller driver"?  Some other patch?  What is the
> > > status of that patch and where is it?
> > > 
> > Yes, it's another driver patch for DMA controller of Moorestown,
> > which is developed by another guy. I don't know if he has submitted
> > the patch to community (I guess not), though we did test the
> > SPIC+DMAC+3G-Modem.
> 
> So am I correct in believing that your "0003: add DMA support" doesn't
> actually work?  That it depends on some other patch which is
> unavailable to testers and reviewers and patch integrators?

Yes, it's fair enough to not trust the 0003 patch and remove it from mm
tree :) That's why I added a [RFC] for it.

Also many thanks for reviewing the patches, they have been not receiving
any comments for a while.

Thanks,
Feng

> 
> Strange.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference