From: Marcelo Tosatti <mtosatti@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Sridhar Samudrala <sri@us.ibm.com>,
avi@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org
Subject: Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices
Date: Tue, 13 Oct 2009 12:35:27 -0300 [thread overview]
Message-ID: <20091013153527.GA5940@amt.cnet> (raw)
In-Reply-To: <1255072288.2786.13.camel@blaa>
On Fri, Oct 09, 2009 at 08:11:28AM +0100, Mark McLoughlin wrote:
> On Thu, 2009-10-08 at 15:31 -0700, Sridhar Samudrala wrote:
> > On Thu, 2009-10-08 at 11:07 +0100, Mark McLoughlin wrote:
> > > On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote:
> > > > linux 2.6.32 includes UDP fragmentation offload support in software.
> > > > So we can enable UFO on the host tap device if supported and allow setting
> > > > UFO on virtio-net in the guest.
> > >
> > > Hmm, we really need to detect whether the host has tuntap UFO support
> > > before advertising it to the guest. Maybe in net_tap_fd_init() we should
> > > toggle TUN_F_UFO back and forth and check for EINVAL?
> >
> > Sure. Here is an updated patch that checks for UFO support in host.
>
> Looks good to me, thanks
>
> Acked-by: Mark McLoughlin <markmc@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2009-10-13 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 21:50 [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices Sridhar Samudrala
2009-10-08 10:07 ` Mark McLoughlin
2009-10-08 22:31 ` Sridhar Samudrala
2009-10-09 7:11 ` Mark McLoughlin
2009-10-13 15:35 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013153527.GA5940@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.