From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Refer to kernel of FreeBSD as "kFreeBSD"
Date: Wed, 14 Oct 2009 18:49:35 +0200 [thread overview]
Message-ID: <20091014164935.GC1739@thorin> (raw)
In-Reply-To: <20091014124304.GC28534@riva.ucam.org>
On Wed, Oct 14, 2009 at 01:43:05PM +0100, Colin Watson wrote:
> On Wed, Oct 14, 2009 at 02:28:48PM +0200, Robert Millan wrote:
> > Note: Some string lengths were hardcoded, and they're being replaced with
> > sizeof() statements. I triple-checked them for off-by-one mistakes, but it
> > doesn't hurt if someone else reviews it. Please avoid hardcoding constant
> > string lengths! It makes it more error-prone to change those strings later.
>
> I reviewed the string code and it looks fine.
Thanks Colin. I committed this.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
prev parent reply other threads:[~2009-10-14 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 12:28 [PATCH] Refer to kernel of FreeBSD as "kFreeBSD" Robert Millan
2009-10-14 12:43 ` Colin Watson
2009-10-14 16:49 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014164935.GC1739@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.