From: Simon Horman <horms@verge.net.au>
To: Tom Rotenberg <tom.rotenberg@gmail.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Possible bug with pass-through hot-plug?
Date: Thu, 15 Oct 2009 22:06:35 +1100 [thread overview]
Message-ID: <20091015110632.GA14946@verge.net.au> (raw)
In-Reply-To: <8686c3cd0910150238h3d79d81dse8ee1ecb8f5350f2@mail.gmail.com>
On Thu, Oct 15, 2009 at 11:38:39AM +0200, Tom Rotenberg wrote:
> Simon,
>
> i'm glad you were able to re-produce it :)
>
> About the bug, i suspect that the code in the virtual DSDT, which
> "checks" which device was hot-plugged, is really not efficient, as it
> needs to go over all sltos prior to the new assigned slot before
> notifying the device. This means that if the slot number is 0x14, then
> the 'if' clause in the dsdt, needs about 20*8=160 if statements before
> it's notifying, and this what i think is causing the problem.
> Especially, because the GPE interrupt is defined as level interrupt.
>
> This bug can be fixed, using one of the followings:
> 1. Improve the code in the virtual DSDT (e.g.: doing some sort of
> 'binary-search' to see which device should be notified. This will
> reduce the number of 'if' clause to evaluate from 160 to ~5)
> 2. Change the interrupt to edge interrupt, and see if it helps
>
> What do u say?
It sounds worth investigating. do you want to come up with a patch?
next prev parent reply other threads:[~2009-10-15 11:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 9:00 Possible bug with pass-through hot-plug? Tom Rotenberg
2009-10-07 9:38 ` Simon Horman
[not found] ` <8686c3cd0910070256p77f58aeat23aea646aaf82b86@mail.gmail.com>
[not found] ` <20091007120246.GA5088@verge.net.au>
2009-10-07 15:28 ` Tom Rotenberg
2009-10-07 15:41 ` Tom Rotenberg
2009-10-07 22:52 ` Simon Horman
2009-10-07 23:41 ` Simon Horman
2009-10-08 13:55 ` Tom Rotenberg
2009-10-08 22:36 ` Simon Horman
2009-10-09 8:36 ` Tom Rotenberg
2009-10-09 8:59 ` Simon Horman
2009-10-09 9:07 ` Simon Horman
2009-10-09 11:30 ` Tom Rotenberg
2009-10-09 11:47 ` Simon Horman
2009-10-09 11:49 ` Tom Rotenberg
2009-10-09 12:09 ` Simon Horman
2009-10-09 14:29 ` Tom Rotenberg
2009-10-10 1:41 ` Simon Horman
2009-10-11 9:57 ` Tom Rotenberg
2009-10-12 22:36 ` Simon Horman
2009-10-13 9:08 ` Tom Rotenberg
2009-10-13 9:43 ` Simon Horman
2009-10-13 9:52 ` Tom Rotenberg
2009-10-15 9:31 ` Simon Horman
2009-10-15 9:38 ` Tom Rotenberg
2009-10-15 11:06 ` Simon Horman [this message]
2009-10-15 14:02 ` Tom Rotenberg
2009-10-16 7:43 ` Simon Horman
2009-10-18 5:20 ` Tom Rotenberg
2009-10-19 2:09 ` Simon Horman
2009-10-19 2:27 ` Tom Rotenberg
2009-10-19 2:45 ` Simon Horman
2009-11-24 5:48 ` Simon Horman
2009-11-25 12:25 ` Tom Rotenberg
2009-11-26 13:54 ` Keir Fraser
2009-11-26 22:47 ` Simon Horman
2009-11-29 10:27 ` Tom Rotenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015110632.GA14946@verge.net.au \
--to=horms@verge.net.au \
--cc=tom.rotenberg@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.