From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
Alban Browaeys <prahal@yahoo.com>,
Benoit PAPILLAULT <benoit.papillault@free.fr>,
Felix Fietkau <nbd@openwrt.org>,
Luis Correia <luis.f.correia@gmail.com>,
Mattias Nissler <mattias.nissler@gmx.de>,
Mark Asselstine <asselsm@gmail.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci
Date: Sat, 17 Oct 2009 17:19:23 +0200 [thread overview]
Message-ID: <200910171719.24093.bzolnier@gmail.com> (raw)
In-Reply-To: <1255792104.3434.2.camel@johannes.local>
On Saturday 17 October 2009 17:08:24 Johannes Berg wrote:
> On Sat, 2009-10-17 at 16:54 +0200, Bartlomiej Zolnierkiewicz wrote:
>
> > I also used the opportunity to take a closer look at this driver and
> > it seems that it needlessly adds around 2 KLOC to kernel by duplicating
> > the common content of rt2800usb.h to rt2800pci.h instead of moving it
> > to the shared header (like it is done in the staging crap drivers):
>
> Tell me you're kidding -- comparing 2k duplicated LOC with a driver that
> ships its own wifi stack?
Why would I be?
1) The patch is submitted to kernel _proper_ not kernel staging so I see
no excuse for duplicating 2-4 KLOC and it should be fixed.
2) The fact that the some staging driver consists in 90% of crap doesn't
mean that it doesn't have some good design ideas.. (i.e. abstracting chipset
registers access in a discussed case)
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@host1.serialmonkey.com,
Alban Browaeys <prahal@yahoo.com>,
Benoit PAPILLAULT <benoit.papillault@free.fr>,
Felix Fietkau <nbd@openwrt.org>,
Luis Correia <luis.f.correia@gmail.com>,
Mattias Nissler <mattias.nissler@gmx.de>,
Mark Asselstine <asselsm@gmail.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rt2x00: Implement support for rt2800pci
Date: Sat, 17 Oct 2009 17:19:23 +0200 [thread overview]
Message-ID: <200910171719.24093.bzolnier@gmail.com> (raw)
In-Reply-To: <1255792104.3434.2.camel@johannes.local>
On Saturday 17 October 2009 17:08:24 Johannes Berg wrote:
> On Sat, 2009-10-17 at 16:54 +0200, Bartlomiej Zolnierkiewicz wrote:
>
> > I also used the opportunity to take a closer look at this driver and
> > it seems that it needlessly adds around 2 KLOC to kernel by duplicating
> > the common content of rt2800usb.h to rt2800pci.h instead of moving it
> > to the shared header (like it is done in the staging crap drivers):
>
> Tell me you're kidding -- comparing 2k duplicated LOC with a driver that
> ships its own wifi stack?
Why would I be?
1) The patch is submitted to kernel _proper_ not kernel staging so I see
no excuse for duplicating 2-4 KLOC and it should be fixed.
2) The fact that the some staging driver consists in 90% of crap doesn't
mean that it doesn't have some good design ideas.. (i.e. abstracting chipset
registers access in a discussed case)
next prev parent reply other threads:[~2009-10-17 15:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200910152137.58164.IvDoorn@gmail.com>
2009-10-15 20:04 ` [PATCH 2/2] rt2x00: Implement support for rt2800pci Ivo van Doorn
2009-10-16 9:49 ` Simon Raffeiner
2009-10-16 10:55 ` [rt2x00-users] " Ivo van Doorn
2009-10-16 11:12 ` Xose Vazquez Perez
2009-10-16 12:13 ` Simon Raffeiner
2009-10-17 14:54 ` Bartlomiej Zolnierkiewicz
2009-10-17 14:54 ` Bartlomiej Zolnierkiewicz
2009-10-17 15:08 ` Johannes Berg
2009-10-17 15:08 ` Johannes Berg
2009-10-17 15:19 ` Bartlomiej Zolnierkiewicz [this message]
2009-10-17 15:19 ` Bartlomiej Zolnierkiewicz
2009-10-17 21:18 ` Bartlomiej Zolnierkiewicz
2009-10-17 21:18 ` Bartlomiej Zolnierkiewicz
2009-10-18 9:40 ` Luis Correia
2009-10-18 9:40 ` Luis Correia
2009-10-18 3:08 ` Julian Calaby
2009-10-18 3:08 ` Julian Calaby
2009-10-18 16:59 ` Ivo van Doorn
2009-10-18 16:59 ` Ivo van Doorn
2009-10-19 15:56 ` Bartlomiej Zolnierkiewicz
2009-10-19 15:56 ` Bartlomiej Zolnierkiewicz
2009-10-19 17:42 ` Ivo van Doorn
2009-10-19 17:42 ` Ivo van Doorn
2009-10-20 6:58 ` Holger Schurig
2009-10-20 6:58 ` Holger Schurig
2009-10-20 16:31 ` Ivo van Doorn
2009-10-20 16:31 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910171719.24093.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=asselsm@gmail.com \
--cc=benoit.papillault@free.fr \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luis.f.correia@gmail.com \
--cc=mattias.nissler@gmx.de \
--cc=nbd@openwrt.org \
--cc=prahal@yahoo.com \
--cc=users@rt2x00.serialmonkey.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.