From: Ingo Molnar <mingo@elte.hu>
To: Thomas Schlichter <thomas.schlichter@web.de>
Cc: Jan Beulich <JBeulich@novell.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Robert Hancock <hancockrwd@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Tejun Heo <tj@kernel.org>,
x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arjan van de Ven <arjan@linux.intel.com>,
dri-devel@lists.sourceforge.net, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
Thomas Hellstrom <thellstrom@vmware.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC Patch] use MTRR for write combining if PAT is not available
Date: Wed, 21 Oct 2009 13:57:34 +0200 [thread overview]
Message-ID: <20091021115734.GG16586@elte.hu> (raw)
In-Reply-To: <200910202154.20195.thomas.schlichter@web.de>
* Thomas Schlichter <thomas.schlichter@web.de> wrote:
> Jan Beulich wrote:
>
> > Functionality-wise this looks fine to me; whether the core sysfs
> > changes are acceptable I can't judge, though.
>
> OK, I think I should have addressed your comments. Unfortunately I had
> to use a little "hack" to make pci_mmap_page_range() work for sysfs
> and proc. I placed a "private" pointer in the beginning of both
> per-file private structures. So this pointer can be accessed
> independent from the caller. I hope this is acceptable.
>
> I dropped the ioremap() and set_memory_wc() patches, I could not
> implement reference counting for them and it may interact too much
> with existing GPU drivers.
>
> Again, this series should not change the current behavior if either
> MTRR is disabled or PAT is enabled. But it helps in the case that MTRR
> is enabled and PAT is not available.
>
> What should be done now to get this series on the right "track"?
Can we eliminate mtrr_add_unaligned() as Suresh suggested, and still
make it work on your testbox?
Once that's done i'll look at putting it into the x86 tree for testing.
The acks of Suresh/Venki/Jan would be nice to have.
Ingo
next prev parent reply other threads:[~2009-10-21 11:58 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 14:47 [RFC Patch] use MTRR for write combining if PAT is not available Thomas Schlichter
2009-10-20 19:54 ` Thomas Schlichter
2009-10-21 11:57 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-22 14:41 Thomas Schlichter
2009-10-22 14:27 Thomas Schlichter
2009-10-22 12:08 Thomas Schlichter
2009-10-22 12:14 ` H. Peter Anvin
2009-10-22 13:26 ` Suresh Siddha
2009-10-22 13:35 ` Suresh Siddha
2009-10-21 14:38 Thomas Schlichter
2009-10-21 15:14 ` Jan Beulich
2009-10-21 13:45 Thomas Schlichter
2009-10-21 14:11 ` Jan Beulich
2009-10-21 17:35 ` Ingo Molnar
2009-10-21 20:01 ` Thomas Schlichter
2009-10-22 9:53 ` Suresh Siddha
2009-10-22 15:34 ` Eric Anholt
2009-10-22 21:47 ` Suresh Siddha
2009-10-22 23:10 ` Jesse Barnes
2009-10-23 0:11 ` Suresh Siddha
2009-10-23 1:53 ` Eric Anholt
2009-10-23 4:31 ` Jesse Barnes
2009-10-23 4:58 ` Suresh Siddha
2009-10-23 7:24 ` Thomas Schlichter
2009-10-23 14:24 ` Suresh Siddha
2009-10-23 14:37 ` Ingo Molnar
2009-10-23 4:33 ` Suresh Siddha
2009-10-19 15:10 Thomas Schlichter
2009-10-19 15:28 ` Ingo Molnar
2009-10-19 15:07 Thomas Schlichter
2009-10-19 14:59 Thomas Schlichter
2009-10-19 15:31 ` Ingo Molnar
2009-10-19 21:49 ` Suresh Siddha
2009-10-20 20:35 ` Thomas Schlichter
2009-10-20 21:59 ` Suresh Siddha
2009-10-21 11:52 ` Ingo Molnar
2009-10-13 7:34 Jan Beulich
2009-10-13 21:29 ` Thomas Schlichter
2009-10-14 8:13 ` Jan Beulich
2009-10-14 19:14 ` Thomas Schlichter
2009-10-15 7:48 ` Jan Beulich
2009-10-17 19:48 ` Thomas Schlichter
2009-10-19 9:16 ` Jan Beulich
2009-10-19 13:44 ` Suresh Siddha
2009-10-19 13:54 ` Ingo Molnar
2009-10-19 13:36 ` Konrad Rzeszutek Wilk
[not found] <200910122032.52168.thomas.schlichter@web.de>
2009-10-12 19:16 ` Thomas Hellstrom
2009-10-12 19:45 ` Thomas Schlichter
[not found] ` <1255378684.2063.5.camel@gaiman.anholt.net>
2009-10-13 21:05 ` Thomas Schlichter
2009-10-10 1:22 Thomas Schlichter
2009-10-10 4:24 ` Arjan van de Ven
2009-10-10 8:31 ` Thomas Schlichter
2009-10-10 15:45 ` Arjan van de Ven
2009-10-10 17:50 ` Roland Dreier
2009-10-11 7:40 ` Ingo Molnar
2009-10-11 9:56 ` Thomas Schlichter
2009-10-11 18:51 ` Henrique de Moraes Holschuh
2009-10-11 18:54 ` Arjan van de Ven
2009-10-11 20:19 ` Henrique de Moraes Holschuh
2009-10-12 18:09 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091021115734.GG16586@elte.hu \
--to=mingo@elte.hu \
--cc=JBeulich@novell.com \
--cc=arjan@linux.intel.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=hancockrwd@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=thellstrom@vmware.com \
--cc=thomas.schlichter@web.de \
--cc=tj@kernel.org \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.