Re: [Resend PATCH 1/2] twl4030: Do not dereference null pointer in error path

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Ilkka,

On Tue, Oct 20, 2009 at 04:22:52PM +0300, Ilkka Koskinen wrote:
> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Patch applied to my for-linus and for-next branches.
I'll try to get that one merged for 2.6.32.

Cheers,
Samuel.


> ---
>  drivers/mfd/twl4030-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index e424cf6..8cf0a02 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -792,7 +792,7 @@ twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  			twl->client = i2c_new_dummy(client->adapter,
>  					twl->address);
>  			if (!twl->client) {
> -				dev_err(&twl->client->dev,
> +				dev_err(&client->dev,
>  					"can't attach client %d\n", i);
>  				status = -ENOMEM;
>  				goto fail;
> -- 
> 1.6.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/