From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: tony@atomide.com, alsa-devel@alsa-project.org,
linux-omap@vger.kernel.org, sameo@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4 v2] ASoC: TWL4030: Driver registration via twl4030_codec MFD
Date: Thu, 22 Oct 2009 17:56:44 +0100 [thread overview]
Message-ID: <20091022165643.GA28051@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1256207208-25010-5-git-send-email-peter.ujfalusi@nokia.com>
On Thu, Oct 22, 2009 at 01:26:48PM +0300, Peter Ujfalusi wrote:
> Change the way how the twl4030 soc codec driver is
> loaded/probed.
> Use the device probing via tlw4030_codec MFD device.
I'm OK with the series but:
> @@ -147,6 +147,7 @@ config SND_SOC_TLV320DAC33
> tristate
>
> config SND_SOC_TWL4030
> + select TWL4030_CODEC
> tristate
due to Kconfig ignoring dependencies all the individual machine drivers
are going to need to select this, and SND_SOC_ALL_CODECS will need to
select it if the MFD core is enabled. I should be able to fix this up
myself so no need to repost for that alone.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
sameo@linux.intel.com, linux-kernel@vger.kernel.org,
tony@atomide.com
Subject: Re: [PATCH 4/4 v2] ASoC: TWL4030: Driver registration via twl4030_codec MFD
Date: Thu, 22 Oct 2009 17:56:44 +0100 [thread overview]
Message-ID: <20091022165643.GA28051@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1256207208-25010-5-git-send-email-peter.ujfalusi@nokia.com>
On Thu, Oct 22, 2009 at 01:26:48PM +0300, Peter Ujfalusi wrote:
> Change the way how the twl4030 soc codec driver is
> loaded/probed.
> Use the device probing via tlw4030_codec MFD device.
I'm OK with the series but:
> @@ -147,6 +147,7 @@ config SND_SOC_TLV320DAC33
> tristate
>
> config SND_SOC_TWL4030
> + select TWL4030_CODEC
> tristate
due to Kconfig ignoring dependencies all the individual machine drivers
are going to need to select this, and SND_SOC_ALL_CODECS will need to
select it if the MFD core is enabled. I should be able to fix this up
myself so no need to repost for that alone.
next prev parent reply other threads:[~2009-10-22 16:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 10:26 [PATCH 0/4 v2] MFD/OMAP/ASoC: MFD device for twl4030 codec submodule Peter Ujfalusi
2009-10-22 10:26 ` Peter Ujfalusi
2009-10-22 10:26 ` [PATCH 1/4 v2] MFD: twl4030: add twl4030_codec MFD as a new child to the core Peter Ujfalusi
2009-10-22 10:26 ` Peter Ujfalusi
2009-10-22 10:26 ` [PATCH 2/4 v2] OMAP: Platform support for twl4030_codec MFD Peter Ujfalusi
2009-10-22 10:26 ` Peter Ujfalusi
2009-10-22 10:26 ` [PATCH 3/4 v2] ASoC: TWL4030: use the twl4030-codec.h for register descriptions Peter Ujfalusi
2009-10-22 10:26 ` Peter Ujfalusi
2009-10-22 10:26 ` [PATCH 4/4 v2] ASoC: TWL4030: Driver registration via twl4030_codec MFD Peter Ujfalusi
2009-10-22 16:56 ` Mark Brown [this message]
2009-10-22 16:56 ` Mark Brown
2009-10-23 5:27 ` Peter Ujfalusi
2009-10-23 5:27 ` Peter Ujfalusi
2009-10-23 12:59 ` Mark Brown
2009-10-23 12:59 ` [alsa-devel] " Mark Brown
2009-10-23 14:07 ` [PATCH 1/4 v2] MFD: twl4030: add twl4030_codec MFD as a new child to the core Samuel Ortiz
2009-10-25 17:18 ` Mark Brown
2009-10-25 17:18 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022165643.GA28051@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.