* [PATCH] mmci-omap: free irq resource
@ 2009-10-21 12:43 Ladislav.Michl
2009-10-22 21:58 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Ladislav.Michl @ 2009-10-21 12:43 UTC (permalink / raw)
To: linux-omap
Free IRQ on remove.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 5d773b8..5f970e2 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev)
host->pdata->cleanup(&pdev->dev);
mmc_omap_fclk_enable(host, 0);
+ free_irq(host->irq, host);
clk_put(host->fclk);
clk_disable(host->iclk);
clk_put(host->iclk);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmci-omap: free irq resource
2009-10-21 12:43 [PATCH] mmci-omap: free irq resource Ladislav.Michl
@ 2009-10-22 21:58 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2009-10-22 21:58 UTC (permalink / raw)
To: Ladislav Michl; +Cc: linux-omap
* Ladislav.Michl@seznam.cz <Ladislav.Michl@seznam.cz> [091021 03:43]:
> Free IRQ on remove.
Looks like the MAINTAINERS file is a bit out of date for
drivers/mmc/host/omap.c..
Can you please resend this fix to Andrew Morton, and Cc
Jarkko Lavinen <jarkko.lavinen@nokia.com>,
linux-mmc@vger.kernel.org and linux-omap@vger.kernel.org?
We should be able to get this in as a fix during the -rc
cycle.
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index 5d773b8..5f970e2 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev)
> host->pdata->cleanup(&pdev->dev);
>
> mmc_omap_fclk_enable(host, 0);
> + free_irq(host->irq, host);
> clk_put(host->fclk);
> clk_disable(host->iclk);
> clk_put(host->iclk);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mmci-omap: free irq resource
@ 2009-11-01 11:56 Ladislav.Michl
0 siblings, 0 replies; 6+ messages in thread
From: Ladislav.Michl @ 2009-11-01 11:56 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jarkko Lavinen, linux-mmc
Free IRQ on remove.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 5d773b8..5f970e2 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev)
host->pdata->cleanup(&pdev->dev);
mmc_omap_fclk_enable(host, 0);
+ free_irq(host->irq, host);
clk_put(host->fclk);
clk_disable(host->iclk);
clk_put(host->iclk);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mmci-omap: free irq resource
@ 2009-11-01 11:59 Ladislav.Michl
2009-11-09 22:27 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Ladislav.Michl @ 2009-11-01 11:59 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jarkko Lavinen, linux-mmc
Free IRQ on remove.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Acked-by: Tony Lindgren <tony@atomide.com>
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 5d773b8..5f970e2 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev)
host->pdata->cleanup(&pdev->dev);
mmc_omap_fclk_enable(host, 0);
+ free_irq(host->irq, host);
clk_put(host->fclk);
clk_disable(host->iclk);
clk_put(host->iclk);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmci-omap: free irq resource
2009-11-01 11:59 Ladislav.Michl
@ 2009-11-09 22:27 ` Andrew Morton
2009-11-18 19:05 ` Ladislav Michl
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2009-11-09 22:27 UTC (permalink / raw)
To: Ladislav Michl; +Cc: Ladislav.Michl, Jarkko Lavinen, linux-mmc
On Sun, 1 Nov 2009 12:59:05 +0100
Ladislav.Michl@seznam.cz wrote:
> Free IRQ on remove.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> Acked-by: Tony Lindgren <tony@atomide.com>
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index 5d773b8..5f970e2 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev)
> host->pdata->cleanup(&pdev->dev);
>
> mmc_omap_fclk_enable(host, 0);
> + free_irq(host->irq, host);
> clk_put(host->fclk);
> clk_disable(host->iclk);
> clk_put(host->iclk);
This is a poor changelog.
The reader doesn't know what the implication of the bug is. I _assume_
that it means that the driver can only be loaded a single time. That
on a second modprobe, it fails to allocate the interrupt and fails.
In which case this is a fairly serious bug and perhaps the patch should
be backported into the -stable tree.
Or I could be all wrong about all of that. This is why it's better if
the patch submitter *explains* these things, rather than leaving others
to guess.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmci-omap: free irq resource
2009-11-09 22:27 ` Andrew Morton
@ 2009-11-18 19:05 ` Ladislav Michl
0 siblings, 0 replies; 6+ messages in thread
From: Ladislav Michl @ 2009-11-18 19:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jarkko Lavinen, linux-mmc
On Mon, Nov 09, 2009 at 02:27:49PM -0800, Andrew Morton wrote:
> On Sun, 1 Nov 2009 12:59:05 +0100
> Ladislav.Michl@seznam.cz wrote:
>
> > Free IRQ on remove.
> >
> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > Acked-by: Tony Lindgren <tony@atomide.com>
> >
> > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> > index 5d773b8..5f970e2 100644
> > --- a/drivers/mmc/host/omap.c
> > +++ b/drivers/mmc/host/omap.c
> > @@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev)
> > host->pdata->cleanup(&pdev->dev);
> >
> > mmc_omap_fclk_enable(host, 0);
> > + free_irq(host->irq, host);
> > clk_put(host->fclk);
> > clk_disable(host->iclk);
> > clk_put(host->iclk);
>
> This is a poor changelog.
I'm sorry for that as well as for sending this patch twice. I will do better
next time.
> The reader doesn't know what the implication of the bug is. I _assume_
> that it means that the driver can only be loaded a single time. That
> on a second modprobe, it fails to allocate the interrupt and fails.
This is perfectly correct assumption.
> In which case this is a fairly serious bug and perhaps the patch should
> be backported into the -stable tree.
There is no point backporting it as this driver is broken for ages without
single complain.
(details here: http://article.gmane.org/gmane.linux.kernel.mmc/649)
> Or I could be all wrong about all of that. This is why it's better if
> the patch submitter *explains* these things, rather than leaving others
> to guess.
Best regards,
ladis
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-11-18 18:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-21 12:43 [PATCH] mmci-omap: free irq resource Ladislav.Michl
2009-10-22 21:58 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2009-11-01 11:56 Ladislav.Michl
2009-11-01 11:59 Ladislav.Michl
2009-11-09 22:27 ` Andrew Morton
2009-11-18 19:05 ` Ladislav Michl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.