Re: [Qemu-devel] [Patch] Make usermode stacksize (-s) configurable at compile-time

["Jan-Simon Möller" <dl9pf@gmx.de>]

Am Sonntag 25 Oktober 2009 16:54:16 schrieb Laurent Desnogues:
> Wouldn't it be better to set this earlier only if target_user_only
> is set to yes and use cflags?
> 
> Something like this:
> 
> if test "$target_user_only" = "yes" -a "$user_mode_stacksize" != ""; then
>   cflags="-DUSER_MODE_STACKSIZE $cflags"
> fi
> 
> just after the test for pie (line 2478) for instance.
Done. 
> The informative echo should go with the others (line 1853).
Its not clear at this stage, if its "default" or the cmdline value, 
as $target_user_only isn't evaluated until line 2171 .

I'd leave therefore the echo in line 2491.
> 
>
> I'd prefer:
> 
> #ifndef USER_MODE_STACKSIZE
> #define x86_stack_size (512 * 1024)
> #endif
> unsigned long x86_stack_size = USER_MODE_STACKSIZE;
> 
You mean probably?
#ifndef USER_MODE_STACKSIZE
#define USER_MODE_STACKSIZE (512 * 1024)
#endif
unsigned long x86_stack_size = USER_MODE_STACKSIZE;

Done.

Patch will follow in next mail as reply.

Tnx and have phun !

Jan-Simon