* [lm-sensors] [PATCH v2 2/6] sensord: Convert CGI script to lower
@ 2009-10-26 20:56 Andre Prendel
2009-10-28 10:31 ` [lm-sensors] [PATCH v2 2/6] sensord: Convert CGI script to Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Andre Prendel @ 2009-10-26 20:56 UTC (permalink / raw)
To: lm-sensors
This patch converts HTML code in the generated CGI script to lower
case. This makes us a bit more XHTML compatible.
Changes in v2:
Make img, width, height lowercase to.
---
prog/sensord/rrd.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
Index: sensors/prog/sensord/rrd.c
=================================--- sensors.orig/prog/sensord/rrd.c 2009-10-26 21:33:40.000000000 +0100
+++ sensors/prog/sensord/rrd.c 2009-10-26 21:34:00.000000000 +0100
@@ -449,16 +449,16 @@
{
int ret = 0, i;
- printf("#!" RRDCGI "\n\n<HTML>\n"
- "<HEAD>\n<TITLE>sensord</TITLE>\n</HEAD>\n"
- "<BODY>\n<H1>sensord</H1>\n");
+ printf("#!" RRDCGI "\n\n<html>\n"
+ "<head>\n<title>sensord</title>\n</head>\n"
+ "<body>\n<h1>sensord</h1>\n");
for (i = 0; i < ARRAY_SIZE(graphs); i++) {
struct gr *graph = &graphs[i];
- printf("<H2>%s</H2>\n", graph->h2);
- printf("<P>\n<RRD::GRAPH %s/%s.png\n\t--imginfo '"
- "<IMG SRC=" WWWDIR "/%%s WIDTH=%%lu HEIGHT=%%lu>'"
+ printf("<h2>%s</h2>\n", graph->h2);
+ printf("<p>\n<RRD::GRAPH %s/%s.png\n\t--imginfo '"
+ "<img src=" WWWDIR "/%%s width=%%lu heigt=%%lu>'"
"\n\t-a PNG\n\t-h 200 -w 800\n",
sensord_args.cgiDir, graph->image);
@@ -473,7 +473,7 @@
ret = applyToFeatures(rrdCGI_LINE, graph);
if (!ret && sensord_args.doLoad && graph->loadAvg)
ret = rrdCGI_LINE(graph, LOADAVG, LOAD_AVERAGE, NULL);
- printf (">\n</P>\n");
+ printf (">\n</p>\n");
}
printf("<p>\n<small><b>sensord</b> by "
"<a href=\"mailto:merlin@merlin.org\">Merlin Hughes</a>"
@@ -481,7 +481,7 @@
"<a href=\"http://www.lm-sensors.org/\">lm_sensors</a> "
"crew.</small>\n</p>\n");
- printf("</BODY>\n</HTML>\n");
+ printf("</body>\n</html>\n");
return ret;
}
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [lm-sensors] [PATCH v2 2/6] sensord: Convert CGI script to
2009-10-26 20:56 [lm-sensors] [PATCH v2 2/6] sensord: Convert CGI script to lower Andre Prendel
@ 2009-10-28 10:31 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2009-10-28 10:31 UTC (permalink / raw)
To: lm-sensors
On Mon, 26 Oct 2009 21:56:47 +0100, Andre Prendel wrote:
> This patch converts HTML code in the generated CGI script to lower
> case. This makes us a bit more XHTML compatible.
>
> Changes in v2:
>
> Make img, width, height lowercase to.
> ---
>
> prog/sensord/rrd.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> Index: sensors/prog/sensord/rrd.c
> =================================> --- sensors.orig/prog/sensord/rrd.c 2009-10-26 21:33:40.000000000 +0100
> +++ sensors/prog/sensord/rrd.c 2009-10-26 21:34:00.000000000 +0100
> @@ -449,16 +449,16 @@
> (...)
> - printf("<H2>%s</H2>\n", graph->h2);
> - printf("<P>\n<RRD::GRAPH %s/%s.png\n\t--imginfo '"
> - "<IMG SRC=" WWWDIR "/%%s WIDTH=%%lu HEIGHT=%%lu>'"
> + printf("<h2>%s</h2>\n", graph->h2);
> + printf("<p>\n<RRD::GRAPH %s/%s.png\n\t--imginfo '"
> + "<img src=" WWWDIR "/%%s width=%%lu heigt=%%lu>'"
Typo here: heigt -> height.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-28 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-26 20:56 [lm-sensors] [PATCH v2 2/6] sensord: Convert CGI script to lower Andre Prendel
2009-10-28 10:31 ` [lm-sensors] [PATCH v2 2/6] sensord: Convert CGI script to Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.