From: Luis R. Rodriguez <lrodriguez@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH v2 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print
Date: Mon, 26 Oct 2009 14:32:22 -0700 [thread overview]
Message-ID: <20091026213222.GA3956@tux> (raw)
In-Reply-To: <878wexhn6m.fsf@purkki.valot.fi>
On Mon, Oct 26, 2009 at 02:15:13PM -0700, Kalle Valo wrote:
> "Luis R. Rodriguez" <lrodriguez@Atheros.com> writes:
>
> >> I think you should provide the size of hw_name to this function and
> >> use snprintf() to avoid writing out of bounds.
> >
> > I was going to do this but since I know the users of it and control
> > it seemed to not matter. I'll respin with this added, better to be careful.
>
> Yeah, you never know if someone (for example a crazy Finn just after a
> refreshing sauna) comes along, changes the function a bit "to clean it
> up" and creates a subtle bug ;)
Ah yes, forgot about the crazy sauna fins, must fix now for sure.
Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH v2 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print
Date: Mon, 26 Oct 2009 14:32:22 -0700 [thread overview]
Message-ID: <20091026213222.GA3956@tux> (raw)
In-Reply-To: <878wexhn6m.fsf@purkki.valot.fi>
On Mon, Oct 26, 2009 at 02:15:13PM -0700, Kalle Valo wrote:
> "Luis R. Rodriguez" <lrodriguez@Atheros.com> writes:
>
> >> I think you should provide the size of hw_name to this function and
> >> use snprintf() to avoid writing out of bounds.
> >
> > I was going to do this but since I know the users of it and control
> > it seemed to not matter. I'll respin with this added, better to be careful.
>
> Yeah, you never know if someone (for example a crazy Finn just after a
> refreshing sauna) comes along, changes the function a bit "to clean it
> up" and creates a subtle bug ;)
Ah yes, forgot about the crazy sauna fins, must fix now for sure.
Luis
next prev parent reply other threads:[~2009-10-26 21:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 16:44 [ath9k-devel] [PATCH v2 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print Luis R. Rodriguez
2009-10-26 16:44 ` Luis R. Rodriguez
2009-10-26 20:31 ` [ath9k-devel] " Kalle Valo
2009-10-26 20:31 ` Kalle Valo
2009-10-26 20:44 ` [ath9k-devel] " Luis R. Rodriguez
2009-10-26 20:44 ` Luis R. Rodriguez
2009-10-26 21:15 ` [ath9k-devel] " Kalle Valo
2009-10-26 21:15 ` Kalle Valo
2009-10-26 21:32 ` Luis R. Rodriguez [this message]
2009-10-26 21:32 ` Luis R. Rodriguez
2009-10-27 16:56 ` [ath9k-devel] " Luis R. Rodriguez
2009-10-27 16:56 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026213222.GA3956@tux \
--to=lrodriguez@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.