All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>, Jiri Kosina <jkosina@suse.cz>,
	Sven Geggus <lists@fuchsschwanzdomain.de>,
	Karol Lewandowski <karol.k.lewandowski@gmail.com>,
	Tobias Oetiker <tobi@oetiker.ch>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	David Miller <davem@davemloft.net>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Kalle Valo <kalle.valo@iki.fi>,
	David Rientjes <rientjes@google.com>,
	Mohamed Abbas <mohamed.abbas@intel.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Stephan von Krawczynski <skraw@ithnet.com>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING Revert 373c0a7e, 8aa7e847: Fix congestion_wait() sync/async vs read/write confusion
Date: Tue, 27 Oct 2009 11:29:01 +0100	[thread overview]
Message-ID: <200910271129.05586.elendil@planet.nl> (raw)
In-Reply-To: <20091026235628.2F7B.A69D9226@jp.fujitsu.com>

On Tuesday 27 October 2009, KOSAKI Motohiro wrote:
> Oops. no, please no.
> 8aa7e847 is regression fixing commit. this revert indicate the
> regression occur again.
> if we really need to revert it, we need to revert 1faa16d2287 too.
> however, I doubt this commit really cause regression to iwlan. IOW,
> I agree Jens.

This is not intended as a patch for mainline, but just as a test to see if 
it improves things. It may be a regression fix, but it also creates a 
significant change in behavior during swapping in my test case.
If a fix is needed, it will probably by different from this revert.
Please read: http://lkml.org/lkml/2009/10/26/510.

This mail has some data: http://lkml.org/lkml/2009/10/26/455.

> I hope to try reproduce this problem on my test environment. Can anyone
> please explain reproduce way?

Please see my mails in this thread for bug #14141: 
http://thread.gmane.org/gmane.linux.kernel/896714

You will probably need to read some of them to understand the context of 
the two mails linked above.

The most relevant ones are (all from the same thread; not sure why gmane 
gives such weird links):
http://article.gmane.org/gmane.linux.kernel.mm/39909
http://article.gmane.org/gmane.linux.kernel.kernel-testers/7228
http://article.gmane.org/gmane.linux.kernel.kernel-testers/7165

> Is special hardware necessary?

Not special hardware, but you may need an encrypted partition and NFS; the 
test may need to be modified according to the amount of memory you have.
I think it should be possible to reproduce the freezes I see while ignoring 
the SKB allocation errors as IMO those are just a symptom, not the cause.
So you should not need wireless.

The severity of the freezes during my test often increases if the test is 
repeated (without rebooting).

Cheers,
FJP

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Frans Pop <elendil@planet.nl>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>, Jiri Kosina <jkosina@suse.cz>,
	Sven Geggus <lists@fuchsschwanzdomain.de>,
	Karol Lewandowski <karol.k.lewandowski@gmail.com>,
	Tobias Oetiker <tobi@oetiker.ch>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	David Miller <davem@davemloft.net>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Kalle Valo <kalle.valo@iki.fi>,
	David Rientjes <rientjes@google.com>,
	Mohamed Abbas <mohamed.abbas@intel.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Stephan von Krawczynski <skraw@ithnet.com>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING Revert 373c0a7e, 8aa7e847: Fix congestion_wait() sync/async vs read/write confusion
Date: Tue, 27 Oct 2009 11:29:01 +0100	[thread overview]
Message-ID: <200910271129.05586.elendil@planet.nl> (raw)
In-Reply-To: <20091026235628.2F7B.A69D9226@jp.fujitsu.com>

On Tuesday 27 October 2009, KOSAKI Motohiro wrote:
> Oops. no, please no.
> 8aa7e847 is regression fixing commit. this revert indicate the
> regression occur again.
> if we really need to revert it, we need to revert 1faa16d2287 too.
> however, I doubt this commit really cause regression to iwlan. IOW,
> I agree Jens.

This is not intended as a patch for mainline, but just as a test to see if 
it improves things. It may be a regression fix, but it also creates a 
significant change in behavior during swapping in my test case.
If a fix is needed, it will probably by different from this revert.
Please read: http://lkml.org/lkml/2009/10/26/510.

This mail has some data: http://lkml.org/lkml/2009/10/26/455.

> I hope to try reproduce this problem on my test environment. Can anyone
> please explain reproduce way?

Please see my mails in this thread for bug #14141: 
http://thread.gmane.org/gmane.linux.kernel/896714

You will probably need to read some of them to understand the context of 
the two mails linked above.

The most relevant ones are (all from the same thread; not sure why gmane 
gives such weird links):
http://article.gmane.org/gmane.linux.kernel.mm/39909
http://article.gmane.org/gmane.linux.kernel.kernel-testers/7228
http://article.gmane.org/gmane.linux.kernel.kernel-testers/7165

> Is special hardware necessary?

Not special hardware, but you may need an encrypted partition and NFS; the 
test may need to be modified according to the amount of memory you have.
I think it should be possible to reproduce the freezes I see while ignoring 
the SKB allocation errors as IMO those are just a symptom, not the cause.
So you should not need wireless.

The severity of the freezes during my test often increases if the test is 
repeated (without rebooting).

Cheers,
FJP

  reply	other threads:[~2009-10-27 10:29 UTC|newest]

Thread overview: 171+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22 14:22 [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 Mel Gorman
2009-10-22 14:22 ` Mel Gorman
     [not found] ` <1256221356-26049-1-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-22 14:22   ` [PATCH 1/5] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed Mel Gorman
2009-10-22 14:22     ` Mel Gorman
2009-10-22 14:22     ` Mel Gorman
2009-10-22 14:24     ` [PATCH 1/5 Against 2.6.31.4] " Mel Gorman
2009-10-22 14:24       ` Mel Gorman
2009-10-22 14:41     ` [PATCH 1/5] " Pekka Enberg
2009-10-22 14:41       ` Pekka Enberg
2009-10-22 14:41       ` Pekka Enberg
2009-10-22 15:49       ` Mel Gorman
2009-10-22 15:49         ` Mel Gorman
     [not found]     ` <1256221356-26049-2-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-26  1:11       ` KOSAKI Motohiro
2009-10-26  1:11         ` KOSAKI Motohiro
2009-10-26  1:11         ` KOSAKI Motohiro
2009-10-26  7:10         ` David Rientjes
2009-10-26  7:10           ` David Rientjes
2009-10-26  7:10           ` David Rientjes
2009-10-26  7:10           ` David Rientjes
2009-10-27  2:42           ` KOSAKI Motohiro
2009-10-27  2:42             ` KOSAKI Motohiro
2009-10-27  2:42             ` KOSAKI Motohiro
2009-10-27 12:27             ` Mel Gorman
2009-10-27 12:27               ` Mel Gorman
2009-10-22 14:22   ` [PATCH 2/5] page allocator: Do not allow interrupts to use ALLOC_HARDER Mel Gorman
2009-10-22 14:22     ` Mel Gorman
2009-10-22 14:22     ` Mel Gorman
2009-10-22 16:33     ` Stephan von Krawczynski
2009-10-22 16:33       ` Stephan von Krawczynski
     [not found]       ` <20091022183303.2448942d.skraw-DcQCyzbjH0jQT0dZR+AlfA@public.gmane.org>
2009-10-22 16:37         ` Mel Gorman
2009-10-22 16:37           ` Mel Gorman
2009-10-22 16:37           ` Mel Gorman
     [not found]           ` <20091022163752.GU11778-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-23  9:57             ` Stephan von Krawczynski
2009-10-23  9:57               ` Stephan von Krawczynski
2009-10-23  9:57               ` Stephan von Krawczynski
2009-10-24  2:03           ` Christoph Lameter
2009-10-24  2:03             ` Christoph Lameter
2009-10-24  2:03             ` Christoph Lameter
2009-10-27 15:19             ` Mel Gorman
2009-10-27 15:19               ` Mel Gorman
2009-10-27 15:19               ` Mel Gorman
2009-10-25 12:57           ` Stephan von Krawczynski
2009-10-25 12:57             ` Stephan von Krawczynski
2009-10-26  1:15     ` KOSAKI Motohiro
2009-10-26  1:15       ` KOSAKI Motohiro
2009-10-26  1:15       ` KOSAKI Motohiro
2009-10-24 13:51   ` [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 Frans Pop
2009-10-24 13:51     ` Frans Pop
2009-10-24 13:51     ` Frans Pop
2009-10-26 17:37   ` Tobias Oetiker
2009-10-26 17:37     ` Tobias Oetiker
2009-10-26 17:37     ` Tobias Oetiker
2009-10-27 15:36     ` Mel Gorman
2009-10-27 15:36       ` Mel Gorman
2009-10-22 14:22 ` [PATCH 3/5] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit Mel Gorman
2009-10-22 14:22   ` Mel Gorman
2009-10-23 17:52   ` Vincent Li
2009-10-23 22:12     ` Vincent Li
2009-10-27 10:38     ` Mel Gorman
2009-10-27  2:42   ` KOSAKI Motohiro
2009-10-27  2:42     ` KOSAKI Motohiro
2009-10-27  2:42     ` KOSAKI Motohiro
2009-10-22 14:22 ` [PATCH 4/5] page allocator: Pre-emptively wake kswapd when high-order watermarks are hit Mel Gorman
2009-10-22 14:22   ` Mel Gorman
     [not found]   ` <1256221356-26049-5-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-22 19:41     ` David Rientjes
2009-10-22 19:41       ` David Rientjes
2009-10-22 19:41       ` David Rientjes
     [not found]       ` <alpine.DEB.2.00.0910221227010.21601-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2009-10-23  9:13         ` Mel Gorman
2009-10-23  9:13           ` Mel Gorman
2009-10-23  9:13           ` Mel Gorman
2009-10-23  9:36           ` David Rientjes
2009-10-23  9:36             ` David Rientjes
2009-10-23  9:36             ` David Rientjes
     [not found]             ` <alpine.DEB.2.00.0910230229010.28109-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2009-10-23 11:25               ` Mel Gorman
2009-10-23 11:25                 ` Mel Gorman
2009-10-23 11:25                 ` Mel Gorman
2009-10-23 11:31                 ` Tobias Oetiker
2009-10-23 11:31                   ` Tobias Oetiker
2009-10-23 11:31                   ` Tobias Oetiker
2009-10-23 11:31                   ` Tobias Oetiker
     [not found]                   ` <alpine.DEB.2.00.0910231329550.26462-EjsAmf5DE5zIvOfxy3zmAzgUDZmNtoG9@public.gmane.org>
2009-10-23 13:39                     ` Mel Gorman
2009-10-23 13:39                       ` Mel Gorman
2009-10-23 13:39                       ` Mel Gorman
2009-10-27  2:42   ` KOSAKI Motohiro
2009-10-27  2:42     ` KOSAKI Motohiro
2009-10-27  2:42     ` KOSAKI Motohiro
     [not found]     ` <20091026235032.2F78.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-10-27 15:26       ` Mel Gorman
2009-10-27 15:26         ` Mel Gorman
2009-10-27 15:26         ` Mel Gorman
2009-10-22 14:22 ` [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING Revert 373c0a7e, 8aa7e847: Fix congestion_wait() sync/async vs read/write confusion Mel Gorman
2009-10-22 14:22   ` Mel Gorman
2009-10-22 14:25   ` Against 2.6.31.4 [PATCH 5/5] " Mel Gorman
2009-10-22 14:25     ` Mel Gorman
2009-10-22 21:49   ` [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING " Jens Axboe
2009-10-22 21:49     ` Jens Axboe
2009-10-27  2:42   ` KOSAKI Motohiro
2009-10-27  2:42     ` KOSAKI Motohiro
2009-10-27  2:42     ` KOSAKI Motohiro
2009-10-27 10:29     ` Frans Pop [this message]
2009-10-27 10:29       ` Frans Pop
2009-10-22 14:47 ` [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 Pekka Enberg
2009-10-22 14:47   ` Pekka Enberg
2009-10-22 14:47   ` Pekka Enberg
2009-10-22 14:47   ` Pekka Enberg
     [not found]   ` <84144f020910220747nba30d8bkc83c2569da79bd7c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-22 16:03     ` Mel Gorman
2009-10-22 16:03       ` Mel Gorman
2009-10-22 16:03       ` Mel Gorman
2009-10-24  1:52   ` Christoph Lameter
2009-10-24  1:52     ` Christoph Lameter
2009-10-24  1:52     ` Christoph Lameter
2009-10-24  1:52     ` Christoph Lameter
2009-10-24  6:48     ` Pekka Enberg
2009-10-24  6:48       ` Pekka Enberg
2009-10-24  6:48       ` Pekka Enberg
2009-10-24  6:48       ` Pekka Enberg
2009-10-24  6:48     ` Pekka Enberg
2009-10-22 15:43 ` reinette chatre
2009-10-22 15:43   ` reinette chatre
2009-10-22 15:43   ` reinette chatre
2009-10-27 10:40   ` Mel Gorman
2009-10-27 10:40     ` Mel Gorman
2009-10-27 10:40     ` Mel Gorman
2009-10-27 10:40     ` Mel Gorman
2009-10-27 23:34     ` reinette chatre
2009-10-27 23:34       ` reinette chatre
2009-10-27 23:34       ` reinette chatre
2009-10-23  7:31 ` Sven Geggus
2009-10-23  7:31   ` Sven Geggus
2009-10-23 16:58 ` Karol Lewandowski
2009-10-23 16:58   ` Karol Lewandowski
2009-10-23 21:12   ` Karol Lewandowski
2009-10-23 21:12     ` Karol Lewandowski
2009-10-24 13:46     ` Mel LKML
2009-10-24 13:46       ` Mel LKML
2009-10-24 13:46       ` Mel LKML
     [not found]       ` <9ec2d7290910240646p75b93c68v6ea1648d628a9660-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-28 11:42         ` Karol Lewandowski
2009-10-28 11:42           ` Karol Lewandowski
2009-10-28 11:42           ` Karol Lewandowski
2009-10-28 11:42           ` Karol Lewandowski
     [not found]           ` <20091028114208.GA14476-nLtalAL5mPp2RxbNQum0x1nzlInOXLuq@public.gmane.org>
2009-10-28 11:59             ` Mel Gorman
2009-10-28 11:59               ` Mel Gorman
2009-10-28 11:59               ` Mel Gorman
     [not found]               ` <20091028115926.GW8900-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-30 14:23                 ` Karol Lewandowski
2009-10-30 14:23                   ` Karol Lewandowski
2009-10-30 14:23                   ` Karol Lewandowski
     [not found]                   ` <20091030142350.GA9343-nLtalAL5mPp2RxbNQum0x1nzlInOXLuq@public.gmane.org>
2009-11-02 20:30                     ` Mel Gorman
2009-11-02 20:30                       ` Mel Gorman
2009-11-02 20:30                       ` Mel Gorman
     [not found]                       ` <20091102203034.GC22046-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-04  2:03                         ` Karol Lewandowski
2009-11-04  2:03                           ` Karol Lewandowski
2009-11-04  2:03                           ` Karol Lewandowski
2009-10-28 12:55             ` Tobi Oetiker
2009-10-28 12:55               ` Tobi Oetiker
2009-10-28 12:55               ` Tobi Oetiker
2009-10-24 14:02 ` Sven Geggus
2009-10-24 14:02   ` Sven Geggus
2009-10-27 13:27   ` Mel Gorman
2009-10-27 13:27     ` Mel Gorman
2009-10-26 22:17 ` Frans Pop
2009-10-26 22:17   ` Frans Pop
2009-10-26 23:45   ` Frans Pop
2009-10-26 23:45     ` Frans Pop
2009-11-06  6:03 ` Tobias Diedrich
2009-11-06  6:03   ` Tobias Diedrich
     [not found]   ` <20091106060323.GA5528-VCkOej6z8qt4W7ppVJ7FiLNAH6kLmebB@public.gmane.org>
2009-11-06  9:24     ` Mel Gorman
2009-11-06  9:24       ` Mel Gorman
2009-11-06  9:24       ` Mel Gorman
2009-11-06 11:15       ` Tobias Diedrich
2009-11-06 11:15         ` Tobias Diedrich
2009-11-06  9:24   ` Mel Gorman
2009-11-06  9:24   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910271129.05586.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=bzolnier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=jens.axboe@oracle.com \
    --cc=jkosina@suse.cz \
    --cc=kalle.valo@iki.fi \
    --cc=karol.k.lewandowski@gmail.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linville@tuxdriver.com \
    --cc=lists@fuchsschwanzdomain.de \
    --cc=mel@csn.ul.ie \
    --cc=mohamed.abbas@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=reinette.chatre@intel.com \
    --cc=rientjes@google.com \
    --cc=rjw@sisk.pl \
    --cc=skraw@ithnet.com \
    --cc=tobi@oetiker.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.