Re: Re: [drm:r100_ring_test] *ERROR* radeon: ring test failed

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]

On Tue, Oct 27, 2009 at 05:46:51PM +0200, Pasi Kärkkäinen wrote:
> On Wed, Oct 21, 2009 at 02:31:30PM -0400, Konrad Rzeszutek Wilk wrote:
> > > I updated the pv_ops dom0 git tree to the latest 2.6.31.4 tree as of
> > > today, and also applied your ttm.patch.
> > > 
> > > Modesetting works now, and there are no drm/radeon errors.
> > 
> > Thank you for testing it.
> > 
> 
> Btw are you going to post this for inclusion in drm/ttm trees?

I am not really comfortable with it. It has the same drawbacks
as the fix for the drm_scatter, where we blindly assume
phys_to_bus(virt_to_phys(X)) will give us the same value as
what dma_alloc_coherent provides. We should save that bus address
somewhere...

Saving it somewhere (perhaps in some of the structs the drm_ttm allocates)
could do it. But we should probably differentiate between memory
that is being allocated for DMA transfers vs other things so that
we don't over-exercise the dma_alloc_coherent. Thought maybe
the memory returned via drm_tt calls are only used for DMA transfers.

We can figure this out.  Pasi, I don't have a modesetting working machine,
but you do. Can you compile your pv_ops with the fix I provided earlier,
along with enabling CONFIG_DMA_API_DEBUG=y. Once mode-setting is turned
on and your machine is humming along (maybe even run glxgears), compile
the attached module and load it. You should get a kernel dump
off all devices that are using the DMA buffers. Can you e-mail me that back
please?



[-- Attachment #2: Makefile --]
[-- Type: text/plain, Size: 758 bytes --]

# Comment/uncomment the following line to disable/enable debugging
#DEBUG = y

# Add your debugging flag (or not) to CFLAGS
ifeq ($(DEBUG),y)
  DEBFLAGS = -O -g # "-O" is needed to expand inlines
else
  DEBFLAGS = -O2
endif

EXTRA_CFLAGS += $(DEBFLAGS) -I$(LDDINCDIR)

ifneq ($(KERNELRELEASE),)
# call from kernel build system

obj-m	:= dump_dma.o

else

#KERNELDIR ?= /lib/modules/$(shell uname -r)/build
KERNELDIR ?= /home/konrad/git/nex-VI-PVOPS/linux-build
PWD       := $(shell pwd)

default:
	$(MAKE) -C $(KERNELDIR) M=$(PWD) LDDINCDIR=$(PWD)/../include modules

endif

clean:
	rm -rf *.o *~ core .depend .*.cmd *.ko *.mod.c .tmp_versions

depend .depend dep:
	$(CC) $(CFLAGS) -M *.c > .depend


ifeq (.depend,$(wildcard .depend))
include .depend
endif

[-- Attachment #3: dump_dma.c --]
[-- Type: text/plain, Size: 1851 bytes --]

/*
 *  Copyright 2009 Virtual Iron.
 *  by Konrad Rzeszutek <konrad@virtualiron.com>
 *
 * This code exposes the buffer-cache to userland via sysfs.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License v2.0 as published by
 * the Free Software Foundation
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 */

#include <linux/module.h>
#include <linux/string.h>
#include <linux/types.h>
#include <linux/init.h>
#include <linux/stat.h>
#include <linux/err.h>
#include <linux/ctype.h>
#include <linux/slab.h>
#include <linux/limits.h>
#include <linux/device.h>
#include <linux/pci.h>
#include <linux/blkdev.h>
#include <linux/device.h>

#include <linux/init.h>
#include <linux/mm.h>
#include <linux/fcntl.h>
#include <linux/slab.h>
#include <linux/kmod.h>
#include <linux/major.h>
#include <linux/smp_lock.h>
#include <linux/highmem.h>
#include <linux/blkdev.h>
#include <linux/module.h>
#include <linux/blkpg.h>
#include <linux/buffer_head.h>
#include <linux/mpage.h>
#include <linux/mount.h>
#include <linux/uio.h>
#include <linux/namei.h>
#include <asm/uaccess.h>

#include <linux/pagemap.h>
#include <linux/pagevec.h>
#include <linux/buffer_head.h>

#include <linux/dma-debug.h>
#define DUMP_DMA_VERSION  "0.1"

MODULE_AUTHOR("Konrad Rzeszutek <konrad@virtualiron>");
MODULE_DESCRIPTION("dumps DMA stats");
MODULE_LICENSE("GPL");
MODULE_VERSION(DUMP_DMA_VERSION);

static int __init dma_dump_init(void)
{
	dump_stack();
	debug_dma_dump_mappings(NULL);
	return -ENODEV;
}

static void __exit dma_dump_exit(void)
{
}

module_init(dma_dump_init);
module_exit(dma_dump_exit);

[-- Attachment #4: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel