All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation
Date: Wed, 28 Oct 2009 09:42:47 +0100	[thread overview]
Message-ID: <20091028084247.GC17601@lst.de> (raw)
In-Reply-To: <20091027152859.C6CF739742@ochil.suse.de>

On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote:
> 
> Other drives might want to use SCSI command emulation without
> going through the SCSI disk abstraction, as this imposes too
> many limits on the emulation.

Might be a good idea to move something like this first into the series
and share the CDB decoder between scsi and ide (atapi) as a start.  A
little bit of refactoring of the CDB decoder, e.g. into one function
per opcode (-family) won't hurt either.


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation
Date: Wed, 28 Oct 2009 09:42:47 +0100	[thread overview]
Message-ID: <20091028084247.GC17601@lst.de> (raw)
In-Reply-To: <20091027152859.C6CF739742@ochil.suse.de>

On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote:
> 
> Other drives might want to use SCSI command emulation without
> going through the SCSI disk abstraction, as this imposes too
> many limits on the emulation.

Might be a good idea to move something like this first into the series
and share the CDB decoder between scsi and ide (atapi) as a start.  A
little bit of refactoring of the CDB decoder, e.g. into one function
per opcode (-family) won't hurt either.

  parent reply	other threads:[~2009-10-28  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27 15:28 [PATCH 3/4] scsi-disk: Factor out SCSI command emulation Hannes Reinecke
2009-10-27 15:28 ` [Qemu-devel] " Hannes Reinecke
2009-10-28  8:42 ` Christoph Hellwig
2009-10-28  8:42 ` Christoph Hellwig [this message]
2009-10-28  8:42   ` Christoph Hellwig
2009-10-28 19:01   ` Hannes Reinecke
2009-10-28 19:01     ` Hannes Reinecke
2009-10-28 19:01   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091028084247.GC17601@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.