From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bill Gatliff <bgat@billgatliff.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Add support for CLKOUT to wm8731 codec driver
Date: Fri, 30 Oct 2009 17:00:03 +0000 [thread overview]
Message-ID: <20091030170003.GA28420@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4AEB194C.700@billgatliff.com>
On Fri, Oct 30, 2009 at 11:50:20AM -0500, Bill Gatliff wrote:
> Mark Brown wrote:
> > It'd be better define a new clock for the CLKOUT pin rather than munging
> > it in with the master clock. MCLK is always an input on the WM8731, the
> > CLKOUT output is a separate pin and so including it in MCLK is likely to
> > make things confusing and could well introduce errors.
> Could you explain more about what you meant by this? I'm trying to
> rework these patches now, and I don't understand how to implement what
> you are suggesting.
Define two clock IDs and then use a switch statement in the function to
determine which to act on, allowing the master clock to be controlled
separately to the output clock.
next prev parent reply other threads:[~2009-10-30 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 15:13 [PATCH] Add CLKOUT support to wm8731 codec driver Bill Gatliff
2009-10-29 15:13 ` [PATCH] Add support for CLKOUT " Bill Gatliff
2009-10-29 16:05 ` Mark Brown
2009-10-29 16:09 ` Bill Gatliff
2009-10-30 16:50 ` Bill Gatliff
2009-10-30 17:00 ` Mark Brown [this message]
2009-10-30 18:22 ` Bill Gatliff
2009-10-30 18:32 ` Mark Brown
2009-10-30 19:04 ` Bill Gatliff
2009-10-30 19:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030170003.GA28420@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgat@billgatliff.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.