* [RFC][PATCH 2/7] Adding general performance benchmarking subsystem to perf.
@ 2009-11-03 4:36 Hitoshi Mitake
2009-11-03 7:34 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Hitoshi Mitake @ 2009-11-03 4:36 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Rusty Russell, Thomas Gleixner, Peter Zijlstra,
Mike Galbraith, Arnaldo Carvalho de Melo,
Frédéric_Weisbecker
Adding general performance benchmarking subsystem to perf.
This patch add new file: bench-suite.h
bench-suite.h contains prototypes of benchmark suite functions.
Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
---
tools/perf/bench-suite.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
create mode 100644 tools/perf/bench-suite.h
diff --git a/tools/perf/bench-suite.h b/tools/perf/bench-suite.h
new file mode 100644
index 0000000..65f6f55
--- /dev/null
+++ b/tools/perf/bench-suite.h
@@ -0,0 +1,7 @@
+#ifndef BENCH_SUITE_H
+#define BENCH_SUITE_H
+
+extern int bench_sched_messaging(int argc, const char **argv, const char *prefix);
+extern int bench_sched_pipe(int argc, const char **argv, const char *prefix);
+
+#endif
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH 2/7] Adding general performance benchmarking subsystem to perf.
2009-11-03 4:36 [RFC][PATCH 2/7] Adding general performance benchmarking subsystem to perf Hitoshi Mitake
@ 2009-11-03 7:34 ` Ingo Molnar
2009-11-03 7:47 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-11-03 7:34 UTC (permalink / raw)
To: Hitoshi Mitake
Cc: linux-kernel, Rusty Russell, Thomas Gleixner, Peter Zijlstra,
Mike Galbraith, Arnaldo Carvalho de Melo,
Frédéric_Weisbecker
* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
>
> Adding general performance benchmarking subsystem to perf.
> This patch add new file: bench-suite.h
>
> bench-suite.h contains prototypes of benchmark suite functions.
>
> Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Mike Galbraith <efault@gmx.de>
> ---
> tools/perf/bench-suite.h | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
> create mode 100644 tools/perf/bench-suite.h
>
> diff --git a/tools/perf/bench-suite.h b/tools/perf/bench-suite.h
> new file mode 100644
> index 0000000..65f6f55
> --- /dev/null
> +++ b/tools/perf/bench-suite.h
> @@ -0,0 +1,7 @@
> +#ifndef BENCH_SUITE_H
> +#define BENCH_SUITE_H
> +
> +extern int bench_sched_messaging(int argc, const char **argv, const char *prefix);
> +extern int bench_sched_pipe(int argc, const char **argv, const char *prefix);
> +
> +#endif
Please put new headers into tools/*.h.
Also, could we name it bench.h? It's a bit shorter :)
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH 2/7] Adding general performance benchmarking subsystem to perf.
2009-11-03 7:34 ` Ingo Molnar
@ 2009-11-03 7:47 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-11-03 7:47 UTC (permalink / raw)
To: Hitoshi Mitake
Cc: linux-kernel, Rusty Russell, Thomas Gleixner, Peter Zijlstra,
Mike Galbraith, Arnaldo Carvalho de Melo,
Frédéric_Weisbecker
* Ingo Molnar <mingo@elte.hu> wrote:
>
> * Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
>
> >
> > Adding general performance benchmarking subsystem to perf.
> > This patch add new file: bench-suite.h
> >
> > bench-suite.h contains prototypes of benchmark suite functions.
> >
> > Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
> > Cc: Rusty Russell <rusty@rustcorp.com.au>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Mike Galbraith <efault@gmx.de>
> > ---
> > tools/perf/bench-suite.h | 7 +++++++
> > 1 files changed, 7 insertions(+), 0 deletions(-)
> > create mode 100644 tools/perf/bench-suite.h
> >
> > diff --git a/tools/perf/bench-suite.h b/tools/perf/bench-suite.h
> > new file mode 100644
> > index 0000000..65f6f55
> > --- /dev/null
> > +++ b/tools/perf/bench-suite.h
> > @@ -0,0 +1,7 @@
> > +#ifndef BENCH_SUITE_H
> > +#define BENCH_SUITE_H
> > +
> > +extern int bench_sched_messaging(int argc, const char **argv, const char *prefix);
> > +extern int bench_sched_pipe(int argc, const char **argv, const char *prefix);
> > +
> > +#endif
>
> Please put new headers into tools/*.h.
>
> Also, could we name it bench.h? It's a bit shorter :)
As per my later mail, maybe the better place for this header would be
tools/perf/bench/bench.h. That makes the addition of new benchmark
modules rather self-sufficient.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-03 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-03 4:36 [RFC][PATCH 2/7] Adding general performance benchmarking subsystem to perf Hitoshi Mitake
2009-11-03 7:34 ` Ingo Molnar
2009-11-03 7:47 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.