From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"hugh.dickins@tiscali.co.uk" <hugh.dickins@tiscali.co.uk>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Tejun Heo <tj@kernel.org>
Subject: Re: [MM] Remove rss batching from copy_page_range()
Date: Thu, 5 Nov 2009 09:27:35 +0100 [thread overview]
Message-ID: <20091105082735.GP31511@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0911041640340.17859@V090114053VZO-1>
On Wed, Nov 04, 2009 at 05:02:12PM -0500, Christoph Lameter wrote:
> On Wed, 4 Nov 2009, Andi Kleen wrote:
>
> > > With per cpu counters in mm there is no need for batching
> > > mm counter updates anymore. Update counters directly while
> > > copying pages.
> >
> > Hmm, but with all the inlining with some luck the local
> > counters will be in registers. That will never be the case
> > with the per cpu counters.
>
> The function is too big for that to occur and the counters have to be
If it's only called once then gcc doesn't care about size.
> preserved across function calls. The code is shorter with the patch
> applied:
I see. Thanks for the data.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"hugh.dickins@tiscali.co.uk" <hugh.dickins@tiscali.co.uk>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Tejun Heo <tj@kernel.org>
Subject: Re: [MM] Remove rss batching from copy_page_range()
Date: Thu, 5 Nov 2009 09:27:35 +0100 [thread overview]
Message-ID: <20091105082735.GP31511@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0911041640340.17859@V090114053VZO-1>
On Wed, Nov 04, 2009 at 05:02:12PM -0500, Christoph Lameter wrote:
> On Wed, 4 Nov 2009, Andi Kleen wrote:
>
> > > With per cpu counters in mm there is no need for batching
> > > mm counter updates anymore. Update counters directly while
> > > copying pages.
> >
> > Hmm, but with all the inlining with some luck the local
> > counters will be in registers. That will never be the case
> > with the per cpu counters.
>
> The function is too big for that to occur and the counters have to be
If it's only called once then gcc doesn't care about size.
> preserved across function calls. The code is shorter with the patch
> applied:
I see. Thanks for the data.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-11-05 8:27 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 19:14 [MM] Make mm counters per cpu instead of atomic Christoph Lameter
2009-11-04 19:14 ` Christoph Lameter
2009-11-04 19:17 ` [MM] Remove rss batching from copy_page_range() Christoph Lameter
2009-11-04 19:17 ` Christoph Lameter
2009-11-04 21:02 ` Andi Kleen
2009-11-04 21:02 ` Andi Kleen
2009-11-04 22:02 ` Christoph Lameter
2009-11-04 22:02 ` Christoph Lameter
2009-11-05 8:27 ` Andi Kleen [this message]
2009-11-05 8:27 ` Andi Kleen
2009-11-04 21:01 ` [MM] Make mm counters per cpu instead of atomic Andi Kleen
2009-11-04 21:01 ` Andi Kleen
2009-11-04 23:49 ` Dave Jones
2009-11-04 23:49 ` Dave Jones
2009-11-05 15:04 ` Christoph Lameter
2009-11-05 15:04 ` Christoph Lameter
2009-11-05 15:36 ` [MM] Make mm counters per cpu instead of atomic V2 Christoph Lameter
2009-11-05 15:36 ` Christoph Lameter
2009-11-06 1:11 ` KAMEZAWA Hiroyuki
2009-11-06 1:11 ` KAMEZAWA Hiroyuki
2009-11-06 3:23 ` KAMEZAWA Hiroyuki
2009-11-06 3:23 ` KAMEZAWA Hiroyuki
2009-11-06 17:32 ` Christoph Lameter
2009-11-06 17:32 ` Christoph Lameter
2009-11-06 19:03 ` KAMEZAWA Hiroyuki
2009-11-06 19:03 ` KAMEZAWA Hiroyuki
2009-11-06 19:13 ` Christoph Lameter
2009-11-06 19:13 ` Christoph Lameter
2009-11-06 19:20 ` KAMEZAWA Hiroyuki
2009-11-06 19:20 ` KAMEZAWA Hiroyuki
2009-11-06 19:47 ` Christoph Lameter
2009-11-06 19:47 ` Christoph Lameter
2009-11-10 22:44 ` Andrew Morton
2009-11-10 22:44 ` Andrew Morton
2009-11-10 23:20 ` Christoph Lameter
2009-11-10 23:20 ` Christoph Lameter
2009-11-06 4:08 ` KAMEZAWA Hiroyuki
2009-11-06 4:08 ` KAMEZAWA Hiroyuki
2009-11-06 4:15 ` KAMEZAWA Hiroyuki
2009-11-06 4:15 ` KAMEZAWA Hiroyuki
2009-11-05 1:16 ` [MM] Make mm counters per cpu instead of atomic KAMEZAWA Hiroyuki
2009-11-05 1:16 ` KAMEZAWA Hiroyuki
2009-11-05 15:10 ` Christoph Lameter
2009-11-05 15:10 ` Christoph Lameter
2009-11-05 23:42 ` KAMEZAWA Hiroyuki
2009-11-05 23:42 ` KAMEZAWA Hiroyuki
2009-11-17 6:48 ` Zhang, Yanmin
2009-11-17 6:48 ` Zhang, Yanmin
2009-11-17 7:31 ` Zhang, Yanmin
2009-11-17 7:31 ` Zhang, Yanmin
2009-11-17 9:34 ` Zhang, Yanmin
2009-11-17 9:34 ` Zhang, Yanmin
2009-11-17 17:25 ` Christoph Lameter
2009-11-17 17:25 ` Christoph Lameter
2009-11-19 0:48 ` Zhang, Yanmin
2009-11-19 0:48 ` Zhang, Yanmin
2009-11-23 8:51 ` Zhang, Yanmin
2009-11-23 8:51 ` Zhang, Yanmin
2009-11-23 14:31 ` Christoph Lameter
2009-11-23 14:31 ` Christoph Lameter
2009-11-24 8:02 ` Zhang, Yanmin
2009-11-24 8:02 ` Zhang, Yanmin
2009-11-24 15:17 ` Christoph Lameter
2009-11-24 15:17 ` Christoph Lameter
2009-11-25 1:23 ` Zhang, Yanmin
2009-11-25 1:23 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105082735.GP31511@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.