From: Arnd Bergmann <arnd@arndb.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
akpm@linux-foundation.org, hpa@zytor.com,
gregory.haskins@gmail.com, Rusty Russell <rusty@rustcorp.com.au>,
s.hetze@linux-ag.com
Subject: Re: [PATCHv6 1/3] tun: export underlying socket
Date: Thu, 5 Nov 2009 12:30:43 +0100 [thread overview]
Message-ID: <200911051230.43272.arnd@arndb.de> (raw)
In-Reply-To: <20091104190523.GA772@redhat.com>
On Wednesday 04 November 2009, Michael S. Tsirkin wrote:
> >
> > Michael, you didn't reply on this comment and the code is still there in v8.
> > Do you actually need this? What for?
> >
> > Arnd <><
>
> Sorry, missed the question. If you look closely it is not exported for
> !__KERNEL__ at all. The stub is for when CONFIG_TUN is undefined.
> Maybe I'll add a comment near #else, even though this is a bit strange
> since the #if is just 2 lines above it.
Ah right, I'm just blind.
Don't bother changing it then, the code looks good as it is.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
akpm@linux-foundation.org, hpa@zytor.com,
gregory.haskins@gmail.com, Rusty Russell <rusty@rustcorp.com.au>,
s.hetze@linux-ag.com
Subject: Re: [PATCHv6 1/3] tun: export underlying socket
Date: Thu, 5 Nov 2009 12:30:43 +0100 [thread overview]
Message-ID: <200911051230.43272.arnd@arndb.de> (raw)
In-Reply-To: <20091104190523.GA772@redhat.com>
On Wednesday 04 November 2009, Michael S. Tsirkin wrote:
> >
> > Michael, you didn't reply on this comment and the code is still there in v8.
> > Do you actually need this? What for?
> >
> > Arnd <><
>
> Sorry, missed the question. If you look closely it is not exported for
> !__KERNEL__ at all. The stub is for when CONFIG_TUN is undefined.
> Maybe I'll add a comment near #else, even though this is a bit strange
> since the #if is just 2 lines above it.
Ah right, I'm just blind.
Don't bother changing it then, the code looks good as it is.
Arnd <><
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-11-05 11:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257193660.git.mst@redhat.com>
2009-11-02 22:26 ` [PATCHv6 1/3] tun: export underlying socket Michael S. Tsirkin
2009-11-02 22:26 ` Michael S. Tsirkin
2009-11-02 22:26 ` Michael S. Tsirkin
2009-11-03 12:12 ` Arnd Bergmann
2009-11-03 12:12 ` Arnd Bergmann
2009-11-03 12:31 ` Michael S. Tsirkin
2009-11-03 12:31 ` Michael S. Tsirkin
2009-11-03 12:41 ` Arnd Bergmann
2009-11-03 12:41 ` Arnd Bergmann
2009-11-03 12:41 ` Arnd Bergmann
2009-11-03 12:31 ` Michael S. Tsirkin
2009-11-04 18:09 ` Arnd Bergmann
2009-11-04 18:09 ` Arnd Bergmann
2009-11-04 18:09 ` Arnd Bergmann
2009-11-04 19:05 ` Michael S. Tsirkin
2009-11-04 19:05 ` Michael S. Tsirkin
2009-11-04 19:05 ` Michael S. Tsirkin
2009-11-05 11:30 ` Arnd Bergmann [this message]
2009-11-05 11:30 ` Arnd Bergmann
2009-11-05 11:30 ` Arnd Bergmann
2009-11-03 12:12 ` Arnd Bergmann
2009-11-02 22:26 ` Michael S. Tsirkin
2009-11-02 22:26 ` [PATCHv6 2/3] mm: export use_mm/unuse_mm to modules Michael S. Tsirkin
2009-11-02 22:26 ` Michael S. Tsirkin
2009-11-02 22:26 ` Michael S. Tsirkin
2009-11-02 22:26 ` Michael S. Tsirkin
2009-11-02 22:29 ` [PATCHv6 3/3] vhost_net: a kernel-level virtio server Michael S. Tsirkin
2009-11-02 22:29 ` Michael S. Tsirkin
2009-11-02 22:29 ` Michael S. Tsirkin
2009-11-03 0:05 ` Daniel Walker
2009-11-03 11:57 ` Michael S. Tsirkin
2009-11-03 11:57 ` Michael S. Tsirkin
2009-11-03 11:57 ` Michael S. Tsirkin
2009-11-03 0:05 ` Daniel Walker
2009-11-02 22:29 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911051230.43272.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=gregory.haskins@gmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=s.hetze@linux-ag.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.