From: Mike Snitzer <snitzer@redhat.com>
To: Alasdair G Kergon <agk@redhat.com>
Cc: dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: dm snapshot: allow live exception store handover between tables
Date: Fri, 6 Nov 2009 14:54:30 -0500 [thread overview]
Message-ID: <20091106195429.GE13427@redhat.com> (raw)
In-Reply-To: <20091106194136.GT13375@agk-dp.fab.redhat.com>
On Fri, Nov 06 2009 at 2:41pm -0500,
Alasdair G Kergon <agk@redhat.com> wrote:
> On Fri, Nov 06, 2009 at 02:26:21PM -0500, Mike Snitzer wrote:
> > OK, actually in practice 'lvchange --refresh' is:
> > old->suspend
> > new->ctr
>
> Those two need to be swapped.
> (I think it's a pre-existing userspace bug that's simple to fix.)
Why do they _need_ to be swapped?
> > old->resume
> > - device-mapper: snapshots: Unable to handover exceptions to another snapshot on resume.
> > new->resume
> > - snapshot_resume: handing over exceptions
>
> Handover to new device and make it live first, then remove old device.
> It doesn't make sense to me to remove the old device before the new one has
> successfully taken over from it.
OK, I'm not sure how to make that happen within lvm2's deptree. I'll
have a look. So you're saying refresh should result in:
new->ctr
old->suspend
new->resume
old->resume
Mike
next prev parent reply other threads:[~2009-11-06 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 18:40 [PATCH] dm snapshot: allow live exception store handover between tables Mike Snitzer
2009-11-06 18:46 ` Mike Snitzer
2009-11-06 19:26 ` Mike Snitzer
2009-11-06 19:41 ` Alasdair G Kergon
2009-11-06 19:54 ` Mike Snitzer [this message]
2009-11-06 20:07 ` Alasdair G Kergon
2009-11-06 20:37 ` Mike Snitzer
2009-11-06 20:37 ` Mike Snitzer
2009-11-11 3:26 ` [PATCH] " Mikulas Patocka
2009-11-11 12:41 ` Mike Snitzer
2009-11-11 20:46 ` Mikulas Patocka
2009-11-11 23:35 ` Mike Snitzer
2009-11-11 23:47 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106195429.GE13427@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.