[PATCH] Properly skip over quoted values

[PATCH] Properly skip over quoted values

[Andrzej Zaborowski]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Otherwise a left paren in a string can bring an obscure segfault.
---
 gatchat/gatresult.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/gatchat/gatresult.c b/gatchat/gatresult.c
index 3d07e13..688b26b 100644
--- a/gatchat/gatresult.c
+++ b/gatchat/gatresult.c
@@ -361,6 +361,17 @@ static gint skip_until(const char *line, int start, const char delim)
 		if (line[i] == delim)
 			return i;
 
+		if (line[i] == '\"') {
+			i += 1;
+			while (i < len && line[i] != '\"')
+				i += 1;
+
+			if (i < len)
+				i += 1;
+
+			continue;
+		}
+
 		if (line[i] != '(') {
 			i += 1;
 			continue;
-- 
1.6.1

Re: [PATCH] Properly skip over quoted values

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi Andrew,

> Otherwise a left paren in a string can bring an obscure segfault.
> ---
> +		if (line[i] == '\"') {
> +			i += 1;
> +			while (i < len && line[i] != '\"')
> +				i += 1;
> +
> +			if (i < len)
> +				i += 1;
> +
> +			continue;
> +		}
> +

I suggest you recursively call skip_until here instead of duplicating the 
code.  It also should be moved down and treated like '(' and ')'

Regards,
-Denis

Re: [PATCH] Properly skip over quoted values

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]

Nevermind, I see why you did it this way.  Patch has been applied.

Regards,
-Denis