All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Tobias Klauser <tklauser@distanz.ch>, linux-omap@vger.kernel.org
Subject: [PATCH 2/8] omap: Use resource_size
Date: Tue, 10 Nov 2009 19:00:45 -0800	[thread overview]
Message-ID: <20091111030045.31793.89110.stgit@localhost> (raw)
In-Reply-To: <20091111025907.31793.84134.stgit@localhost>

From: Tobias Klauser <tklauser@distanz.ch>

Use the resource_size function instead of manually calculating the
resource size. This reduces the chance of introducing off-by-one errors
and actually fixes one in mailbox.c.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/gpmc.c    |    2 +-
 arch/arm/mach-omap2/mailbox.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 1587682..f865756 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -366,7 +366,7 @@ int gpmc_cs_request(int cs, unsigned long size, unsigned long *base)
 	if (r < 0)
 		goto out;
 
-	gpmc_cs_enable_mem(cs, res->start, res->end - res->start + 1);
+	gpmc_cs_enable_mem(cs, res->start, resource_size(res));
 	*base = res->start;
 	gpmc_cs_set_reserved(cs, 1);
 out:
diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index c035ad3..ef57b38 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
@@ -300,7 +300,7 @@ static int __devinit omap2_mbox_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "invalid mem resource\n");
 		return -ENODEV;
 	}
-	mbox_base = ioremap(res->start, res->end - res->start);
+	mbox_base = ioremap(res->start, resource_size(res));
 	if (!mbox_base)
 		return -ENOMEM;
 


WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] omap: Use resource_size
Date: Tue, 10 Nov 2009 19:00:45 -0800	[thread overview]
Message-ID: <20091111030045.31793.89110.stgit@localhost> (raw)
In-Reply-To: <20091111025907.31793.84134.stgit@localhost>

From: Tobias Klauser <tklauser@distanz.ch>

Use the resource_size function instead of manually calculating the
resource size. This reduces the chance of introducing off-by-one errors
and actually fixes one in mailbox.c.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/gpmc.c    |    2 +-
 arch/arm/mach-omap2/mailbox.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 1587682..f865756 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -366,7 +366,7 @@ int gpmc_cs_request(int cs, unsigned long size, unsigned long *base)
 	if (r < 0)
 		goto out;
 
-	gpmc_cs_enable_mem(cs, res->start, res->end - res->start + 1);
+	gpmc_cs_enable_mem(cs, res->start, resource_size(res));
 	*base = res->start;
 	gpmc_cs_set_reserved(cs, 1);
 out:
diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index c035ad3..ef57b38 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
@@ -300,7 +300,7 @@ static int __devinit omap2_mbox_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "invalid mem resource\n");
 		return -ENODEV;
 	}
-	mbox_base = ioremap(res->start, res->end - res->start);
+	mbox_base = ioremap(res->start, resource_size(res));
 	if (!mbox_base)
 		return -ENOMEM;
 

  parent reply	other threads:[~2009-11-11  3:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  3:00 [PATCH 0/8] Omap fixes for v2.6.32-rc6 Tony Lindgren
2009-11-11  3:00 ` Tony Lindgren
2009-11-11  3:00 ` [PATCH 1/8] omap: Fix race condition in omap dma driver Tony Lindgren
2009-11-11  3:00   ` Tony Lindgren
2009-11-11  3:00 ` Tony Lindgren [this message]
2009-11-11  3:00   ` [PATCH 2/8] omap: Use resource_size Tony Lindgren
2009-11-11 19:06   ` [PATCH 2.5/8] omap: Fix omapfb/lcdc on OMAP1510 broken when PM set Tony Lindgren
2009-11-11 19:06     ` Tony Lindgren
2009-11-11  3:00 ` [PATCH 3/8] omap1: Amstrad Delta defconfig fixes Tony Lindgren
2009-11-11  3:00   ` Tony Lindgren
2009-11-11 17:24   ` Janusz Krzysztofik
2009-11-11 17:24     ` Janusz Krzysztofik
2009-11-11 18:56     ` Tony Lindgren
2009-11-11 18:56       ` Tony Lindgren
2009-11-11  3:01 ` [PATCH 4/8] omap3: pandora: Fix keypad keymap Tony Lindgren
2009-11-11  3:01   ` Tony Lindgren
2009-11-11  3:01 ` [PATCH 5/8] omap3: beagle: Fix USB host port power control Tony Lindgren
2009-11-11  3:01   ` Tony Lindgren
2009-11-11  3:01 ` [PATCH 6/8] omap3: 3430sdp: Enable Linux Regulator framework Tony Lindgren
2009-11-11  3:01   ` Tony Lindgren
2009-11-11  3:01 ` [PATCH 7/8] omap: update Pandora defconfig Tony Lindgren
2009-11-11  3:01   ` Tony Lindgren
2009-11-11  3:01 ` [PATCH 8/8] omap3: Decrease cpufreq transition latency Tony Lindgren
2009-11-11  3:01   ` Tony Lindgren
2009-11-11  3:16 ` [PATCH 0/8] Omap fixes for v2.6.32-rc6 Sid Boyce
2009-11-11 19:08   ` Tony Lindgren
2009-11-11 23:20     ` Sid Boyce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111030045.31793.89110.stgit@localhost \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.