All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Izik Eidus <ieidus@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Nick Piggin <npiggin@suse.de>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	Andi Kleen <andi@firstfloor.org>,
	Wu Fengguang <fengguang.wu@intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/6] mm: CONFIG_MMU for PG_mlocked
Date: Wed, 11 Nov 2009 13:38:30 +0100	[thread overview]
Message-ID: <20091111123829.GA16628@basil.fritz.box> (raw)
In-Reply-To: <Pine.LNX.4.64.0911102155180.2816@sister.anvils>

On Tue, Nov 10, 2009 at 09:59:23PM +0000, Hugh Dickins wrote:
> Remove three degrees of obfuscation, left over from when we had
> CONFIG_UNEVICTABLE_LRU.  MLOCK_PAGES is CONFIG_HAVE_MLOCKED_PAGE_BIT
> is CONFIG_HAVE_MLOCK is CONFIG_MMU.  rmap.o (and memory-failure.o)
> are only built when CONFIG_MMU, so don't need such conditions at all.

Thanks.  The memory-failure.c change looks good and indeeds
it's overall less confusing.
-Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Izik Eidus <ieidus@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Nick Piggin <npiggin@suse.de>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	Andi Kleen <andi@firstfloor.org>,
	Wu Fengguang <fengguang.wu@intel.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/6] mm: CONFIG_MMU for PG_mlocked
Date: Wed, 11 Nov 2009 13:38:30 +0100	[thread overview]
Message-ID: <20091111123829.GA16628@basil.fritz.box> (raw)
In-Reply-To: <Pine.LNX.4.64.0911102155180.2816@sister.anvils>

On Tue, Nov 10, 2009 at 09:59:23PM +0000, Hugh Dickins wrote:
> Remove three degrees of obfuscation, left over from when we had
> CONFIG_UNEVICTABLE_LRU.  MLOCK_PAGES is CONFIG_HAVE_MLOCKED_PAGE_BIT
> is CONFIG_HAVE_MLOCK is CONFIG_MMU.  rmap.o (and memory-failure.o)
> are only built when CONFIG_MMU, so don't need such conditions at all.

Thanks.  The memory-failure.c change looks good and indeeds
it's overall less confusing.
-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-11-11 12:38 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 21:50 [PATCH 0/6] mm: prepare for ksm swapping Hugh Dickins
2009-11-10 21:50 ` Hugh Dickins
2009-11-10 21:51 ` [PATCH 1/6] mm: define PAGE_MAPPING_FLAGS Hugh Dickins
2009-11-10 21:51   ` Hugh Dickins
2009-11-19  0:25   ` Rik van Riel
2009-11-19  0:25     ` Rik van Riel
2009-11-10 21:55 ` [PATCH 2/6] mm: mlocking in try_to_unmap_one Hugh Dickins
2009-11-10 21:55   ` Hugh Dickins
2009-11-11  7:56   ` KOSAKI Motohiro
2009-11-11  7:56     ` KOSAKI Motohiro
2009-11-11 11:36     ` Hugh Dickins
2009-11-11 11:36       ` Hugh Dickins
2009-11-13  8:16       ` KOSAKI Motohiro
2009-11-13  8:16         ` KOSAKI Motohiro
2009-11-13  8:26         ` KOSAKI Motohiro
2009-11-13  8:26           ` KOSAKI Motohiro
2009-11-13 11:50           ` Andrea Arcangeli
2009-11-13 11:50             ` Andrea Arcangeli
2009-11-13 18:00             ` KOSAKI Motohiro
2009-11-13 18:00               ` KOSAKI Motohiro
2009-11-15 22:37         ` Hugh Dickins
2009-11-15 22:37           ` Hugh Dickins
2009-11-17  2:00           ` KOSAKI Motohiro
2009-11-17  2:00             ` KOSAKI Motohiro
2009-11-18 16:32             ` Hugh Dickins
2009-11-18 16:32               ` Hugh Dickins
2009-11-13  6:30   ` KOSAKI Motohiro
2009-11-13  6:30     ` KOSAKI Motohiro
2009-11-15 22:16     ` Hugh Dickins
2009-11-15 22:16       ` Hugh Dickins
2009-11-16 23:34       ` KOSAKI Motohiro
2009-11-16 23:34         ` KOSAKI Motohiro
2009-11-10 21:59 ` [PATCH 3/6] mm: CONFIG_MMU for PG_mlocked Hugh Dickins
2009-11-10 21:59   ` Hugh Dickins
2009-11-11  1:22   ` KOSAKI Motohiro
2009-11-11  1:22     ` KOSAKI Motohiro
2009-11-11 10:48     ` Hugh Dickins
2009-11-11 10:48       ` Hugh Dickins
2009-11-11 12:38   ` Andi Kleen [this message]
2009-11-11 12:38     ` Andi Kleen
2009-11-10 22:00 ` [PATCH 4/6] mm: pass address down to rmap ones Hugh Dickins
2009-11-10 22:00   ` Hugh Dickins
2009-11-10 22:02 ` [PATCH 5/6] mm: stop ptlock enlarging struct page Hugh Dickins
2009-11-10 22:02   ` Hugh Dickins
2009-11-10 22:09   ` Peter Zijlstra
2009-11-10 22:09     ` Peter Zijlstra
2009-11-10 22:24     ` Hugh Dickins
2009-11-10 22:24       ` Hugh Dickins
2009-11-10 22:14   ` Peter Zijlstra
2009-11-10 22:14     ` Peter Zijlstra
2009-11-10 22:29     ` Hugh Dickins
2009-11-10 22:29       ` Hugh Dickins
2009-11-10 22:06 ` [PATCH 6/6] mm: sigbus instead of abusing oom Hugh Dickins
2009-11-10 22:06   ` Hugh Dickins
2009-11-11  2:37   ` KAMEZAWA Hiroyuki
2009-11-11  2:37     ` KAMEZAWA Hiroyuki
2009-11-11  2:42     ` KOSAKI Motohiro
2009-11-11  2:42       ` KOSAKI Motohiro
2009-11-11  4:35       ` Wu Fengguang
2009-11-11  4:35         ` Wu Fengguang
2009-11-11  5:51   ` Minchan Kim
2009-11-11  5:51     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111123829.GA16628@basil.fritz.box \
    --to=andi@firstfloor.org \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=ieidus@redhat.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.