* [PATCH 1/2] Fix: Remove released call from call lists
@ 2009-11-16 10:20 Zhenhua Zhang
2009-11-16 16:12 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Zhenhua Zhang @ 2009-11-16 10:20 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
We should remove the released call from the list to avoid
potiential double free problem.
---
drivers/hfpmodem/voicecall.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c
index 689597d..d12cd4c 100644
--- a/drivers/hfpmodem/voicecall.c
+++ b/drivers/hfpmodem/voicecall.c
@@ -137,6 +137,8 @@ static void release_call(struct ofono_voicecall *vc,
struct ofono_call *call)
at_util_release_id(&vd->id_list, call->id);
vd->local_release &= ~(1 << call->id);
+ vd->calls = g_slist_remove(vd->calls, call);
+
g_free(call);
}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] Fix: Remove released call from call lists
2009-11-16 10:20 [PATCH 1/2] Fix: Remove released call from call lists Zhenhua Zhang
@ 2009-11-16 16:12 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2009-11-16 16:12 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
Hi Zhenhua,
> We should remove the released call from the list to avoid
> potiential double free problem.
The issue was actually in release_by_status. Should now be fixed.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-16 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-16 10:20 [PATCH 1/2] Fix: Remove released call from call lists Zhenhua Zhang
2009-11-16 16:12 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.