All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/4] Fix: Handle callsetup=0 when no waiting or dialing call
@ 2009-11-16 14:10 Zhenhua Zhang
  2009-11-16 17:16 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Zhenhua Zhang @ 2009-11-16 14:10 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

When call=1 and callsetup=0, if no waiting or dialing call, the call
is active and no need to notify status change.
---
 drivers/hfpmodem/voicecall.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c
index 52bec36..ba4b4d5 100644
--- a/drivers/hfpmodem/voicecall.c
+++ b/drivers/hfpmodem/voicecall.c
@@ -767,6 +767,11 @@ static void ciev_callsetup_notify(struct
ofono_voicecall *vc,
 			goto out;
 		}
 
+		/* If call=1 and no call is waiting or dialing, the call
+		 * is active. */
+		if (waiting == NULL && dialing == NULL)
+			goto out;
+
 		 /*
 		 * If call=1, in the waiting case we have to poll, since we
 		 * have no idea whether a waiting call gave up or we accepted
-- 
1.6.2.5




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/4] Fix: Handle callsetup=0 when no waiting or dialing call
  2009-11-16 14:10 [PATCH 1/4] Fix: Handle callsetup=0 when no waiting or dialing call Zhenhua Zhang
@ 2009-11-16 17:16 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2009-11-16 17:16 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

Hi Zhenhua,

> When call=1 and callsetup=0, if no waiting or dialing call, the call
> is active and no need to notify status change.

This one has been applied.  Thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-16 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-16 14:10 [PATCH 1/4] Fix: Handle callsetup=0 when no waiting or dialing call Zhenhua Zhang
2009-11-16 17:16 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.