From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] Fix: No need to put active call on hold
Date: Mon, 16 Nov 2009 11:26:07 -0600 [thread overview]
Message-ID: <200911161126.08068.denkenz@gmail.com> (raw)
In-Reply-To: <1258380704.5437.1.camel@zzhan17-mobl.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
Hi Zhenhua,
> First, call->status should be 1 stead of 2 in the loop. Second,
> it's incorrect to set status to hold because later callheld=1
> will swap call status back. So active->hold->active again is
> not correct.
Unfortunately we do need to put the calls on hold otherwise the core might
pick the wrong call as the 'dialed' call. Instead we now ignore the
callheld=1 indicator in this situation. Let me know if this still doesn't fix
this issue.
Regards,
-Denis
next prev parent reply other threads:[~2009-11-16 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 14:11 [PATCH 2/4] Fix: No need to put active call on hold Zhenhua Zhang
2009-11-16 17:26 ` Denis Kenzior [this message]
2009-11-17 0:39 ` Zhang, Zhenhua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911161126.08068.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.