[PATCH 2/4] Fix: No need to put active call on hold

[PATCH 2/4] Fix: No need to put active call on hold

[Zhenhua Zhang]

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

First, call->status should be 1 stead of 2 in the loop. Second,
it's incorrect to set status to hold because later callheld=1
will swap call status back. So active->hold->active again is
not correct.
---
 drivers/hfpmodem/voicecall.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c
index ba4b4d5..d9c3c2a 100644
--- a/drivers/hfpmodem/voicecall.c
+++ b/drivers/hfpmodem/voicecall.c
@@ -285,7 +285,6 @@ static void atd_cb(gboolean ok, GAtResult *result,
gpointer user_data)
 	int validity = 2;
 	struct ofono_error error;
 	struct ofono_call *call;
-	GSList *l;
 
 	dump_response("atd_cb", ok, result);
 
@@ -294,17 +293,6 @@ static void atd_cb(gboolean ok, GAtResult *result,
gpointer user_data)
 	if (!ok)
 		goto out;
 
-	/* On a success, make sure to put all active calls on hold */
-	for (l = vd->calls; l; l = l->next) {
-		call = l->data;
-
-		if (call->status != 0)
-			continue;
-
-		call->status = 2;
-		ofono_voicecall_notify(vc, call);
-	}
-
 	call = create_call(vd, 0, 0, CALL_STATUS_DIALING, NULL, type,
validity);
 
 	if (!call) {
-- 
1.6.2.5

Re: [PATCH 2/4] Fix: No need to put active call on hold

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

Hi Zhenhua,

> First, call->status should be 1 stead of 2 in the loop. Second,
> it's incorrect to set status to hold because later callheld=1
> will swap call status back. So active->hold->active again is
> not correct.

Unfortunately we do need to put the calls on hold otherwise the core might 
pick the wrong call as the 'dialed' call.  Instead we now ignore the 
callheld=1 indicator in this situation.  Let me know if this still doesn't fix 
this issue.

Regards,
-Denis

RE: [PATCH 2/4] Fix: No need to put active call on hold

[Zhang, Zhenhua]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

Hi Denis,

Denis Kenzior wrote:
> Hi Zhenhua,
> 
>> First, call->status should be 1 stead of 2 in the loop. Second, it's
>> incorrect to set status to hold because later callheld=1 will swap
>> call status back. So active->hold->active again is not correct.
> 
> Unfortunately we do need to put the calls on hold otherwise
> the core might pick the wrong call as the 'dialed' call. Instead we
> now ignore the callheld=1 indicator in this situation.  Let me know
> if this still doesn't fix this issue. 

Ok. So let's extend the ignore_callheld_1 to another case. If we already
put current active call on hold, user dial out another call from phone,
we also need set ignore_callheld_1 as TRUE so the held call won't
be active again.

> Regards,
> -Denis
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono


Regards,
Zhenhua