From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: James Harper <james.harper@bendigoit.com.au>
Cc: xen-devel@lists.xensource.com
Subject: Re: compile error with pvops and pcifront
Date: Mon, 16 Nov 2009 09:39:29 -0500 [thread overview]
Message-ID: <20091116143929.GA30967@phenom.dumpdata.com> (raw)
In-Reply-To: <AEC6C66638C05B468B556EA548C1A77D0180D44F@trantor>
On Sun, Nov 15, 2009 at 04:24:02PM +1100, James Harper wrote:
> > Either CONFIG_XEN_PCIDEV_FRONTEND should not be allowed to be a
> module,
> > or CONFIG_XEN_PCIDEV_FRONTEND_MODULE needs to be checked for like:
> >
> > diff --git a/arch/x86/include/asm/xen/pci.h
> > b/arch/x86/include/asm/xen/pci.h
> > index 6c022c8..7b99422 100644
> > --- a/arch/x86/include/asm/xen/pci.h
> > +++ b/arch/x86/include/asm/xen/pci.h
> > @@ -35,7 +35,9 @@ static inline int xen_setup_msi_irqs(struct pci_dev
> > *dev, int nvec, int type)
> > return -1;
> > }
> > #endif
> > -#if defined(CONFIG_PCI_MSI) && defined(CONFIG_XEN_PCIDEV_FRONTEND)
> > +
> > +#if defined(CONFIG_PCI_MSI) && (defined(CONFIG_XEN_PCIDEV_FRONTEND) \
> > + || defined(CONFIG_XEN_PCIDEV_FRONTEND_MODULE))
> > /* Defined in drivers/pci/xen-pcifront.c */
> > int pci_frontend_enable_msi(struct pci_dev *dev, int **vectors);
> > void pci_frontend_disable_msi(struct pci_dev *dev);
> >
> > linewrapping probably destroyed the patch but it should be obvious
> what
> > is wrong.
> >
>
> That's still not enough though - I get a link failure after that.
Can you e-mail me your whole .config file, please?
prev parent reply other threads:[~2009-11-16 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 5:03 compile error with pvops and pcifront James Harper
2009-11-15 5:24 ` James Harper
2009-11-16 14:39 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116143929.GA30967@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=james.harper@bendigoit.com.au \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.