From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Joe Jin <joe.jin@oracle.com>
Cc: "Hackel, Kurt" <kurt.hackel@oracle.com>,
Jerry Yuanjiang Ou <yuanjiang.ou@oracle.com>,
Xen-devel <xen-devel@lists.xensource.com>,
Keir Fraser <keir.fraser@eu.citrix.com>,
greg.marsden@oracle.com
Subject: Re: [PATCH] Dont call msi_unmap_pirq() if did not enabled msi
Date: Mon, 16 Nov 2009 10:26:53 -0500 [thread overview]
Message-ID: <20091116152653.GA20333@phenom.dumpdata.com> (raw)
In-Reply-To: <20091116151546.GC30967@phenom.dumpdata.com>
On Mon, Nov 16, 2009 at 10:15:46AM -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Nov 16, 2009 at 08:00:30PM +0800, Joe Jin wrote:
> > Hi,
> >
> > When device driver unload, it may call pci_disable_msi(), if msi did not
> > enabled but do msi_unmap_pirq(), then later driver reload and without
>
> Where does that happen? That looks to be a driver bug as well.
>
> > msi, then will failed in request_irq() for irq_desc[irq]->chip valie is
> > no_irq_chip. So when did not enable msi during driver initializing, then
>
> Won't that mean it is unusable? As in, you can't allocate an IRQ
> to the device when the irq_desc[irq]->chip_value==no_irq_chip?
Duh! I think I answered myself here and the answer is yes, otherwise you
would not have hit this bug :-(
next prev parent reply other threads:[~2009-11-16 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 12:00 [PATCH] Dont call msi_unmap_pirq() if did not enabled msi Joe Jin
2009-11-16 15:15 ` Konrad Rzeszutek Wilk
2009-11-16 15:26 ` Konrad Rzeszutek Wilk [this message]
2009-11-17 0:19 ` Joe Jin
2009-11-17 7:59 ` Jan Beulich
2009-11-17 10:14 ` Joe Jin
2009-11-17 11:21 ` Jan Beulich
2009-11-18 6:23 ` Jiang, Yunhong
2009-11-23 2:24 ` Joe Jin
2009-11-24 2:02 ` Joe Jin
2009-11-24 6:12 ` Jiang, Yunhong
2009-11-24 6:42 ` Joe Jin
2009-11-24 7:06 ` Jiang, Yunhong
2009-11-26 9:14 ` Jan Beulich
2009-11-26 10:03 ` Jiang, Yunhong
2009-11-26 10:14 ` Jiang, Yunhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116152653.GA20333@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=greg.marsden@oracle.com \
--cc=joe.jin@oracle.com \
--cc=keir.fraser@eu.citrix.com \
--cc=kurt.hackel@oracle.com \
--cc=xen-devel@lists.xensource.com \
--cc=yuanjiang.ou@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.