From: Stephen Hemminger <shemminger@vyatta.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: clear uptodate flag on super block I/O error
Date: Tue, 17 Nov 2009 09:16:03 -0800 [thread overview]
Message-ID: <20091117091603.3d9abab9@nehalam> (raw)
In-Reply-To: <20091117020821.GF5818@wotan.suse.de>
> I think the real fix is to avoid clearing uptodate in case of io errors.
> For read io errors, the buffer/page should not have been uptodate to
> start with, and for write io errors, an error writing back the buffer
> does not mean it is somehow no longer the most uptodate copy of the data.
>
> Higher level policy about IO errors (whether to retry, ignore, throw
> out the data, etc) would be nice to implement properly too, but that is
> not really the job of the low level cache and IO routines.
>
> I proposed some patches a while back but didn't get much interest.
> Maybe I should just ask someone to merge them.
I am interested in fixing current releases. But I agree it should be handled
in a general way in future.
next prev parent reply other threads:[~2009-11-17 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 20:33 Mount -o sync regression in 2.6.31 Stephen Hemminger
2009-11-11 21:34 ` Frans Pop
2009-11-11 22:20 ` Stephen Hemminger
2009-11-13 22:47 ` Stephen Hemminger
2009-11-13 23:07 ` Andrew Morton
2009-11-13 23:28 ` Stephen Hemminger
2009-11-17 0:04 ` [PATCH] ext2: clear uptodate flag on super block I/O error Stephen Hemminger
2009-11-17 2:08 ` Nick Piggin
2009-11-17 17:16 ` Stephen Hemminger [this message]
2009-11-14 13:18 ` Mount -o sync regression in 2.6.31 Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117091603.3d9abab9@nehalam \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.