From: Christoph Hellwig <hch@lst.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 07/15] scsi: add scsi-defs.h
Date: Tue, 17 Nov 2009 12:35:41 +0100 [thread overview]
Message-ID: <20091117113541.GG31958@lst.de> (raw)
In-Reply-To: <1258453071-3496-8-git-send-email-kraxel@redhat.com>
On Tue, Nov 17, 2009 at 11:17:43AM +0100, Gerd Hoffmann wrote:
> Largely based on <scsi/scsi.h> from linux. Added into the tree so we
> can use the defines everywhere, not just in scsi-generic.c (which is
> linux-specific).
Btw, I'm not sure having the name clash with the Linux header is a good
idea as we need to include it for ioctls. Also the complete lack of
prefixes for the defines might causes some problems.
Otherwise a good idea,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> @@ -0,0 +1,156 @@
> +/* Copyright (C) 1998, 1999 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
You probably want to take the kernel scsi.h to base things upon as it's
a lot more uptodate than the glibc one.
next prev parent reply other threads:[~2009-11-17 11:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 10:17 [Qemu-devel] [PATCH 00/15] scsi: data structures and cleanups Gerd Hoffmann
2009-11-17 10:17 ` [Qemu-devel] [PATCH 01/15] scsi: add/fix header protection Gerd Hoffmann
2009-11-17 11:11 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 02/15] scsi: create common SCSIRequest structure Gerd Hoffmann
2009-11-17 11:12 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ Gerd Hoffmann
2009-11-17 11:15 ` Christoph Hellwig
2009-11-17 11:59 ` Paul Brook
2009-11-17 12:39 ` Gerd Hoffmann
2009-11-18 9:44 ` Gerd Hoffmann
2009-11-17 10:17 ` [Qemu-devel] [PATCH 04/15] scsi: add scsi_req_init() Gerd Hoffmann
2009-11-17 11:16 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest Gerd Hoffmann
2009-11-17 11:17 ` Christoph Hellwig
2009-11-17 11:55 ` Paul Brook
2009-11-17 12:45 ` Gerd Hoffmann
2009-11-17 10:17 ` [Qemu-devel] [PATCH 06/15] scsi: move blocksize from SCSIGenericState to SCSIDevice Gerd Hoffmann
2009-11-17 11:34 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 07/15] scsi: add scsi-defs.h Gerd Hoffmann
2009-11-17 11:35 ` Christoph Hellwig [this message]
2009-11-17 10:17 ` [Qemu-devel] [PATCH 08/15] scsi: move type from SCSIGenericState to SCSIDevice Gerd Hoffmann
2009-11-17 11:36 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code Gerd Hoffmann
2009-11-17 11:50 ` Christoph Hellwig
2009-11-17 12:27 ` Paul Brook
2009-11-17 12:51 ` Gerd Hoffmann
2009-11-17 13:43 ` Paul Brook
2009-11-17 10:17 ` [Qemu-devel] [PATCH 10/15] scsi: use command defines in scsi-disk.c Gerd Hoffmann
2009-11-17 11:51 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 11/15] scsi: add xfer mode Gerd Hoffmann
2009-11-17 11:53 ` Christoph Hellwig
2009-11-17 11:58 ` Paul Brook
2009-11-17 10:17 ` [Qemu-devel] [PATCH 12/15] scsi: move sense to SCSIDevice, create SCSISense struct Gerd Hoffmann
2009-11-17 11:54 ` Christoph Hellwig
2009-11-17 12:54 ` Gerd Hoffmann
2009-11-17 10:17 ` [Qemu-devel] [PATCH 13/15] scsi: move dinfo to SCSIDevice Gerd Hoffmann
2009-11-17 12:00 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 14/15] scsi: move status to SCSIRequest Gerd Hoffmann
2009-11-17 12:01 ` Christoph Hellwig
2009-11-17 10:17 ` [Qemu-devel] [PATCH 15/15] scsi: add scsi_req_print() Gerd Hoffmann
2009-11-17 12:02 ` Christoph Hellwig
2009-11-17 12:56 ` Gerd Hoffmann
2009-11-17 13:19 ` [Qemu-devel] Re: [PATCH 00/15] scsi: data structures and cleanups Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117113541.GG31958@lst.de \
--to=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.