* [PATCH] ep93xx: add missing parentheses in IOMEM macro
@ 2009-11-17 11:49 Hubert Feurstein
2009-11-17 16:36 ` H Hartley Sweeten
0 siblings, 1 reply; 3+ messages in thread
From: Hubert Feurstein @ 2009-11-17 11:49 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
---
arch/arm/mach-ep93xx/include/mach/io.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-ep93xx/include/mach/io.h b/arch/arm/mach-ep93xx/include/mach/io.h
index 594b77f..ddb6e32 100644
--- a/arch/arm/mach-ep93xx/include/mach/io.h
+++ b/arch/arm/mach-ep93xx/include/mach/io.h
@@ -14,7 +14,7 @@
* A typesafe __io() variation for variable initialisers
*/
#ifdef __ASSEMBLER__
-#define IOMEM(p) p
+#define IOMEM(p) (p)
#else
#define IOMEM(p) ((void __iomem __force *)(p))
#endif
--
1.6.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ep93xx: add missing parentheses in IOMEM macro
2009-11-17 11:49 [PATCH] ep93xx: add missing parentheses in IOMEM macro Hubert Feurstein
@ 2009-11-17 16:36 ` H Hartley Sweeten
2009-11-19 22:38 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2009-11-17 16:36 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, November 17, 2009 4:49 AM, Hubert Feurstein wrote:
>
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
> arch/arm/mach-ep93xx/include/mach/io.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/include/mach/io.h b/arch/arm/mach-ep93xx/include/mach/io.h
> index 594b77f..ddb6e32 100644
> --- a/arch/arm/mach-ep93xx/include/mach/io.h
> +++ b/arch/arm/mach-ep93xx/include/mach/io.h
> @@ -14,7 +14,7 @@
> * A typesafe __io() variation for variable initialisers
> */
> #ifdef __ASSEMBLER__
> -#define IOMEM(p) p
> +#define IOMEM(p) (p)
> #else
> #define IOMEM(p) ((void __iomem __force *)(p))
> #endif
I think the __ASSEMBLER__ version of the IOMEM macro is missing the
parentheses on purpose.
Maybe Russell can shed some light on this.
Regards,
Hartley
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ep93xx: add missing parentheses in IOMEM macro
2009-11-17 16:36 ` H Hartley Sweeten
@ 2009-11-19 22:38 ` Russell King - ARM Linux
0 siblings, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2009-11-19 22:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 17, 2009 at 11:36:36AM -0500, H Hartley Sweeten wrote:
> On Tuesday, November 17, 2009 4:49 AM, Hubert Feurstein wrote:
> >
> > Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> > ---
> > arch/arm/mach-ep93xx/include/mach/io.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-ep93xx/include/mach/io.h b/arch/arm/mach-ep93xx/include/mach/io.h
> > index 594b77f..ddb6e32 100644
> > --- a/arch/arm/mach-ep93xx/include/mach/io.h
> > +++ b/arch/arm/mach-ep93xx/include/mach/io.h
> > @@ -14,7 +14,7 @@
> > * A typesafe __io() variation for variable initialisers
> > */
> > #ifdef __ASSEMBLER__
> > -#define IOMEM(p) p
> > +#define IOMEM(p) (p)
> > #else
> > #define IOMEM(p) ((void __iomem __force *)(p))
> > #endif
>
> I think the __ASSEMBLER__ version of the IOMEM macro is missing the
> parentheses on purpose.
>
> Maybe Russell can shed some light on this.
Well, parens shouldn't hurt assembly, so it should be safe to add them.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-19 22:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-17 11:49 [PATCH] ep93xx: add missing parentheses in IOMEM macro Hubert Feurstein
2009-11-17 16:36 ` H Hartley Sweeten
2009-11-19 22:38 ` Russell King - ARM Linux
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.