All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 14472] New: EXT4 corruption
@ 2009-10-26 16:52 bugzilla-daemon
  2009-10-29 21:31 ` [Bug 14472] " bugzilla-daemon
                   ` (5 more replies)
  0 siblings, 6 replies; 26+ messages in thread
From: bugzilla-daemon @ 2009-10-26 16:52 UTC (permalink / raw)
  To: linux-ext4

http://bugzilla.kernel.org/show_bug.cgi?id=14472

           Summary: EXT4 corruption
           Product: File System
           Version: 2.5
    Kernel Version: 2.6.32-rc4
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: ext4
        AssignedTo: fs_ext4@kernel-bugs.osdl.org
        ReportedBy: rjw@sisk.pl
            Blocks: 14230
        Regression: Yes


Subject    : [2.6.32-rc4] + EXT4 corruption
Submitter  : Shawn Starr <shawn.starr@rogers.com>
Date       : 2009-10-13 2:07
References : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
Handled-By : Theodore Tso <tytso@mit.edu>
Notify-Also : Andy Lutomirski <luto@mit.edu>

This entry is being used for tracking a regression from 2.6.31.  Please don't
close it until the problem is fixed in the mainline.

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug #14472] EXT4 corruption
  2009-10-26 18:45 2.6.32-rc5-git3: Reported regressions from 2.6.31 Rafael J. Wysocki
@ 2009-10-26 18:55   ` Rafael J. Wysocki
  0 siblings, 0 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2009-10-26 18:55 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: Kernel Testers List, Andy Lutomirski, Shawn Starr, Theodore Tso

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.31.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14472
Subject		: EXT4 corruption
Submitter	: Shawn Starr <shawn.starr-bJEeYj9oJeDQT0dZR+AlfA@public.gmane.org>
Date		: 2009-10-13 2:07 (14 days old)
References	: http://marc.info/?l=linux-kernel&m=125539997508256&w=4
Handled-By	: Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org>


^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug #14472] EXT4 corruption
@ 2009-10-26 18:55   ` Rafael J. Wysocki
  0 siblings, 0 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2009-10-26 18:55 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: Kernel Testers List, Andy Lutomirski, Shawn Starr, Theodore Tso

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.31.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14472
Subject		: EXT4 corruption
Submitter	: Shawn Starr <shawn.starr@rogers.com>
Date		: 2009-10-13 2:07 (14 days old)
References	: http://marc.info/?l=linux-kernel&m=125539997508256&w=4
Handled-By	: Theodore Tso <tytso@mit.edu>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-10-26 18:55   ` Rafael J. Wysocki
@ 2009-10-29 19:57     ` Andrew Lutomirski
  -1 siblings, 0 replies; 26+ messages in thread
From: Andrew Lutomirski @ 2009-10-29 19:57 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Kernel Mailing List, Kernel Testers List, Shawn Starr,
	Theodore Tso

On Mon, Oct 26, 2009 at 2:55 PM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.31.  Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> Subject         : EXT4 corruption
> Submitter       : Shawn Starr <shawn.starr-bJEeYj9oJeDQT0dZR+AlfA@public.gmane.org>
> Date            : 2009-10-13 2:07 (14 days old)
> References      : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> Handled-By      : Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org>
>


This but is *not* fixed.  I just triggered it a few minutes ago by
abusing i915 and drm, which caused a panic.  This is slightly newer
than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.

Photos are here:
http://web.mit.edu/luto/www/ext4_crashphotos/

This is a very nasty regression, for obvious reasons.

--Andy

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
@ 2009-10-29 19:57     ` Andrew Lutomirski
  0 siblings, 0 replies; 26+ messages in thread
From: Andrew Lutomirski @ 2009-10-29 19:57 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Kernel Mailing List, Kernel Testers List, Shawn Starr,
	Theodore Tso

On Mon, Oct 26, 2009 at 2:55 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.31.  Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> Subject         : EXT4 corruption
> Submitter       : Shawn Starr <shawn.starr@rogers.com>
> Date            : 2009-10-13 2:07 (14 days old)
> References      : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> Handled-By      : Theodore Tso <tytso@mit.edu>
>


This but is *not* fixed.  I just triggered it a few minutes ago by
abusing i915 and drm, which caused a panic.  This is slightly newer
than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.

Photos are here:
http://web.mit.edu/luto/www/ext4_crashphotos/

This is a very nasty regression, for obvious reasons.

--Andy

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug 14472] EXT4 corruption
  2009-10-26 16:52 [Bug 14472] New: EXT4 corruption bugzilla-daemon
@ 2009-10-29 21:31 ` bugzilla-daemon
  2009-10-29 21:38 ` bugzilla-daemon
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 26+ messages in thread
From: bugzilla-daemon @ 2009-10-29 21:31 UTC (permalink / raw)
  To: linux-ext4

http://bugzilla.kernel.org/show_bug.cgi?id=14472





--- Comment #1 from Rafael J. Wysocki <rjw@sisk.pl>  2009-10-29 21:31:10 ---
On Thursday 29 October 2009, Andrew Lutomirski wrote:
> On Mon, Oct 26, 2009 at 2:55 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.31.  Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> > Subject         : EXT4 corruption
> > Submitter       : Shawn Starr <shawn.starr@rogers.com>
> > Date            : 2009-10-13 2:07 (14 days old)
> > References      : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> > Handled-By      : Theodore Tso <tytso@mit.edu>
> >
> 
> 
> This but is *not* fixed.  I just triggered it a few minutes ago by
> abusing i915 and drm, which caused a panic.  This is slightly newer
> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
> 
> Photos are here:
> http://web.mit.edu/luto/www/ext4_crashphotos/
> 
> This is a very nasty regression, for obvious reasons.

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-10-29 19:57     ` Andrew Lutomirski
@ 2009-10-29 21:33         ` Rafael J. Wysocki
  -1 siblings, 0 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2009-10-29 21:33 UTC (permalink / raw)
  To: Andrew Lutomirski
  Cc: Linux Kernel Mailing List, Kernel Testers List, Shawn Starr,
	Theodore Tso

On Thursday 29 October 2009, Andrew Lutomirski wrote:
> On Mon, Oct 26, 2009 at 2:55 PM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.31.  Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> > Subject         : EXT4 corruption
> > Submitter       : Shawn Starr <shawn.starr-bJEeYj9oJeDQT0dZR+AlfA@public.gmane.org>
> > Date            : 2009-10-13 2:07 (14 days old)
> > References      : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> > Handled-By      : Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org>
> >
> 
> 
> This but is *not* fixed.  I just triggered it a few minutes ago by
> abusing i915 and drm, which caused a panic.  This is slightly newer
> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
> 
> Photos are here:
> http://web.mit.edu/luto/www/ext4_crashphotos/
> 
> This is a very nasty regression, for obvious reasons.

Thanks for the update.

Rafael

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
@ 2009-10-29 21:33         ` Rafael J. Wysocki
  0 siblings, 0 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2009-10-29 21:33 UTC (permalink / raw)
  To: Andrew Lutomirski
  Cc: Linux Kernel Mailing List, Kernel Testers List, Shawn Starr,
	Theodore Tso

On Thursday 29 October 2009, Andrew Lutomirski wrote:
> On Mon, Oct 26, 2009 at 2:55 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.31.  Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> > Subject         : EXT4 corruption
> > Submitter       : Shawn Starr <shawn.starr@rogers.com>
> > Date            : 2009-10-13 2:07 (14 days old)
> > References      : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> > Handled-By      : Theodore Tso <tytso@mit.edu>
> >
> 
> 
> This but is *not* fixed.  I just triggered it a few minutes ago by
> abusing i915 and drm, which caused a panic.  This is slightly newer
> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
> 
> Photos are here:
> http://web.mit.edu/luto/www/ext4_crashphotos/
> 
> This is a very nasty regression, for obvious reasons.

Thanks for the update.

Rafael

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug 14472] EXT4 corruption
  2009-10-26 16:52 [Bug 14472] New: EXT4 corruption bugzilla-daemon
  2009-10-29 21:31 ` [Bug 14472] " bugzilla-daemon
@ 2009-10-29 21:38 ` bugzilla-daemon
  2009-10-29 21:44 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 26+ messages in thread
From: bugzilla-daemon @ 2009-10-29 21:38 UTC (permalink / raw)
  To: linux-ext4

http://bugzilla.kernel.org/show_bug.cgi?id=14472


Parag Warudkar <parag.warudkar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |parag.warudkar@gmail.com




--- Comment #2 from Parag Warudkar <parag.warudkar@gmail.com>  2009-10-29 21:38:47 ---
I looked at the fsck pics - I have gone through this a few days ago. 

Aneesh suggested to apply the below patch and after applying it and crashing
the machine couple times I have not observed the corruption. So I have reason
to hope this patch below on top of today's git should improve things. Please
try.

commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65
Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Date:   Tue Oct 27 15:36:38 2009 +0530

   ext4: discard preallocation during truncate

   We need to make sure when we drop and reacquire the inode's
   i_data_sem we discard the inode preallocation. Otherwise we
   could have blocks marked as free in bitmap but still belonging
   to prealloc space.

   Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 5c5bc5d..a1ef1c3 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -209,6 +209,12 @@ static int try_to_extend_transaction(handle_t *handle,
struct inode *inode)
       up_write(&EXT4_I(inode)->i_data_sem);
       ret = ext4_journal_restart(handle, blocks_for_truncate(inode));
       down_write(&EXT4_I(inode)->i_data_sem);
+       /*
+        * We have dropped i_data_sem. So somebody else could have done
+        * block allocation. So discard the prealloc space created as a
+        * part of block allocation
+        */
+       ext4_discard_preallocations(inode);

       return ret;
 }

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply related	[flat|nested] 26+ messages in thread

* [Bug 14472] EXT4 corruption
  2009-10-26 16:52 [Bug 14472] New: EXT4 corruption bugzilla-daemon
  2009-10-29 21:31 ` [Bug 14472] " bugzilla-daemon
  2009-10-29 21:38 ` bugzilla-daemon
@ 2009-10-29 21:44 ` bugzilla-daemon
  2009-11-17 22:30 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 26+ messages in thread
From: bugzilla-daemon @ 2009-10-29 21:44 UTC (permalink / raw)
  To: linux-ext4

http://bugzilla.kernel.org/show_bug.cgi?id=14472


Eric Sandeen <sandeen@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandeen@redhat.com




--- Comment #3 from Eric Sandeen <sandeen@redhat.com>  2009-10-29 21:44:45 ---
Lest champagne break out too early, I have still seen corruption with this
patch in place, while running my testcase (mentioned in bug #14354)

-Eric

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-10-29 19:57     ` Andrew Lutomirski
@ 2009-10-29 22:23         ` Theodore Tso
  -1 siblings, 0 replies; 26+ messages in thread
From: Theodore Tso @ 2009-10-29 22:23 UTC (permalink / raw)
  To: Andrew Lutomirski
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Kernel Testers List,
	Shawn Starr

On Thu, Oct 29, 2009 at 03:57:32PM -0400, Andrew Lutomirski wrote:
> 
> This but is *not* fixed.  I just triggered it a few minutes ago by
> abusing i915 and drm, which caused a panic.  This is slightly newer
> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.

Andrew, can you test to see if this patch helps?

Thanks,

						- Ted

commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65
Author: Aneesh Kumar K.V <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date:   Tue Oct 27 15:36:38 2009 +0530

    ext4: discard preallocation during truncate
    
    We need to make sure when we drop and reacquire the inode's
    i_data_sem we discard the inode preallocation. Otherwise we
    could have blocks marked as free in bitmap but still belonging
    to prealloc space.
    
    Signed-off-by: Aneesh Kumar K.V <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 5c5bc5d..a1ef1c3 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -209,6 +209,12 @@ static int try_to_extend_transaction(handle_t *handle, struct inode *inode)
 	up_write(&EXT4_I(inode)->i_data_sem);
 	ret = ext4_journal_restart(handle, blocks_for_truncate(inode));
 	down_write(&EXT4_I(inode)->i_data_sem);
+	/*
+	 * We have dropped i_data_sem. So somebody else could have done
+	 * block allocation. So discard the prealloc space created as a
+	 * part of block allocation
+	 */
+	ext4_discard_preallocations(inode);
 
 	return ret;
 }

^ permalink raw reply related	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
@ 2009-10-29 22:23         ` Theodore Tso
  0 siblings, 0 replies; 26+ messages in thread
From: Theodore Tso @ 2009-10-29 22:23 UTC (permalink / raw)
  To: Andrew Lutomirski
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Kernel Testers List,
	Shawn Starr

On Thu, Oct 29, 2009 at 03:57:32PM -0400, Andrew Lutomirski wrote:
> 
> This but is *not* fixed.  I just triggered it a few minutes ago by
> abusing i915 and drm, which caused a panic.  This is slightly newer
> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.

Andrew, can you test to see if this patch helps?

Thanks,

						- Ted

commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65
Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Date:   Tue Oct 27 15:36:38 2009 +0530

    ext4: discard preallocation during truncate
    
    We need to make sure when we drop and reacquire the inode's
    i_data_sem we discard the inode preallocation. Otherwise we
    could have blocks marked as free in bitmap but still belonging
    to prealloc space.
    
    Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 5c5bc5d..a1ef1c3 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -209,6 +209,12 @@ static int try_to_extend_transaction(handle_t *handle, struct inode *inode)
 	up_write(&EXT4_I(inode)->i_data_sem);
 	ret = ext4_journal_restart(handle, blocks_for_truncate(inode));
 	down_write(&EXT4_I(inode)->i_data_sem);
+	/*
+	 * We have dropped i_data_sem. So somebody else could have done
+	 * block allocation. So discard the prealloc space created as a
+	 * part of block allocation
+	 */
+	ext4_discard_preallocations(inode);
 
 	return ret;
 }

^ permalink raw reply related	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
       [not found]         ` <20091029222335.GJ18464-3s7WtUTddSA@public.gmane.org>
@ 2009-10-29 22:34           ` Andrew Lutomirski
  2009-11-03 23:43             ` Andrew Lutomirski
  1 sibling, 0 replies; 26+ messages in thread
From: Andrew Lutomirski @ 2009-10-29 22:34 UTC (permalink / raw)
  To: Theodore Tso, Andrew Lutomirski, Rafael J. Wysocki,
	Linux Kernel Mailing List, Kernel Testers List <kerne>

On Thu, Oct 29, 2009 at 6:23 PM, Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org> wrote:
> On Thu, Oct 29, 2009 at 03:57:32PM -0400, Andrew Lutomirski wrote:
>>
>> This but is *not* fixed.  I just triggered it a few minutes ago by
>> abusing i915 and drm, which caused a panic.  This is slightly newer
>> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
>
> Andrew, can you test to see if this patch helps?

I'm building a kernel with that patch now, and I'll keep running it
for awhile.  I only seem to trigger this bug once a month or so, so
I'll let you know if I see any more corruption.

Thanks,
Andy

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-10-29 22:23         ` Theodore Tso
  (?)
@ 2009-10-29 22:34         ` Andrew Lutomirski
  2009-10-29 22:43           ` Shawn Starr
  -1 siblings, 1 reply; 26+ messages in thread
From: Andrew Lutomirski @ 2009-10-29 22:34 UTC (permalink / raw)
  To: Theodore Tso, Andrew Lutomirski, Rafael J. Wysocki,
	Linux Kernel Mailing List, Kernel Testers List, Shawn Starr

On Thu, Oct 29, 2009 at 6:23 PM, Theodore Tso <tytso@mit.edu> wrote:
> On Thu, Oct 29, 2009 at 03:57:32PM -0400, Andrew Lutomirski wrote:
>>
>> This but is *not* fixed.  I just triggered it a few minutes ago by
>> abusing i915 and drm, which caused a panic.  This is slightly newer
>> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
>
> Andrew, can you test to see if this patch helps?

I'm building a kernel with that patch now, and I'll keep running it
for awhile.  I only seem to trigger this bug once a month or so, so
I'll let you know if I see any more corruption.

Thanks,
Andy

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-10-29 22:34         ` Andrew Lutomirski
@ 2009-10-29 22:43           ` Shawn Starr
  0 siblings, 0 replies; 26+ messages in thread
From: Shawn Starr @ 2009-10-29 22:43 UTC (permalink / raw)
  To: Andrew Lutomirski
  Cc: Theodore Tso, Rafael J. Wysocki, Linux Kernel Mailing List,
	Kernel Testers List

On October 29, 2009 06:34:45 pm Andrew Lutomirski wrote:
> On Thu, Oct 29, 2009 at 6:23 PM, Theodore Tso <tytso@mit.edu> wrote:
> > On Thu, Oct 29, 2009 at 03:57:32PM -0400, Andrew Lutomirski wrote:
> >> This but is *not* fixed.  I just triggered it a few minutes ago by
> >> abusing i915 and drm, which caused a panic.  This is slightly newer
> >> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
> >
> > Andrew, can you test to see if this patch helps?
> 
> I'm building a kernel with that patch now, and I'll keep running it
> for awhile.  I only seem to trigger this bug once a month or so, so
> I'll let you know if I see any more corruption.
> 
> Thanks,
> Andy
> 

You should be able to trigger this using the same method I did. To mistakenly 
cause modprobe to spawn unlimited processes ending up in a swap storm.

Thanks, 
Shawn.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-10-29 22:23         ` Theodore Tso
@ 2009-11-03 23:43             ` Andrew Lutomirski
  -1 siblings, 0 replies; 26+ messages in thread
From: Andrew Lutomirski @ 2009-11-03 23:43 UTC (permalink / raw)
  To: Theodore Tso, Andrew Lutomirski, Rafael J. Wysocki,
	Linux Kernel Mailing List, Kernel Testers List <kerne>

On Thu, Oct 29, 2009 at 5:23 PM, Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org> wrote:
> On Thu, Oct 29, 2009 at 03:57:32PM -0400, Andrew Lutomirski wrote:
>>
>> This but is *not* fixed.  I just triggered it a few minutes ago by
>> abusing i915 and drm, which caused a panic.  This is slightly newer
>> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
>
> Andrew, can you test to see if this patch helps?
>
> Thanks,
>
>                                                - Ted
>
> commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65
> Author: Aneesh Kumar K.V <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Date:   Tue Oct 27 15:36:38 2009 +0530
>
>    ext4: discard preallocation during truncate
>
>    We need to make sure when we drop and reacquire the inode's
>    i_data_sem we discard the inode preallocation. Otherwise we
>    could have blocks marked as free in bitmap but still belonging
>    to prealloc space.
>
>    Signed-off-by: Aneesh Kumar K.V <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKQ@public.gmane.orgom>
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 5c5bc5d..a1ef1c3 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -209,6 +209,12 @@ static int try_to_extend_transaction(handle_t *handle, struct inode *inode)
>        up_write(&EXT4_I(inode)->i_data_sem);
>        ret = ext4_journal_restart(handle, blocks_for_truncate(inode));
>        down_write(&EXT4_I(inode)->i_data_sem);
> +       /*
> +        * We have dropped i_data_sem. So somebody else could have done
> +        * block allocation. So discard the prealloc space created as a
> +        * part of block allocation
> +        */
> +       ext4_discard_preallocations(inode);
>
>        return ret;
>  }
>


It looks like 2.6.32-rc6 is supposed to fix this bug, but it also
looks like this patch didn't make it in.  Should I still be using this
patch?

Thanks,
Andy

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
@ 2009-11-03 23:43             ` Andrew Lutomirski
  0 siblings, 0 replies; 26+ messages in thread
From: Andrew Lutomirski @ 2009-11-03 23:43 UTC (permalink / raw)
  To: Theodore Tso, Andrew Lutomirski, Rafael J. Wysocki,
	Linux Kernel Mailing List, Kernel Testers List, Shawn Starr

On Thu, Oct 29, 2009 at 5:23 PM, Theodore Tso <tytso@mit.edu> wrote:
> On Thu, Oct 29, 2009 at 03:57:32PM -0400, Andrew Lutomirski wrote:
>>
>> This but is *not* fixed.  I just triggered it a few minutes ago by
>> abusing i915 and drm, which caused a panic.  This is slightly newer
>> than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
>
> Andrew, can you test to see if this patch helps?
>
> Thanks,
>
>                                                - Ted
>
> commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65
> Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Date:   Tue Oct 27 15:36:38 2009 +0530
>
>    ext4: discard preallocation during truncate
>
>    We need to make sure when we drop and reacquire the inode's
>    i_data_sem we discard the inode preallocation. Otherwise we
>    could have blocks marked as free in bitmap but still belonging
>    to prealloc space.
>
>    Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 5c5bc5d..a1ef1c3 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -209,6 +209,12 @@ static int try_to_extend_transaction(handle_t *handle, struct inode *inode)
>        up_write(&EXT4_I(inode)->i_data_sem);
>        ret = ext4_journal_restart(handle, blocks_for_truncate(inode));
>        down_write(&EXT4_I(inode)->i_data_sem);
> +       /*
> +        * We have dropped i_data_sem. So somebody else could have done
> +        * block allocation. So discard the prealloc space created as a
> +        * part of block allocation
> +        */
> +       ext4_discard_preallocations(inode);
>
>        return ret;
>  }
>


It looks like 2.6.32-rc6 is supposed to fix this bug, but it also
looks like this patch didn't make it in.  Should I still be using this
patch?

Thanks,
Andy

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-11-03 23:43             ` Andrew Lutomirski
@ 2009-11-05 19:31                 ` Theodore Tso
  -1 siblings, 0 replies; 26+ messages in thread
From: Theodore Tso @ 2009-11-05 19:31 UTC (permalink / raw)
  To: Andrew Lutomirski
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Kernel Testers List,
	Shawn Starr

On Tue, Nov 03, 2009 at 06:43:11PM -0500, Andrew Lutomirski wrote:
> It looks like 2.6.32-rc6 is supposed to fix this bug, but it also
> looks like this patch didn't make it in.  Should I still be using this
> patch?

This patch does fix a potential problem and I am planning on pushing
it to Linus; the chances of hitting the race is quite low, though; the
revert which Eric identified is probably what was affecting most of
the people who were seeing problems with ext4 in 2.6.32-rcX.

    	       	    	   	    	      	 - Ted

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
@ 2009-11-05 19:31                 ` Theodore Tso
  0 siblings, 0 replies; 26+ messages in thread
From: Theodore Tso @ 2009-11-05 19:31 UTC (permalink / raw)
  To: Andrew Lutomirski
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Kernel Testers List,
	Shawn Starr

On Tue, Nov 03, 2009 at 06:43:11PM -0500, Andrew Lutomirski wrote:
> It looks like 2.6.32-rc6 is supposed to fix this bug, but it also
> looks like this patch didn't make it in.  Should I still be using this
> patch?

This patch does fix a potential problem and I am planning on pushing
it to Linus; the chances of hitting the race is quite low, though; the
revert which Eric identified is probably what was affecting most of
the people who were seeing problems with ext4 in 2.6.32-rcX.

    	       	    	   	    	      	 - Ted

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug #14472] EXT4 corruption
  2009-11-16 22:33 2.6.32-rc7-git1: Reported regressions from 2.6.31 Rafael J. Wysocki
@ 2009-11-16 22:37 ` Rafael J. Wysocki
  2009-11-16 23:30   ` Andy Lutomirski
  0 siblings, 1 reply; 26+ messages in thread
From: Rafael J. Wysocki @ 2009-11-16 22:37 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: Kernel Testers List, Andy Lutomirski, Aneesh Kumar K.V,
	Shawn Starr, Theodore Tso

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.31.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14472
Subject		: EXT4 corruption
Submitter	: Shawn Starr <shawn.starr@rogers.com>
Date		: 2009-10-13 2:07 (35 days old)
References	: http://marc.info/?l=linux-kernel&m=125539997508256&w=4
Handled-By	: Theodore Tso <tytso@mit.edu>


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-11-16 22:37 ` [Bug #14472] EXT4 corruption Rafael J. Wysocki
@ 2009-11-16 23:30   ` Andy Lutomirski
       [not found]     ` <9872C96C-FAE8-46E8-9588-25D917AF0EAD-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 26+ messages in thread
From: Andy Lutomirski @ 2009-11-16 23:30 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Kernel Mailing List, Kernel Testers List, Andy Lutomirski,
	Aneesh Kumar K.V, Shawn Starr, Theodore Tso

I'm think this was the journal checksumming bug, which is fixed.

-Andy



On Nov 16, 2009, at 5:37 PM, "Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.31.  Please verify if it still should be listed and let me  
> know
> (either way).
>
>
> Bug-Entry    : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> Subject        : EXT4 corruption
> Submitter    : Shawn Starr <shawn.starr@rogers.com>
> Date        : 2009-10-13 2:07 (35 days old)
> References    : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> Handled-By    : Theodore Tso <tytso@mit.edu>
>
>

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug 14472] EXT4 corruption
  2009-10-26 16:52 [Bug 14472] New: EXT4 corruption bugzilla-daemon
                   ` (2 preceding siblings ...)
  2009-10-29 21:44 ` bugzilla-daemon
@ 2009-11-17 22:30 ` bugzilla-daemon
  2009-11-17 22:31 ` bugzilla-daemon
  2009-11-17 22:31 ` bugzilla-daemon
  5 siblings, 0 replies; 26+ messages in thread
From: bugzilla-daemon @ 2009-11-17 22:30 UTC (permalink / raw)
  To: linux-ext4

http://bugzilla.kernel.org/show_bug.cgi?id=14472





--- Comment #4 from Rafael J. Wysocki <rjw@sisk.pl>  2009-11-17 22:30:40 ---
On Tuesday 17 November 2009, Andy Lutomirski wrote:
> I'm think this was the journal checksumming bug, which is fixed.
> 
> 
> On Nov 16, 2009, at 5:37 PM, "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.31.  Please verify if it still should be listed and let me  
> > know
> > (either way).
> >
> >
> > Bug-Entry    : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> > Subject        : EXT4 corruption
> > Submitter    : Shawn Starr <shawn.starr@rogers.com>
> > Date        : 2009-10-13 2:07 (35 days old)
> > References    : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> > Handled-By    : Theodore Tso <tytso@mit.edu>

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug 14472] EXT4 corruption
  2009-10-26 16:52 [Bug 14472] New: EXT4 corruption bugzilla-daemon
                   ` (3 preceding siblings ...)
  2009-11-17 22:30 ` bugzilla-daemon
@ 2009-11-17 22:31 ` bugzilla-daemon
  2009-11-17 22:31 ` bugzilla-daemon
  5 siblings, 0 replies; 26+ messages in thread
From: bugzilla-daemon @ 2009-11-17 22:31 UTC (permalink / raw)
  To: linux-ext4

http://bugzilla.kernel.org/show_bug.cgi?id=14472


Rafael J. Wysocki <rjw@sisk.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [Bug 14472] EXT4 corruption
  2009-10-26 16:52 [Bug 14472] New: EXT4 corruption bugzilla-daemon
                   ` (4 preceding siblings ...)
  2009-11-17 22:31 ` bugzilla-daemon
@ 2009-11-17 22:31 ` bugzilla-daemon
  5 siblings, 0 replies; 26+ messages in thread
From: bugzilla-daemon @ 2009-11-17 22:31 UTC (permalink / raw)
  To: linux-ext4

http://bugzilla.kernel.org/show_bug.cgi?id=14472


Rafael J. Wysocki <rjw@sisk.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
  2009-11-16 23:30   ` Andy Lutomirski
@ 2009-11-17 22:32         ` Rafael J. Wysocki
  0 siblings, 0 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2009-11-17 22:32 UTC (permalink / raw)
  To: Andy Lutomirski
  Cc: Linux Kernel Mailing List, Kernel Testers List, Andy Lutomirski,
	Aneesh Kumar K.V, Shawn Starr, Theodore Tso

On Tuesday 17 November 2009, Andy Lutomirski wrote:
> I'm think this was the journal checksumming bug, which is fixed.

Thanks for the update.


> On Nov 16, 2009, at 5:37 PM, "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> 
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.31.  Please verify if it still should be listed and let me  
> > know
> > (either way).
> >
> >
> > Bug-Entry    : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> > Subject        : EXT4 corruption
> > Submitter    : Shawn Starr <shawn.starr-bJEeYj9oJeDQT0dZR+AlfA@public.gmane.org>
> > Date        : 2009-10-13 2:07 (35 days old)
> > References    : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> > Handled-By    : Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org>

I'm going to close the bug.

Rafael

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [Bug #14472] EXT4 corruption
@ 2009-11-17 22:32         ` Rafael J. Wysocki
  0 siblings, 0 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2009-11-17 22:32 UTC (permalink / raw)
  To: Andy Lutomirski
  Cc: Linux Kernel Mailing List, Kernel Testers List, Andy Lutomirski,
	Aneesh Kumar K.V, Shawn Starr, Theodore Tso

On Tuesday 17 November 2009, Andy Lutomirski wrote:
> I'm think this was the journal checksumming bug, which is fixed.

Thanks for the update.


> On Nov 16, 2009, at 5:37 PM, "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.31.  Please verify if it still should be listed and let me  
> > know
> > (either way).
> >
> >
> > Bug-Entry    : http://bugzilla.kernel.org/show_bug.cgi?id=14472
> > Subject        : EXT4 corruption
> > Submitter    : Shawn Starr <shawn.starr@rogers.com>
> > Date        : 2009-10-13 2:07 (35 days old)
> > References    : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
> > Handled-By    : Theodore Tso <tytso@mit.edu>

I'm going to close the bug.

Rafael

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2009-11-17 22:32 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-26 16:52 [Bug 14472] New: EXT4 corruption bugzilla-daemon
2009-10-29 21:31 ` [Bug 14472] " bugzilla-daemon
2009-10-29 21:38 ` bugzilla-daemon
2009-10-29 21:44 ` bugzilla-daemon
2009-11-17 22:30 ` bugzilla-daemon
2009-11-17 22:31 ` bugzilla-daemon
2009-11-17 22:31 ` bugzilla-daemon
  -- strict thread matches above, loose matches on Subject: below --
2009-10-26 18:45 2.6.32-rc5-git3: Reported regressions from 2.6.31 Rafael J. Wysocki
2009-10-26 18:55 ` [Bug #14472] EXT4 corruption Rafael J. Wysocki
2009-10-26 18:55   ` Rafael J. Wysocki
2009-10-29 19:57   ` Andrew Lutomirski
2009-10-29 19:57     ` Andrew Lutomirski
     [not found]     ` <cb0375e10910291257t1f2f16ciade932bd78689ccc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-29 21:33       ` Rafael J. Wysocki
2009-10-29 21:33         ` Rafael J. Wysocki
2009-10-29 22:23       ` Theodore Tso
2009-10-29 22:23         ` Theodore Tso
2009-10-29 22:34         ` Andrew Lutomirski
2009-10-29 22:43           ` Shawn Starr
     [not found]         ` <20091029222335.GJ18464-3s7WtUTddSA@public.gmane.org>
2009-10-29 22:34           ` Andrew Lutomirski
2009-11-03 23:43           ` Andrew Lutomirski
2009-11-03 23:43             ` Andrew Lutomirski
     [not found]             ` <cb0375e10911031543n5cfcc090k8780449a1413b067-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-05 19:31               ` Theodore Tso
2009-11-05 19:31                 ` Theodore Tso
2009-11-16 22:33 2.6.32-rc7-git1: Reported regressions from 2.6.31 Rafael J. Wysocki
2009-11-16 22:37 ` [Bug #14472] EXT4 corruption Rafael J. Wysocki
2009-11-16 23:30   ` Andy Lutomirski
     [not found]     ` <9872C96C-FAE8-46E8-9588-25D917AF0EAD-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-17 22:32       ` Rafael J. Wysocki
2009-11-17 22:32         ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.